Put versions in all WASI WIT files #7272
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit starts exercising the versioning feature of WIT by ensuring that all WASI descriptions have a version associated with them. The version chosen is 0.2.0 which reflects the upcoming "preview 2" release where in theory 0.1.0 was claimed by preview1. This is intended to stay as 0.2.0 for now and we'll determine how best to update these numbers in the future once preview2 is released. Closes bytecodealliance#7171
pchickey
requested changes
Oct 17, 2023
There was a problem hiding this comment.
Until we have a vote on 0.2.0 I don't want to risk any binaries being out in the world with that version in them - can we please use 0.2.0-rc-2023-10-17 per https://docs.google.com/presentation/d/1t8rTwkJA28IvFvyqy3K49jy8Sm0xUsk-vZssFAruD8o/edit#slide=id.g22e9d051ccb_0_15
As a convenience for now this enables omitting the version of an interface from a `with` key. This has a risk of not working well if two packages are present and one has a version and one doesn't, but that's left as a PR to fix in the future as the benefit of avoiding repetition seems good for now.
|
Sounds reasonable to me yeah, although I'm not a fan of typing unwieldy version strings so that's motivated me to write up bytecodealliance/wasm-tools#1255, bytecodealliance/wit-bindgen#703, and some further improvements for wasmtime's own bindgen. That should enable avoid forcing the need for versions in more places throughout the tooling. It'll still be required in the WIT syntax itself but I think that should be fixable with Peter's |
|
On second though I'm gonna decouple these. There's some wasmtime improvements here to write versions less but the rest in the Rust sources will go away once I update wit-bindgen and wasm-tools which I'll do separately. Otherwise though the versions should be updated to |
alexcrichton
added a commit
to alexcrichton/wasmtime
that referenced
this pull request
Oct 18, 2023
This'll have some knock-on effects when applied to bytecodealliance#7272 but that's left for a future PR. This one's just about getting the deps in.
pchickey
approved these changes
Oct 18, 2023
github-merge-queue bot
pushed a commit
that referenced
this pull request
Oct 18, 2023
This'll have some knock-on effects when applied to #7272 but that's left for a future PR. This one's just about getting the deps in.
alexcrichton
added a commit
to alexcrichton/wasmtime
that referenced
this pull request
Oct 19, 2023
* Put versions in all WASI WIT files This commit starts exercising the versioning feature of WIT by ensuring that all WASI descriptions have a version associated with them. The version chosen is 0.2.0 which reflects the upcoming "preview 2" release where in theory 0.1.0 was claimed by preview1. This is intended to stay as 0.2.0 for now and we'll determine how best to update these numbers in the future once preview2 is released. Closes bytecodealliance#7171 * Allow omitting versions in `with` keys As a convenience for now this enables omitting the version of an interface from a `with` key. This has a risk of not working well if two packages are present and one has a version and one doesn't, but that's left as a PR to fix in the future as the benefit of avoiding repetition seems good for now. * Allow omitting versions in trappable_error_types * Use 0.2.0-rc-2023-10-18 as a version number * More test fixes * Fix another test
alexcrichton
added a commit
that referenced
this pull request
Oct 19, 2023
* Put versions in all WASI WIT files This commit starts exercising the versioning feature of WIT by ensuring that all WASI descriptions have a version associated with them. The version chosen is 0.2.0 which reflects the upcoming "preview 2" release where in theory 0.1.0 was claimed by preview1. This is intended to stay as 0.2.0 for now and we'll determine how best to update these numbers in the future once preview2 is released. Closes #7171 * Allow omitting versions in `with` keys As a convenience for now this enables omitting the version of an interface from a `with` key. This has a risk of not working well if two packages are present and one has a version and one doesn't, but that's left as a PR to fix in the future as the benefit of avoiding repetition seems good for now. * Allow omitting versions in trappable_error_types * Use 0.2.0-rc-2023-10-18 as a version number * More test fixes * Fix another test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit starts exercising the versioning feature of WIT by ensuring that all WASI descriptions have a version associated with them. The version chosen is 0.2.0 which reflects the upcoming "preview 2" release where in theory 0.1.0 was claimed by preview1. This is intended to stay as 0.2.0 for now and we'll determine how best to update these numbers in the future once preview2 is released.
Closes #7171