Clean seed words text area when returns from empty wallet view #1904
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
BTW, I can't take screenshots because of security policies of the app |
Pedro-vk
force-pushed
the
pedro-vk/clean-seed-words
branch
from
ed37985
to
b4ed489
Compare
jmrossy
reviewed
Nov 27, 2019
There was a problem hiding this comment.
Can you use the imperative version of these APIs? they're more concise.
https://reactnavigation.org/docs/en/navigation-events.html
Pedro-vk
force-pushed
the
pedro-vk/clean-seed-words
branch
3 times, most recently
from
edcc443
to
b37f493
Compare
Pedro-vk
force-pushed
the
pedro-vk/clean-seed-words
branch
11 times, most recently
from
f74ce75
to
b54a644
Compare
Codecov Report
@@ Coverage Diff @@
## master #1904 +/- ##
=========================================
Coverage ? 74.43%
=========================================
Files ? 281
Lines ? 7822
Branches ? 686
=========================================
Hits ? 5822
Misses ? 1883
Partials ? 117
Continue to review full report at Codecov.
|
Pedro-vk
force-pushed
the
pedro-vk/clean-seed-words
branch
from
b54a644
to
f2a14b9
Compare
aaronmgdr
added a commit
that referenced
this pull request
Dec 5, 2019
* master: (27 commits) Experience Brand Kit 1.0 (#1948) Adjust reference to the rewards app (#2065) [Wallet] Compatibility with exchange rate in string format (#2060) Fix Typo in CI config (#2056) Fix additional attestations instructions (#2057) Allow a specified address to disable/enable rewards distribution (#1828) Aaronmgdr/leaderboard patch (#2055) Move attestation service instructions to main page (#2051) Point To Updated Join Celo Video (#2052) Fix minor issue withe the ordering of instructions changes to docs related to discovery (#2025) [Docs] Fix typos in Running a Validator docs (#2045) Add node flag to celocli to set the target node for a single command (#2020) Fix broken links and spruce up CLI docs for accounts command (#2027) Prevent clipping of arrow component (#2036) Allocates an initial balance to the attestation bot (#2019) gold and dollar flags are required for faucet script (#1943) Clean seed words text area when returns from empty wallet view (#1904) Update validator script (#2026) Docs: PoS, metadata, gateway fee plus cleanup (#2022) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Clean seed words text area when returns from empty wallet view
Tested
Tested on Android after
Related issues
Backwards compatibility
Backward compatible