Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken links and spruce up CLI docs for accounts command #2027

Merged
merged 5 commits into from
Dec 4, 2019

Conversation

nategraf
Copy link
Contributor

@nategraf nategraf commented Dec 4, 2019

Description

  • I found a CLI took to identify broken links and fixed them 👍
  • I added some more description to the claim-* commands because I was initially confused as to what they do.

@codecov
Copy link

codecov bot commented Dec 4, 2019

Codecov Report

Merging #2027 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           master    #2027    +/-   ##
========================================
  Coverage   74.43%   74.43%            
========================================
  Files         281      281            
  Lines        7822     7822            
  Branches      974      686   -288     
========================================
  Hits         5822     5822            
  Misses       1883     1883            
  Partials      117      117
Flag Coverage Δ
#mobile 74.43% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f58e650...9ddffc6. Read the comment docs.

Copy link
Contributor

@yerdua yerdua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! I really appreciate the extra clarity and context.

Copy link
Contributor

@nambrot nambrot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much for this, so much better!

@nambrot nambrot added the automerge Have PR merge automatically when checks pass label Dec 4, 2019
@nategraf nategraf merged commit 67a1584 into master Dec 4, 2019
aaronmgdr added a commit that referenced this pull request Dec 5, 2019
* master: (27 commits)
  Experience Brand Kit 1.0 (#1948)
  Adjust reference to the rewards app (#2065)
  [Wallet] Compatibility with exchange rate in string format (#2060)
  Fix Typo in CI config (#2056)
  Fix additional attestations instructions (#2057)
  Allow a specified address to disable/enable rewards distribution (#1828)
  Aaronmgdr/leaderboard patch (#2055)
  Move attestation service instructions to main page (#2051)
  Point To Updated Join Celo Video (#2052)
  Fix minor issue withe the ordering of instructions
  changes to docs related to discovery (#2025)
  [Docs] Fix typos in Running a Validator docs (#2045)
  Add node flag to celocli to set the target node for a single command (#2020)
  Fix broken links and spruce up CLI docs for accounts command (#2027)
  Prevent clipping of arrow component (#2036)
  Allocates an initial balance to the attestation bot (#2019)
  gold and dollar flags are required for faucet script (#1943)
  Clean seed words text area when returns from empty wallet view (#1904)
  Update validator script (#2026)
  Docs: PoS, metadata, gateway fee plus cleanup (#2022)
  ...
aaronmgdr added a commit that referenced this pull request Dec 5, 2019
* master: (208 commits)
  Fix potential hard timeouts (#2072)
  Add checkzero,blockscout,mulit-address support to faucet. Fix broken envType checks (#2068)
  README added mission (#1972)
  Add dev-utils README (#2081)
  Add validator:status command to check if a validator signer is online and producing blocks (#1906)
  Experience Brand Kit 1.0 (#1948)
  Adjust reference to the rewards app (#2065)
  [Wallet] Compatibility with exchange rate in string format (#2060)
  Fix Typo in CI config (#2056)
  Fix additional attestations instructions (#2057)
  Allow a specified address to disable/enable rewards distribution (#1828)
  Aaronmgdr/leaderboard patch (#2055)
  Move attestation service instructions to main page (#2051)
  Point To Updated Join Celo Video (#2052)
  Fix minor issue withe the ordering of instructions
  changes to docs related to discovery (#2025)
  [Docs] Fix typos in Running a Validator docs (#2045)
  Add node flag to celocli to set the target node for a single command (#2020)
  Fix broken links and spruce up CLI docs for accounts command (#2027)
  Prevent clipping of arrow component (#2036)
  ...

# Conflicts:
#	packages/web/src/layout/BookLayout.tsx
#	packages/web/src/lib.dom.d.ts
@aaronmgdr aaronmgdr deleted the victor/docs-dec-3 branch December 16, 2021 23:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge Have PR merge automatically when checks pass
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants