Experience Brand Kit 1.0 #1948
Merged
Experience Brand Kit 1.0 #1948
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* master: Adjust e2e transfer and governance tests to match new fee distribution and eliminate ProposerFraction (#1585) [Wallet] Add more local currencies (#1698) Switch to correct cluster when fauceting (#1687) [Wallet] Use the country of the phone number for determining the default local currency (#1684) [Wallet] Limit QR code scanner to 1 code per second (#1676) Update Dark backgrounds text color (#1677) Remove integration sync test Minor attestation service fixes (#1680) Add golang to setup docs
aaronmgdr
commented
Nov 27, 2019
| color: colors.dark, | ||
| textRendering: 'geometricPrecision', | ||
| }, | ||
| // deprecated replaced with h6 | ||
| h5: { |
There was a problem hiding this comment.
I didnt want to cause the diff on this PR to be even larger by changing all font.h5 refs to fonts.h6. i think this can be done separately
aaronmgdr
commented
Nov 27, 2019
| } | ||
|
|
||
| export const fonts = StyleSheet.create({ |
There was a problem hiding this comment.
change this so that on typography page i could print the styles out and know for sure that they matched. DRY
cmcewen
reviewed
Dec 2, 2019
| href: ICONS_PATH, | ||
| sections: [], | ||
| }, | ||
| // { |
There was a problem hiding this comment.
to reduce comments, maybe just define this object outside the array and then don't use it? (might have to ts-ignore)
Add margin to subtitles Make name Celo White Fix monochrome logo
Icons make square small enough for 2x2 on mobile Keep squares square and variable size Add logo downloads Thicken stroke on download icon Remove buttons example Converte minimums to be sag not png for better crispy scale Better mobile spacing in general Add new uiSmall first class type style
Codecov Report
@@ Coverage Diff @@
## master #1948 +/- ##
==========================================
+ Coverage 74.42% 74.43% +<.01%
==========================================
Files 281 281
Lines 7824 7822 -2
Branches 975 686 -289
==========================================
- Hits 5823 5822 -1
+ Misses 1884 1883 -1
Partials 117 117
Continue to review full report at Codecov.
|
cmcewen
approved these changes
Dec 4, 2019
aaronmgdr
added a commit
that referenced
this pull request
Dec 5, 2019
* master: (27 commits) Experience Brand Kit 1.0 (#1948) Adjust reference to the rewards app (#2065) [Wallet] Compatibility with exchange rate in string format (#2060) Fix Typo in CI config (#2056) Fix additional attestations instructions (#2057) Allow a specified address to disable/enable rewards distribution (#1828) Aaronmgdr/leaderboard patch (#2055) Move attestation service instructions to main page (#2051) Point To Updated Join Celo Video (#2052) Fix minor issue withe the ordering of instructions changes to docs related to discovery (#2025) [Docs] Fix typos in Running a Validator docs (#2045) Add node flag to celocli to set the target node for a single command (#2020) Fix broken links and spruce up CLI docs for accounts command (#2027) Prevent clipping of arrow component (#2036) Allocates an initial balance to the attestation bot (#2019) gold and dollar flags are required for faucet script (#1943) Clean seed words text area when returns from empty wallet view (#1904) Update validator script (#2026) Docs: PoS, metadata, gateway fee plus cleanup (#2022) ...
aaronmgdr
added a commit
that referenced
this pull request
Dec 5, 2019
* master: (208 commits) Fix potential hard timeouts (#2072) Add checkzero,blockscout,mulit-address support to faucet. Fix broken envType checks (#2068) README added mission (#1972) Add dev-utils README (#2081) Add validator:status command to check if a validator signer is online and producing blocks (#1906) Experience Brand Kit 1.0 (#1948) Adjust reference to the rewards app (#2065) [Wallet] Compatibility with exchange rate in string format (#2060) Fix Typo in CI config (#2056) Fix additional attestations instructions (#2057) Allow a specified address to disable/enable rewards distribution (#1828) Aaronmgdr/leaderboard patch (#2055) Move attestation service instructions to main page (#2051) Point To Updated Join Celo Video (#2052) Fix minor issue withe the ordering of instructions changes to docs related to discovery (#2025) [Docs] Fix typos in Running a Validator docs (#2045) Add node flag to celocli to set the target node for a single command (#2020) Fix broken links and spruce up CLI docs for accounts command (#2027) Prevent clipping of arrow component (#2036) ... # Conflicts: # packages/web/src/layout/BookLayout.tsx # packages/web/src/lib.dom.d.ts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
A place to get assets / logos/ icons for celo brand. A styleguide for Celo projects.
This is the first part of the Experience tool kit. To start there are 4 pages. Logo, Typogrpahy, color, icons.
Some Highlights.
packages added
yiq916b, tiny lib for determining of color should have dark or light text over it.colortranslator14k, for getting CMYK. not as small as id but didn't have time for smaller one.note a few links are still in TODO
Tested
Logo
Color
Typography
Icons
Other changes
finally replace all the adhoc Links...
..which I had been creating randomly whenever A link was needed to be interpolated into a translated text.
Now there is one
InlineAnchorcomponentRelated issues
Backwards compatibility
brand new!