Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update documentation wrt. epoch rewards fractions #2182

Merged
merged 6 commits into from
Dec 12, 2019
Merged

Conversation

rcroessmann
Copy link
Collaborator

Description

Updates the description of the epoch rewards distribution to the carbon offsetting fund, the community fund and the reserve to reflect latest design decisions and discussion around initial values.

Tested

Not tested.

Other changes

None

@codecov
Copy link

codecov bot commented Dec 11, 2019

Codecov Report

Merging #2182 into master will decrease coverage by 0.11%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2182      +/-   ##
==========================================
- Coverage   74.88%   74.77%   -0.12%     
==========================================
  Files         279      280       +1     
  Lines        7797     7826      +29     
  Branches      971      690     -281     
==========================================
+ Hits         5839     5852      +13     
- Misses       1842     1858      +16     
  Partials      116      116
Flag Coverage Δ
#mobile 74.77% <ø> (-0.12%) ⬇️
Impacted Files Coverage Δ
packages/mobile/src/tokens/saga.ts 91.04% <0%> (ø) ⬆️
packages/mobile/src/networkInfo/saga.ts 33.33% <0%> (ø)
packages/mobile/src/invite/saga.ts 72.61% <0%> (+0.17%) ⬆️
packages/mobile/src/import/saga.ts 84.78% <0%> (+0.33%) ⬆️
packages/mobile/src/web3/saga.ts 38.88% <0%> (+1.07%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5b4ef38...87fdb3d. Read the comment docs.

@timmoreton timmoreton removed their assignment Dec 11, 2019
Copy link
Contributor

@nategraf nategraf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a couple of small suggestions

@@ -2,4 +2,4 @@

The Carbon Offsetting Fund provides for making the infrastructure of the Celo platform carbon-neutral, by making a transfer every epoch to an organization that commits to using those assets off-chain for carbon offsetting projects.

Through the on-chain governance process, Celo Gold holders can set an on-target carbon offset amount, and the address of a carbon offsetting partner to which to direct these transfers. The on-target amount is adjusted by the epoch [rewards mulitplier](epoch-rewards.md), as with all epoch rewards.
Through the on-chain governance process, Celo Gold holders can set the fraction of the total desired epoch rewards, initially planned to be 0.5%, that is received by the carbon offset, and the address of a carbon offsetting partner to which to direct these transfers. The on-target amount is adjusted by the epoch [rewards mulitplier](epoch-rewards.md), as with all epoch rewards.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A link to the governance doc would be helpful.

Suggested change
Through the on-chain governance process, Celo Gold holders can set the fraction of the total desired epoch rewards, initially planned to be 0.5%, that is received by the carbon offset, and the address of a carbon offsetting partner to which to direct these transfers. The on-target amount is adjusted by the epoch [rewards mulitplier](epoch-rewards.md), as with all epoch rewards.
Through the [on-chain governance process](../governance.md), Celo Gold holders can set the fraction of the total desired epoch rewards, initially planned to be 0.5%, that is received by the carbon offset, and the address of a carbon offsetting partner to which to direct these transfers. The on-target amount is adjusted by the epoch [rewards mulitplier](epoch-rewards.md), as with all epoch rewards.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed and done!

@nategraf nategraf removed their assignment Dec 12, 2019
@rcroessmann rcroessmann merged commit d51af7e into master Dec 12, 2019
aaronmgdr added a commit that referenced this pull request Dec 12, 2019
* master:
  [Wallet] Use Charles proxy to see eth JSON rpc calls when using forno (#2204)
  [Wallet] Disable skip button when the user enable contact access (#2224)
  [Wallet] Redesigning notification lists (#1967)
  [Wallet] Fix crash on iOS when segment is enabled (#2222)
  Update documentation wrt. epoch rewards fractions (#2182)
  Improvement facilitating to run a full node (#2130)
  [BlockchainApi] Add ability to get exchange rates from/to cGLD or cUSD (#2005)
  Improve reliability of e2e governance test (#2208)
  Fix/protocol test flakyness (#2155)
  Fix bignumber display in CLI (#2212)
  Doc changes to address frequently asked questions (#2209)
  Upgrade TS version (#2196)
  Wait for only waitTime - 1 blocks (#2207)
  Minor baklava docs reconnection fixes (#2215)
  Update walletkit gateway fee to fix transactions in forno mode (#2211)
  Update baklava network ID in docs for 1.1 (#2214)
  Support more than 1 attesation bot at a time (#2192)
  Check sync status of attestation service (#2191)
  Indicate to run Twilio globally (#2193)
  Add Twilio and attestation bot envs (#2194)
@cmcewen cmcewen deleted the ro/rewards-docs branch December 30, 2019 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants