Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable skip button when the user enables contact access #2224

Merged

Conversation

Pedro-vk
Copy link
Contributor

Description

Disable skip button when the user enables contact access

Tested

Tested on Android device

Other changes

Describe any minor or "drive-by" changes here.

Related issues

@codecov
Copy link

codecov bot commented Dec 12, 2019

Codecov Report

Merging #2224 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           master    #2224    +/-   ##
========================================
  Coverage   74.81%   74.81%            
========================================
  Files         276      276            
  Lines        7766     7766            
  Branches      692      976   +284     
========================================
  Hits         5810     5810            
  Misses       1839     1839            
  Partials      117      117
Flag Coverage Δ
#mobile 74.81% <ø> (ø) ⬆️
Impacted Files Coverage Δ
packages/mobile/src/import/ImportContacts.tsx 74.5% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6e6543b...bcff547. Read the comment docs.

Copy link
Contributor

@jmrossy jmrossy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love a one-liner hehe

@jmrossy jmrossy merged commit 5a1894f into celo-org:master Dec 12, 2019
aaronmgdr added a commit that referenced this pull request Dec 12, 2019
* master:
  [Wallet] Use Charles proxy to see eth JSON rpc calls when using forno (#2204)
  [Wallet] Disable skip button when the user enable contact access (#2224)
  [Wallet] Redesigning notification lists (#1967)
  [Wallet] Fix crash on iOS when segment is enabled (#2222)
  Update documentation wrt. epoch rewards fractions (#2182)
  Improvement facilitating to run a full node (#2130)
  [BlockchainApi] Add ability to get exchange rates from/to cGLD or cUSD (#2005)
  Improve reliability of e2e governance test (#2208)
  Fix/protocol test flakyness (#2155)
  Fix bignumber display in CLI (#2212)
  Doc changes to address frequently asked questions (#2209)
  Upgrade TS version (#2196)
  Wait for only waitTime - 1 blocks (#2207)
  Minor baklava docs reconnection fixes (#2215)
  Update walletkit gateway fee to fix transactions in forno mode (#2211)
  Update baklava network ID in docs for 1.1 (#2214)
  Support more than 1 attesation bot at a time (#2192)
  Check sync status of attestation service (#2191)
  Indicate to run Twilio globally (#2193)
  Add Twilio and attestation bot envs (#2194)
@Pedro-vk Pedro-vk deleted the bugfix/#2218-disable-skip-on-enable-contacts branch December 15, 2019 20:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants