Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/protocol test flakyness #2155

Merged
merged 22 commits into from
Dec 12, 2019

Conversation

H34D
Copy link
Contributor

@H34D H34D commented Dec 10, 2019

Description

  • Activate ts compilation for tests
  • Fix ts errors
  • Make error output more understandable

Tested

ran:

  • yarn test 2 times
  • yarn test epochrewards 10 times

Related issues

Wanted to fix the eventually occurring error:

AssertionError: expected 0.5 and got 0.500000007

@codecov
Copy link

codecov bot commented Dec 10, 2019

Codecov Report

Merging #2155 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2155   +/-   ##
=======================================
  Coverage   74.88%   74.88%           
=======================================
  Files         279      279           
  Lines        7797     7797           
  Branches      690      690           
=======================================
  Hits         5839     5839           
  Misses       1842     1842           
  Partials      116      116
Flag Coverage Δ
#mobile 74.88% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 014bb6b...b093da7. Read the comment docs.

@H34D
Copy link
Contributor Author

H34D commented Dec 11, 2019

ci/circleci: end-to-end-geth-governance-test is fixed in #2037

@H34D H34D mentioned this pull request Dec 11, 2019
1 task
@H34D H34D added the protocol All issues relating to protocol packages label Dec 11, 2019
Copy link
Contributor

@mcortesi mcortesi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love this!

@mcortesi mcortesi assigned H34D and unassigned mcortesi Dec 11, 2019
@timmoreton timmoreton added the automerge Have PR merge automatically when checks pass label Dec 11, 2019
Copy link
Contributor

@asaj asaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥

@asaj asaj unassigned kevjue and H34D Dec 11, 2019
@nategraf nategraf assigned nategraf and unassigned asaj Dec 11, 2019
@nategraf nategraf self-requested a review December 11, 2019 21:33
@nategraf nategraf assigned H34D and unassigned nategraf Dec 11, 2019
@celo-ci-bot-user celo-ci-bot-user merged commit bdff55c into celo-org:master Dec 12, 2019
@H34D H34D deleted the fix/protocol_test_flakyness branch December 12, 2019 08:59
aaronmgdr added a commit that referenced this pull request Dec 12, 2019
* master:
  [Wallet] Use Charles proxy to see eth JSON rpc calls when using forno (#2204)
  [Wallet] Disable skip button when the user enable contact access (#2224)
  [Wallet] Redesigning notification lists (#1967)
  [Wallet] Fix crash on iOS when segment is enabled (#2222)
  Update documentation wrt. epoch rewards fractions (#2182)
  Improvement facilitating to run a full node (#2130)
  [BlockchainApi] Add ability to get exchange rates from/to cGLD or cUSD (#2005)
  Improve reliability of e2e governance test (#2208)
  Fix/protocol test flakyness (#2155)
  Fix bignumber display in CLI (#2212)
  Doc changes to address frequently asked questions (#2209)
  Upgrade TS version (#2196)
  Wait for only waitTime - 1 blocks (#2207)
  Minor baklava docs reconnection fixes (#2215)
  Update walletkit gateway fee to fix transactions in forno mode (#2211)
  Update baklava network ID in docs for 1.1 (#2214)
  Support more than 1 attesation bot at a time (#2192)
  Check sync status of attestation service (#2191)
  Indicate to run Twilio globally (#2193)
  Add Twilio and attestation bot envs (#2194)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge Have PR merge automatically when checks pass protocol All issues relating to protocol packages
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants