update #4
Merged
update #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* fix issue with the ordering of voted groups * run prettify
* expose signer through getValidator * add signer to contractkit wrapper
* Collecting more Validator UX improvements (#1934) * Address comments * Tweaks to docs. Add Baklava network id and Ts&Cs. Fix/clarify err messages. * Tweaks to scripts * review comments
* Update docker images for integration deploy * Update encrypted mnemonic files * Update contrackit for tme * Update TME docker images * Add all command
* Update identity documentation * update transaction and governance docs with new information * remove some duplicate docs * Update glossary * remove suggestion to put password on the cli * PoS docs * Baklava info tidy. Gas pricing updates * tidy up governance * Edits to metadata * Tweaks * Glossary updates * Merge * Remove dupe TOCs, update network_id, re-add alfajores to TOC * edits to full-node guide and cli intro * update some hints * move some sections and add a tip to read the protocol docs * add note about global install issues * update doc * copy intro to baklava to welcome page * remove broken link * add some pointers to the stability mechanism page
* Update script for baklava * More script changes
* Clean seed word text area when returns from empty wallet view * Simplify seed words cleaning * Fix test
H34D
pushed a commit
that referenced
this pull request
May 12, 2021
### Description Fixes made to address comments from OpenZepellin in audit round `#4`. ### Other changes None ### Tested Unit tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
A few sentences describing the overall effects and goals of the pull request's commits.
What is the current behavior, and what is the updated/expected behavior with this PR?
Tested
An explanation of how the changes were tested or an explanation as to why they don't need to be.
Other changes
Describe any minor or "drive-by" changes here.
Related issues
Backwards compatibility
Brief explanation of why these changes are/are not backwards compatible.