feat: track deposit witnesses and egress confirmations [WEB-715] #4370
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #4370 +/- ##
======================================
- Coverage 72% 71% -0%
======================================
Files 394 394
Lines 67055 66904 -151
Branches 67055 66904 -151
======================================
- Hits 48003 47782 -221
- Misses 16620 16688 +68
- Partials 2432 2434 +2 ☔ View full report in Codecov by Sentry. |
acdibble
changed the title
acdibble
changed the title
|
Just saw this. Ill take a look first thing on Wednesday. |
acdibble
force-pushed
the
feat/track-deposit-witnesses
branch
from
ba324bf
to
bbb7aab
Compare
kylezs
reviewed
Jan 2, 2024
acdibble
force-pushed
the
feat/track-deposit-witnesses
branch
from
bbb7aab
to
206857d
Compare
kylezs
reviewed
Jan 8, 2024
kylezs
approved these changes
Jan 8, 2024
syan095
added a commit
that referenced
this pull request
Jan 8, 2024
…-timeout * origin/main: fix: cargo fmt (#4392) Chore/pick 1.1 fixes (#4390) refactor: code cleaniness (#4389) feat: track deposit witnesses and egress confirmations [WEB-715] (#4370) fix: ensure api lib version is bumped (#4387) chore: add reason to DepositIgnored event (#4385) chore: warn on attempt 0 in retrier (#4383) chore: log_or_panic prepends its name (#4384) chore: fix log message formatting (#4380) feat: order_fills rpc (PRO-1044) (#4376) # Conflicts: # state-chain/pallets/cf-broadcast/src/lib.rs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Closes: WEB-715
Checklist
Please conduct a thorough self-review before opening the PR.
Summary
I've gone for a very verbose implementation that exhaustively checks all pallets are handled so we don't get any nasty surprises when later we add more chains. I'm open to different implementations in that regard, but it's the main motivation behind the massive
matchexpression.