-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: code cleaniness #4389
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #4389 +/- ##
======================================
- Coverage 72% 71% -0%
======================================
Files 394 394
Lines 67055 66907 -148
Branches 67055 66907 -148
======================================
- Hits 48003 47779 -224
- Misses 16620 16694 +74
- Partials 2432 2434 +2 ☔ View full report in Codecov by Sentry. |
HttpClientBuilder::default() | ||
.set_headers(HeaderMap::from_iter([( | ||
AUTHORIZATION, | ||
const_eval!(HeaderValue, HeaderValue::from_static("Bearer TOKEN")), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we even need this header actually? It is a little strange that the token is just TOKEN all the time 🤔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Keine ahnung
…-timeout * origin/main: fix: cargo fmt (#4392) Chore/pick 1.1 fixes (#4390) refactor: code cleaniness (#4389) feat: track deposit witnesses and egress confirmations [WEB-715] (#4370) fix: ensure api lib version is bumped (#4387) chore: add reason to DepositIgnored event (#4385) chore: warn on attempt 0 in retrier (#4383) chore: log_or_panic prepends its name (#4384) chore: fix log message formatting (#4380) feat: order_fills rpc (PRO-1044) (#4376) # Conflicts: # state-chain/pallets/cf-broadcast/src/lib.rs
No description provided.