Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix log message formatting #4380

Merged
merged 2 commits into from
Jan 4, 2024
Merged

chore: fix log message formatting #4380

merged 2 commits into from
Jan 4, 2024

Conversation

kylezs
Copy link
Contributor

@kylezs kylezs commented Jan 3, 2024

Annoying seeing the \n\t\t in some log messages like this:

{"timestamp":"2024-01-03T10:51:08.061388Z","level":"ERROR","fields":{"message":"Failed to connect to Polkadot node at https://polkadot.api.onfinality.io:443/rpc?apikey=2cc**** with error: Rpc error: RPC error: Networking or low-level protocol error: Server returned an error status code: 504. Please check your CFE\n\t\t\t\t\t\tconfiguration file. Retrying in 10s..."},"target":"chainflip_engine::dot::http_rpc"}

Copy link

codecov bot commented Jan 3, 2024

Codecov Report

Attention: 14 lines in your changes are missing coverage. Please review.

Comparison is base (e8aa08c) 71% compared to head (6f52804) 71%.
Report is 2 commits behind head on main.

Files Patch % Lines
engine/src/eth/rpc.rs 0% 6 Missing ⚠️
engine/src/btc/rpc.rs 0% 4 Missing ⚠️
engine/src/dot/http_rpc.rs 0% 4 Missing ⚠️
Additional details and impacted files
@@          Coverage Diff          @@
##            main   #4380   +/-   ##
=====================================
  Coverage     71%     71%           
=====================================
  Files        394     394           
  Lines      66829   66892   +63     
  Branches   66829   66892   +63     
=====================================
+ Hits       47703   47770   +67     
+ Misses     16693   16689    -4     
  Partials    2433    2433           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kylezs kylezs merged commit 7658397 into main Jan 4, 2024
43 checks passed
@kylezs kylezs deleted the chore/log-message-format branch January 4, 2024 10:56
syan095 added a commit that referenced this pull request Jan 8, 2024
…-timeout

* origin/main:
  fix: cargo fmt (#4392)
  Chore/pick 1.1 fixes (#4390)
  refactor: code cleaniness (#4389)
  feat: track deposit witnesses and egress confirmations [WEB-715] (#4370)
  fix: ensure api lib version is bumped (#4387)
  chore: add reason to DepositIgnored event (#4385)
  chore: warn on attempt 0 in retrier (#4383)
  chore: log_or_panic prepends its name (#4384)
  chore: fix log message formatting (#4380)
  feat: order_fills rpc (PRO-1044) (#4376)

# Conflicts:
#	state-chain/pallets/cf-broadcast/src/lib.rs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants