feat: order_fills rpc (PRO-1044) #4376
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #4376 +/- ##
=====================================
- Coverage 71% 71% -0%
=====================================
Files 394 394
Lines 66829 66828 -1
Branches 66829 66828 -1
=====================================
- Hits 47703 47700 -3
Misses 16693 16693
- Partials 2433 2435 +2 ☔ View full report in Codecov by Sentry. |
AlastairHolmes
commented
Jan 2, 2024
AlastairHolmes
commented
Jan 2, 2024
| } | ||
| } | ||
|
|
||
| impl From<AnyhowRpcError> for ErrorObjectOwned { |
There was a problem hiding this comment.
check frontend dont use
kylezs
approved these changes
Jan 2, 2024
AlastairHolmes
force-pushed
the
feat/order-fills-rpc
branch
from
33b4675
to
f8c2c84
Compare
AlastairHolmes
force-pushed
the
feat/order-fills-rpc
branch
from
f8c2c84
to
ac1915a
Compare
AlastairHolmes
added a commit
that referenced
this pull request
Jan 8, 2024
syan095
added a commit
that referenced
this pull request
Jan 8, 2024
…-timeout * origin/main: fix: cargo fmt (#4392) Chore/pick 1.1 fixes (#4390) refactor: code cleaniness (#4389) feat: track deposit witnesses and egress confirmations [WEB-715] (#4370) fix: ensure api lib version is bumped (#4387) chore: add reason to DepositIgnored event (#4385) chore: warn on attempt 0 in retrier (#4383) chore: log_or_panic prepends its name (#4384) chore: fix log message formatting (#4380) feat: order_fills rpc (PRO-1044) (#4376) # Conflicts: # state-chain/pallets/cf-broadcast/src/lib.rs
martin-chainflip
pushed a commit
that referenced
this pull request
Jan 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.