Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: pool_orders rpc filters empty orders (PRO-1039) #4377

Merged
merged 5 commits into from
Jan 16, 2024

Conversation

AlastairHolmes
Copy link
Contributor

No description provided.

@AlastairHolmes AlastairHolmes requested a review from kylezs January 2, 2024 14:36
Copy link

codecov bot commented Jan 2, 2024

Codecov Report

Attention: 20 lines in your changes are missing coverage. Please review.

Comparison is base (6cd2ec5) 72% compared to head (9f1b6a0) 72%.
Report is 4 commits behind head on main.

Files Patch % Lines
utilities/src/without_std/conditional.rs 62% 15 Missing ⚠️
engine/src/retrier.rs 88% 2 Missing ⚠️
engine/src/eth/retry_rpc.rs 0% 1 Missing ⚠️
state-chain/pallets/cf-pools/src/lib.rs 98% 1 Missing ⚠️
state-chain/runtime/src/lib.rs 0% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@          Coverage Diff           @@
##            main   #4377    +/-   ##
======================================
- Coverage     72%     72%    -0%     
======================================
  Files        395     396     +1     
  Lines      67553   67404   -149     
  Branches   67553   67404   -149     
======================================
- Hits       48784   48552   -232     
- Misses     16321   16406    +85     
+ Partials    2448    2446     -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@AlastairHolmes AlastairHolmes marked this pull request as draft January 3, 2024 09:25
@AlastairHolmes AlastairHolmes force-pushed the fix/pool-orders-filter-empty-orders branch from 96251b6 to a919af6 Compare January 4, 2024 16:02
@AlastairHolmes AlastairHolmes marked this pull request as ready for review January 4, 2024 16:04
@RGafiyatullin RGafiyatullin self-requested a review January 9, 2024 17:56
@AlastairHolmes AlastairHolmes force-pushed the fix/pool-orders-filter-empty-orders branch from e26e9aa to 9f1b6a0 Compare January 15, 2024 11:07
@AlastairHolmes AlastairHolmes merged commit 0b3d98d into main Jan 16, 2024
43 checks passed
@AlastairHolmes AlastairHolmes deleted the fix/pool-orders-filter-empty-orders branch January 16, 2024 09:21
syan095 added a commit that referenced this pull request Jan 19, 2024
…itness-swap

* origin/main: (24 commits)
  fix: restore correct restriction on redemption expiry (PRO-1072)
  Feat/migrate-to-polkadot-sdk-repo (#4361)
  chore: fix RUSTSEC-2024-0003 (#4426)
  Feat: decouple CFE from SC events (#4382)
  chore: add docker tag prefix to `chainflip-ingress-egress-tacker` 🏷️ (#4427)
  refactor/PRO-1101: rid of swapping minimum swap amount (#4419)
  refactor(ingress-egress-tracker): remove unnecessary fields (#4425)
  Improved the retry queue storage (#4420)
  fix: bump spec version command only bumps when necessary (#4422)
  refactor: use yargs for all try_runtime_command options (#4423)
  fix: await finalisation before starting broker (#4412)
  chore: debug logs to see get_raw_txs query (#4413)
  doc: correct env vars (#4416)
  fix: pool_orders rpc filters empty orders (PRO-1039) (#4377)
  Produce an event in case the swap yields a zero egress amount (#4410)
  fix: don't have conflicting redis port with localnet (#4415)
  Ability to specify output for the subcommands, other than `/dev/null` (#4411)
  chore: increase limit on max number of bitcoin payloads in a ceremony to theoretical maximum (#4396)
  refactor(ingress-egress-tracker): configurable expiry times [WEB-761] (#4406)
  fix: use existing script for upgrade job (#4403)
  ...

# Conflicts:
#	Cargo.lock
#	state-chain/primitives/Cargo.toml
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants