Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: bump spec version command only bumps when necessary #4422

Merged
merged 5 commits into from
Jan 17, 2024

Conversation

kylezs
Copy link
Contributor

@kylezs kylezs commented Jan 16, 2024

Pull Request

Closes: PRO-1031

Checklist

Please conduct a thorough self-review before opening the PR.

  • I am confident that the code works.
  • I have updated documentation where appropriate.

Summary

Improves readability and functionality of this util.

@kylezs kylezs marked this pull request as ready for review January 16, 2024 13:02
Copy link

codecov bot commented Jan 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (7e2290f) 72% compared to head (9bb85e9) 72%.

Additional details and impacted files
@@          Coverage Diff          @@
##            main   #4422   +/-   ##
=====================================
  Coverage     72%     72%           
=====================================
  Files        396     396           
  Lines      67426   67426           
  Branches   67426   67426           
=====================================
+ Hits       48578   48580    +2     
+ Misses     16402   16401    -1     
+ Partials    2446    2445    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kylezs kylezs merged commit a2bf65c into main Jan 17, 2024
43 checks passed
@kylezs kylezs deleted the fix/upgrade-network-bump-spec-version branch January 17, 2024 09:53
syan095 added a commit that referenced this pull request Jan 19, 2024
…itness-swap

* origin/main: (24 commits)
  fix: restore correct restriction on redemption expiry (PRO-1072)
  Feat/migrate-to-polkadot-sdk-repo (#4361)
  chore: fix RUSTSEC-2024-0003 (#4426)
  Feat: decouple CFE from SC events (#4382)
  chore: add docker tag prefix to `chainflip-ingress-egress-tacker` 🏷️ (#4427)
  refactor/PRO-1101: rid of swapping minimum swap amount (#4419)
  refactor(ingress-egress-tracker): remove unnecessary fields (#4425)
  Improved the retry queue storage (#4420)
  fix: bump spec version command only bumps when necessary (#4422)
  refactor: use yargs for all try_runtime_command options (#4423)
  fix: await finalisation before starting broker (#4412)
  chore: debug logs to see get_raw_txs query (#4413)
  doc: correct env vars (#4416)
  fix: pool_orders rpc filters empty orders (PRO-1039) (#4377)
  Produce an event in case the swap yields a zero egress amount (#4410)
  fix: don't have conflicting redis port with localnet (#4415)
  Ability to specify output for the subcommands, other than `/dev/null` (#4411)
  chore: increase limit on max number of bitcoin payloads in a ceremony to theoretical maximum (#4396)
  refactor(ingress-egress-tracker): configurable expiry times [WEB-761] (#4406)
  fix: use existing script for upgrade job (#4403)
  ...

# Conflicts:
#	Cargo.lock
#	state-chain/primitives/Cargo.toml
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants