Ability to specify output for the subcommands, other than /dev/null
#4411
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RGafiyatullin
requested review from
ahasna and
tomjohnburton
and removed request for
a team
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4411 +/- ##
======================================
- Coverage 72% 72% -0%
======================================
Files 395 395
Lines 67553 67402 -151
Branches 67553 67402 -151
======================================
- Hits 48784 48560 -224
- Misses 16321 16393 +72
- Partials 2448 2449 +1 ☔ View full report in Codecov by Sentry. |
ahasna
approved these changes
Jan 12, 2024
RGafiyatullin
deleted the
fix/localnet-manage-sh-output-to-dev-null-isnt-always-an-optimal-choice
branch
syan095
added a commit
that referenced
this pull request
Jan 19, 2024
…itness-swap * origin/main: (24 commits) fix: restore correct restriction on redemption expiry (PRO-1072) Feat/migrate-to-polkadot-sdk-repo (#4361) chore: fix RUSTSEC-2024-0003 (#4426) Feat: decouple CFE from SC events (#4382) chore: add docker tag prefix to `chainflip-ingress-egress-tacker` 🏷️ (#4427) refactor/PRO-1101: rid of swapping minimum swap amount (#4419) refactor(ingress-egress-tracker): remove unnecessary fields (#4425) Improved the retry queue storage (#4420) fix: bump spec version command only bumps when necessary (#4422) refactor: use yargs for all try_runtime_command options (#4423) fix: await finalisation before starting broker (#4412) chore: debug logs to see get_raw_txs query (#4413) doc: correct env vars (#4416) fix: pool_orders rpc filters empty orders (PRO-1039) (#4377) Produce an event in case the swap yields a zero egress amount (#4410) fix: don't have conflicting redis port with localnet (#4415) Ability to specify output for the subcommands, other than `/dev/null` (#4411) chore: increase limit on max number of bitcoin payloads in a ceremony to theoretical maximum (#4396) refactor(ingress-egress-tracker): configurable expiry times [WEB-761] (#4406) fix: use existing script for upgrade job (#4403) ... # Conflicts: # Cargo.lock # state-chain/primitives/Cargo.toml
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
This PR has no Linear ticket associated with it.
Checklist
Please conduct a thorough self-review before opening the PR.
Summary
When the docker is not launched, or some auth-token is stale, or something else prevents the script from normal execution, it can be fruitful to have a possibility to hear out the underlying commands' complaints: