Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Remove DepositTracker from the IngressEgress pallet #5120

Merged
merged 10 commits into from
Aug 20, 2024

Conversation

syan095
Copy link
Contributor

@syan095 syan095 commented Aug 6, 2024

Pull Request

Closes: PRO-1485

Checklist

Please conduct a thorough self-review before opening the PR.

  • I am confident that the code works.
  • I have updated documentation where appropriate.

Summary

Removed the redundant Deposit Tracker from the ingress-egress pallet.

@syan095 syan095 requested a review from dandanlen as a code owner August 6, 2024 01:12
Copy link

codecov bot commented Aug 6, 2024

Codecov Report

Attention: Patch coverage is 91.42857% with 3 lines in your changes missing coverage. Please review.

Project coverage is 71%. Comparing base (8861c0c) to head (d21bba4).
Report is 2 commits behind head on main.

Files Patch % Lines
...ss-egress/src/migrations/remove_deposit_tracker.rs 89% 3 Missing ⚠️
Additional details and impacted files
@@          Coverage Diff           @@
##            main   #5120    +/-   ##
======================================
- Coverage     71%     71%    -0%     
======================================
  Files        456     457     +1     
  Lines      82112   81860   -252     
  Branches   82112   81860   -252     
======================================
- Hits       58180   57863   -317     
- Misses     20866   20930    +64     
- Partials    3066    3067     +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@dandanlen dandanlen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM apart from the missing migration.

state-chain/pallets/cf-ingress-egress/src/lib.rs Outdated Show resolved Hide resolved
…tracker

* origin/main:
  Fix: Add missing Arbitrum block_height (#5126)
  chore: update PR template with testing and migration note (#5122)
  feat: Solana chain integration (#4849)

# Conflicts:
#	state-chain/pallets/cf-ingress-egress/src/lib.rs
@dandanlen
Copy link
Collaborator

Not sure what's up with CI, will take a look next week.

…tracker

* origin/main:
  Rename PrimaryOrBackup (#5139)
  feat: Governance extrinsic to recover Solana Durable Nonces (#5130)
  fix: pallet versions should match release + bump old dylib version to 1.5.1 (#5142)

# Conflicts:
#	state-chain/pallets/cf-ingress-egress/src/migrations.rs
@syan095
Copy link
Contributor Author

syan095 commented Aug 13, 2024

Merged from main - fixed CI problem.
Also added a comment to the 11->12 migration as it is a "placeholder" for a migration written in the Release branch only.

@syan095 syan095 enabled auto-merge August 13, 2024 23:02
@kylezs
Copy link
Contributor

kylezs commented Aug 15, 2024

Just resolved the conflicts with #5105 , should be ready to go @dandanlen

@dandanlen
Copy link
Collaborator

@syan095 can you look into what is going wrong with this?

@kylezs
Copy link
Contributor

kylezs commented Aug 19, 2024

I think it just needs a rebase, didn't get round to it - there were some solana tests using external RPCs (which I think broke overnight), I have since disabled those tests on main, so a rebase/merge with main should help 🤞

@kylezs kylezs force-pushed the chore/remove-deposit-tracker branch from b658108 to d21bba4 Compare August 20, 2024 06:52
@syan095 syan095 added this pull request to the merge queue Aug 20, 2024
Merged via the queue into main with commit a32668b Aug 20, 2024
48 checks passed
@syan095 syan095 deleted the chore/remove-deposit-tracker branch August 20, 2024 08:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants