-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Remove DepositTracker from the IngressEgress pallet #5120
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5120 +/- ##
======================================
- Coverage 71% 71% -0%
======================================
Files 456 457 +1
Lines 82112 81860 -252
Branches 82112 81860 -252
======================================
- Hits 58180 57863 -317
- Misses 20866 20930 +64
- Partials 3066 3067 +1 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM apart from the missing migration.
Not sure what's up with CI, will take a look next week. |
Merged from main - fixed CI problem. |
Just resolved the conflicts with #5105 , should be ready to go @dandanlen |
…tracker * origin/main: fix: expose solana ws rpc endpoint 🐛☀️ (#5162)
@syan095 can you look into what is going wrong with this? |
I think it just needs a rebase, didn't get round to it - there were some solana tests using external RPCs (which I think broke overnight), I have since disabled those tests on main, so a rebase/merge with main should help 🤞 |
b658108
to
d21bba4
Compare
Pull Request
Closes: PRO-1485
Checklist
Please conduct a thorough self-review before opening the PR.
Summary
Removed the redundant Deposit Tracker from the ingress-egress pallet.