PRO-1620: Ensure that default port is used if none is given in configuration

[MxmUrw]

Pull Request

Closes: PRO-1620

Checklist

Please conduct a thorough self-review before opening the PR.

• I am confident that the code works.
• I have written sufficient tests.
• I have written and tested required migrations.
• I have updated documentation where appropriate.

Summary

Currently the polkadot http rpc client uses jsonrpsee's HttpClient. Unfortunately, since we are on version 0.16 of jsonrpsee, this client has the rule that a port must always be given, even if it should be the default port. Later versions of jsonrpsee forgo this requirement.

To make sure that the user configures a valid http endpoint for polkadot, we currently check that the url contains a port. Unfortunately the checking logic uses a regex and accepts urls such as https://endpoint/path:port as valid, even though it shouldn't.

It also seems that the Solana configuration logic mistakenly was copied from Polkadot since it calls the same validation logic, without there being a need for that.

This PR does multiple things:

• Instead of requiring the user to always give a port for polkadot endpoints, we automatically insert the default port in case none was given.
• Remove tests which check that polkadot endpoints always contain ports.
• Remove the port validation logic for solana.

Non-Breaking changes

If this PR includes non-breaking changes, select the non-breaking label. On merge, CI will automatically cherry-pick the commit to a PR against the release branch.

[codecov]

Codecov Report

Attention: Patch coverage is 84.31373% with 8 lines in your changes missing coverage. Please review.

Project coverage is 70%. Comparing base (68ab19b) to head (c4d37bb).
Report is 13 commits behind head on main.

Files with missing lines	Patch %	Lines
engine/src/dot/http_rpc.rs	84%	3 Missing and 5 partials ⚠️

Additional details and impacted files

@@          Coverage Diff           @@
##            main   #5281    +/-   ##
======================================
  Coverage     70%     70%            
======================================
  Files        487     487            
  Lines      86802   87138   +336     
  Branches   86802   87138   +336     
======================================
+ Hits       60807   61118   +311     
- Misses     22662   22740    +78     
+ Partials    3333    3280    -53     

Flag	Coverage Δ
	70% <84%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.