PRO-1594: Add healthcheck endpoints to broker and lp apis #5282
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5282 +/- ##
======================================
Coverage 70% 70%
======================================
Files 486 487 +1
Lines 87138 87308 +170
Branches 87138 87308 +170
======================================
+ Hits 61170 61309 +139
- Misses 22687 22721 +34
+ Partials 3281 3278 -3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
MxmUrw
changed the title
health.rs as well for apis.
kylezs
reviewed
Sep 23, 2024
Mainly consolidating health options and validation into `health.rs`.
kylezs
reviewed
Sep 23, 2024
|
Yay, no more TCP healthcheck :) |
MxmUrw
deleted the
feat/PRO-1594/add-health-checkpoints-for-broker-and-lp-apis
branch
Yes! |
syan095
added a commit
that referenced
this pull request
Oct 2, 2024
…-sdk-1.15.2 * origin/main: (31 commits) feat: liveness electoral system (#5278) chore: bump asset-balances to match release (#5305) refactor: Strongly-typed identifiers for SwapId/SwapRequestId (#5294) fix: only install solana if `run-job` is true 🐛 (#5304) Chore/debug 3 nodes (#5302) feat: remove swap and retry batch on price impact (#5285) refactor: Collect settings extrinsic in threshold signer pallet into a single extrinsic (#5299) feat: add solana monitoring data (#5277) fix: Redemption amount printed not consistent in rounding (#5296) refactor: use chainflip api for DCA test (#5289) fix: add audit exception for RUSTSEC-2024-0375 (#5303) fix: filter out stale bitcoin utxos (#5291) PRO-1594: Add healthcheck endpoints to broker and lp apis (#5282) Tests elections pallet (#5190) PRO-1620: Ensure that default port is used if none is given in configuration (#5281) test: egress success tests (#5288) feat: localnet scripts to create and recreate easier (#5284) Denote broadcast timeout in target chain blocks. (#5270) fix: force version bump endpoint (#5280) refactor: user friendly bouncer new swap cmd (#5273) ... # Conflicts: # .zepter.yaml # Cargo.lock # api/bin/chainflip-cli/Cargo.toml # api/bin/chainflip-lp-api/src/main.rs # engine/Cargo.toml # state-chain/custom-rpc/Cargo.toml # state-chain/custom-rpc/src/lib.rs # state-chain/pallets/cf-swapping/src/lib.rs # state-chain/runtime/src/monitoring_apis.rs # utilities/Cargo.toml
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Closes: PRO-1594
Checklist
Please conduct a thorough self-review before opening the PR.
Summary
Currently, only the engine binary itself has a healthcheck endpoint. This PR adds the same functionality to the broker and lp api binaries. In particular, the
healthcheck.rsfile is moved into theutilitiescrate to allow all binaries to reuse it.Non-Breaking changes
If this PR includes non-breaking changes, select the
non-breakinglabel. On merge, CI will automatically cherry-pick the commit to a PR against the release branch.