Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: localnet scripts to create and recreate easier #5284

Merged
merged 2 commits into from
Sep 23, 2024

Conversation

j4m1ef0rd
Copy link
Contributor

Pull Request

Checklist

Please conduct a thorough self-review before opening the PR.

  • I am confident that the code works.
  • I have written sufficient tests.
  • I have written and tested required migrations.
  • I have updated documentation where appropriate.

Summary

  • Added a script to create a localnet using cmd line arguments instead of manually entering the settings.
  • Added a script that will recreate a localnet using the same settings as the existing one instead of having to go through the manage.sh script every time.
  • To get the recreate script to work, I save/load the settings to a file in the tmp directory.

Out of scope

I could spend days cleaning up the existing code and making it nicer, but I didn't want to spent more time on it, so for now i just made it functional.

@j4m1ef0rd j4m1ef0rd self-assigned this Sep 20, 2024
@j4m1ef0rd j4m1ef0rd requested a review from a team as a code owner September 20, 2024 03:15
@j4m1ef0rd j4m1ef0rd requested review from anton-chain and removed request for a team September 20, 2024 03:15
Copy link

codecov bot commented Sep 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70%. Comparing base (a17fd16) to head (674a6c5).
Report is 1 commits behind head on main.

Additional details and impacted files
@@          Coverage Diff           @@
##            main   #5284    +/-   ##
======================================
- Coverage     70%     70%    -0%     
======================================
  Files        487     487            
  Lines      87295   87151   -144     
  Branches   87295   87151   -144     
======================================
- Hits       61312   61107   -205     
- Misses     22703   22756    +53     
- Partials    3280    3288     +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@ahasna ahasna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@j4m1ef0rd j4m1ef0rd added this pull request to the merge queue Sep 23, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Sep 23, 2024
@j4m1ef0rd j4m1ef0rd added this pull request to the merge queue Sep 23, 2024
Merged via the queue into main with commit bf40a22 Sep 23, 2024
49 checks passed
@j4m1ef0rd j4m1ef0rd deleted the feat/localnet-script-improvments branch September 23, 2024 04:53
syan095 added a commit that referenced this pull request Oct 2, 2024
…-sdk-1.15.2

* origin/main: (31 commits)
  feat: liveness electoral system (#5278)
  chore: bump asset-balances to match release (#5305)
  refactor: Strongly-typed identifiers for SwapId/SwapRequestId (#5294)
  fix: only install solana if `run-job` is true 🐛 (#5304)
  Chore/debug 3 nodes (#5302)
  feat: remove swap and retry batch on price impact (#5285)
  refactor: Collect settings extrinsic in threshold signer pallet into a single extrinsic (#5299)
  feat: add solana monitoring data (#5277)
  fix: Redemption amount printed not consistent in rounding (#5296)
  refactor: use chainflip api for DCA test (#5289)
  fix: add audit exception for RUSTSEC-2024-0375 (#5303)
  fix: filter out stale bitcoin utxos (#5291)
  PRO-1594: Add healthcheck endpoints to broker and lp apis (#5282)
  Tests elections pallet (#5190)
  PRO-1620: Ensure that default port is used if none is given in configuration (#5281)
  test: egress success tests (#5288)
  feat: localnet scripts to create and recreate easier (#5284)
  Denote broadcast timeout in target chain blocks. (#5270)
  fix: force version bump endpoint (#5280)
  refactor: user friendly bouncer new swap cmd  (#5273)
  ...

# Conflicts:
#	.zepter.yaml
#	Cargo.lock
#	api/bin/chainflip-cli/Cargo.toml
#	api/bin/chainflip-lp-api/src/main.rs
#	engine/Cargo.toml
#	state-chain/custom-rpc/Cargo.toml
#	state-chain/custom-rpc/src/lib.rs
#	state-chain/pallets/cf-swapping/src/lib.rs
#	state-chain/runtime/src/monitoring_apis.rs
#	utilities/Cargo.toml
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants