Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jenkins Style Checks (EOL Check, Tab Check, Copyright Check) running under task for incorrect branch #2877

Closed
dilijev opened this issue Apr 26, 2017 · 0 comments

Comments

@dilijev
Copy link
Contributor

dilijev commented Apr 26, 2017

See checks that ran for #2826, in particular: https://ci.dot.net/job/Microsoft_ChakraCore/job/release_1.3/job/ubuntu_check_eol_prtest/1835/console

All of that tasks that ran should have had release_1.4 in their URL, but the Style Check tasks were release_1.3.

  • Verify that the style check tasks are correctly generated for release_1.4
  • Track down why the wrong tasks were triggered

Not sure if this has caused any problems because these tasks are all the same and the diff (for files affected by the change) is taken by comparing against master (in the future this behavior will be changed to diff against the target branch (#962)), but I would be suspicious about whether whatever the problem is could cause problems in the future or affect more complex non-style checks.

@dilijev dilijev added this to the Backlog milestone Apr 26, 2017
@dilijev dilijev added Test Bug and removed Bug labels Apr 26, 2017
chakrabot pushed a commit that referenced this issue May 1, 2017
Merge pull request #2887 from MSLaguana:fixCIPRTriggers

Prior to this change, we were building some configurations for all branches when a PR came in.
This is just backporting the netci.groovy script from `release/1.4` to be more consistent.

Fixes #2877
chakrabot pushed a commit that referenced this issue May 1, 2017
Merge pull request #2887 from MSLaguana:fixCIPRTriggers

Prior to this change, we were building some configurations for all branches when a PR came in.
This is just backporting the netci.groovy script from `release/1.4` to be more consistent.

Fixes #2877
chakrabot pushed a commit that referenced this issue May 1, 2017
…ript

Merge pull request #2887 from MSLaguana:fixCIPRTriggers

Prior to this change, we were building some configurations for all branches when a PR came in.
This is just backporting the netci.groovy script from `release/1.4` to be more consistent.

Fixes #2877
chakrabot pushed a commit that referenced this issue May 1, 2017
…pdating CI script

Merge pull request #2887 from MSLaguana:fixCIPRTriggers

Prior to this change, we were building some configurations for all branches when a PR came in.
This is just backporting the netci.groovy script from `release/1.4` to be more consistent.

Fixes #2877
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants