Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updating CI script #2887

Merged
merged 1 commit into from
May 1, 2017
Merged

Updating CI script #2887

merged 1 commit into from
May 1, 2017

Conversation

MSLaguana
Copy link
Contributor

@MSLaguana MSLaguana commented Apr 28, 2017 •
edited
Loading

Prior to this change, we were building some configurations for all branches when a PR came in.
This is just backporting the netci.groovy script from release/1.4 to be more consistent.

Fixes #2877

@MSLaguana
Updating CI script
11642d6 
Prior to this change, we were building some configurations for all branches when a PR came in.
@MSLaguana MSLaguana requested a review from dilijev April 28, 2017 22:30
@msftclas
Copy link

@MSLaguana,
Thanks for your contribution as a Microsoft full-time employee or intern. You do not need to sign a CLA.
Thanks,
Microsoft Pull Request Bot

@MSLaguana
Copy link
Contributor Author

@dotnet-bot test ci please

@dilijev dilijev mentioned this pull request Apr 28, 2017
Closed
dilijev
dilijev approved these changes Apr 28, 2017
View reviewed changes
Copy link
Contributor

@dilijev dilijev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assuming this is a direct port of the version in release/1.4, LGTM.

Did you check to ensure that this won't generate any tasks to run on release/1.2 that are not compatible (like xplat tasks)?

@chakrabot chakrabot merged commit 11642d6 into chakra-core:release/1.2 May 1, 2017
chakrabot pushed a commit that referenced this pull request May 1, 2017
@MSLaguana
[MERGE #2887 @MSLaguana] Updating CI script
00c44f3 
Merge pull request #2887 from MSLaguana:fixCIPRTriggers

Prior to this change, we were building some configurations for all branches when a PR came in.
This is just backporting the netci.groovy script from `release/1.4` to be more consistent.

Fixes #2877
chakrabot pushed a commit that referenced this pull request May 1, 2017
@MSLaguana
[1.2>1.3] [MERGE #2887 @MSLaguana] Updating CI script
e0f8e5d 
Merge pull request #2887 from MSLaguana:fixCIPRTriggers

Prior to this change, we were building some configurations for all branches when a PR came in.
This is just backporting the netci.groovy script from `release/1.4` to be more consistent.

Fixes #2877
chakrabot pushed a commit that referenced this pull request May 1, 2017
@MSLaguana
[1.3>1.4] [1.2>1.3] [MERGE #2887 @MSLaguana] Updating CI script
6267a5a 
Merge pull request #2887 from MSLaguana:fixCIPRTriggers

Prior to this change, we were building some configurations for all branches when a PR came in.
This is just backporting the netci.groovy script from `release/1.4` to be more consistent.

Fixes #2877
chakrabot pushed a commit that referenced this pull request May 1, 2017
@MSLaguana
[1.4>2.0] [1.3>1.4] [1.2>1.3] [MERGE #2887 @MSLaguana] Updating CI sc…
b90206c 
…ript

Merge pull request #2887 from MSLaguana:fixCIPRTriggers

Prior to this change, we were building some configurations for all branches when a PR came in.
This is just backporting the netci.groovy script from `release/1.4` to be more consistent.

Fixes #2877
chakrabot pushed a commit that referenced this pull request May 1, 2017
@MSLaguana
[2.0>master] [1.4>2.0] [1.3>1.4] [1.2>1.3] [MERGE #2887 @MSLaguana] U…
4aa0daf 
…pdating CI script

Merge pull request #2887 from MSLaguana:fixCIPRTriggers

Prior to this change, we were building some configurations for all branches when a PR came in.
This is just backporting the netci.groovy script from `release/1.4` to be more consistent.

Fixes #2877
@dilijev
Copy link
Contributor

dilijev commented May 1, 2017

@MSLaguana look at that propagation :P

@MSLaguana MSLaguana deleted the fixCIPRTriggers branch May 1, 2017 21:06
@dilijev dilijev mentioned this pull request May 5, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dilijev dilijev dilijev approved these changes

Assignees
No one assigned
Labels
Continuous Integration
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@MSLaguana @msftclas @dilijev @chakrabot