Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version 2.7.2 #5145

Merged
merged 56 commits into from
Mar 1, 2018
Merged

Version 2.7.2 #5145

merged 56 commits into from
Mar 1, 2018

Conversation

simonbrunel
Copy link
Member

@simonbrunel simonbrunel commented Jan 13, 2018

Milestone: 2.7.2
Merged PRs: 55

Please help in testing this upcoming release!

Checklist:

See the release process for details.

benmccann and others added 30 commits November 1, 2017 16:00
Prevent duplicate version of moment.js (which is pretty large) when an app also depends on moment (with less strict semver range)
Removed trailing space from waterfall-plugin.
* In tooltip x align calculation take into account caretSize

Truncation up to caretSize pixels could happen if label text produced tooltip element with size width:
* left side tooltip: width < x and width > x - caretSize
* right side tooltip: width < chartWidth - x and width > chartWidth - x - caretSize
Default caretSize = 5, so with default configuration truncation up to 5 pixels could happen.

* avoid tooltip truncation if possible
use whole chart area for displaying tooltip

* in xAlign calculation take into account caretPadding

* add tests for tooltip truncation avoid logic

* use caretX instead of xCaret

* fix lint errors
Only the dataset index was used for indexing the stack
Linear scale getPixelForValue() method doesn't round the returned value anymore.
* add check on overwriting canvas height/width

* unit test for this
…nitial fitting. (#4942)

* Fix issue 4441:
 - y-axis labels partially hidden due to restrictive initial fitting.

* Add regression test to linear scale

* Moved regression test from linear scale to core layout service
- allow options to be updated in-place or as a new object
- re-merge new options and rebuild scales & tooltips
- preserve reference to old scale if id/type not changed
- related tests and new sample also added.
- update document about options update
- update doc and example
When `barThickness: undefined|null` (default), we compute an optimal sample size based on the smallest tick interval reduced to prevent any bar to overlap (bar equally sized). Also added support for a special `barThickness: 'flex'` value (previous default) that globally arranges bars side by side to prevent any gap when percentage options are 1 (variable bar sizes).
… precision. (#4943)

* Fix issue 4928
 - linear tick generator doesn't round values to needed precision.

* Improve: replace toPrecision() in toString() to improve readability.

* Fix: logarithmic tick generator doesn't round values to needed precision.

* Fix: rounding tick values didn't work for negative values.

* Add: Core ticks tests
* Fix issue #4989
 - tooltip in 'index' mode doesn't animate smoothly.

* Change: different approach for smooth tooltip animation in 'index'
        mode, when target doesn't change.

* Fix: jslint error

* Fix: remove spyOn pivot from test

* Add: setAnimating-flag in transition used to set on tooltip.transition
     to keep track of tooltip animation.

* Decrease code complexity

* Revert transition and complexity changes
Add: use 'tooltip._start' as workaround check for tooltip animation status
- issue #4572: logarithmic type if all numbers are zero browser crashes "Out of memory"
 - issue #4703: [BUG] Browser unresponsive on bubble chart with logarithmic axes
- infinite loop in generating time axis, due to insufficient bounds checking.
I didn't realize you had to call generateLegend() manually and a quick search tells me that lots of other people have run into this too.
An ESLint shareable config has been created (from this repository) in the attempt to homogenize Chart.js hosted projects and plugins style. Rename `.eslintrc` files to `.eslintrc.yml` since the name has been deprecated.

Fix the CC badge (maintainability) and disable CodeClimate ESLint plugin because it doesn't support custom shareable config but also because it already executes relevant checks as part of the regular process.
Cached plugin descriptors hold a reference on the plugin options, which break if the plugin options object is replaced. That case happens when the user updates the plugin options with a new object, but also since the new config update logic (#4198) that now always clones the plugin options. The fix consists in explicitly invalidating that cache before updating the chart.
benmccann and others added 8 commits January 13, 2018 10:39
* Log errors and skip for buildTask

* Write gulp error to Chart.js
+ Add intentional error to core to check if travis fails

* Remove unused require

* Remove error + Proper require fs

* Fix newline

* Refactor

* Put back browser errors

* Use options

* Fix intentional error

* Use yargs + Refactor

* remove space

* Fefactor

* Use booleans
@benmccann
Copy link
Contributor

benmccann commented Jan 22, 2018

@simonbrunel I've drafted the release notes

jonquach and others added 3 commits January 27, 2018 15:47
Setup a new Heroku app based on rauchg/slackin, using Slack legacy token from the Chart.js (chartjs.slack@...) user and reCAPTCHA from the same Google account.
@fanthos
Copy link
Contributor

fanthos commented Feb 1, 2018

Thanks for the great chart library.
Is there ETA for 2.7.2 release?

stockiNail and others added 8 commits February 2, 2018 10:17
* Support multiple font colors in array

* Address linting error
Address the ambiguity of "Selecting the Correct Build" section
…10 (#5275)

* Bugfix: Improve polyfill function of log10 to return whole powers of 10
        as integer values, as it caused endless loop in IE11 in the tick
        creation loop.

* Compare floating-point numbers directly instead of using unnecessary division.
@simonbrunel simonbrunel added this to the Version 2.7.2 milestone Mar 1, 2018
@simonbrunel simonbrunel merged commit 1a5dca8 into release Mar 1, 2018
exwm pushed a commit to exwm/Chart.js that referenced this pull request Apr 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.