pull code #84
Merged
pull code #84
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* update * update * update * update * update log message in bug-report template Co-authored-by: Lijiao <15910218274@163.com>
Add shell support for ssh connection, so that remote script can be started with user environment. Minor fixes, 1. Fix gpu_metrics_collector to support pyenv. As pyenv will create one more process, so that original pgrep code always got extra processes, and cannot start gpu_metrics_collector. 2. Fix NASUI failure on dev-install-node-modules, to create subfolder every time. 3. Fix MakeFile to reduce mis-created links, and other minor issues. 4. Add node --watch for nni_manager for better dev experience.
To support Windows node in remote mode, this PR adds a layer of commands (osCommands) to deal difference between Windows and Unix-like OS. To share code, ShellExecutor is added to enrich original SshClient class. I will implement windows version commands in next phase. This pattern can be expanded to Local or other platform in future, so I moved related code to common folder for sharing.
* Update README.md * Update README.md * Update README.md Co-authored-by: Scarlett Li <39592018+scarlett2018@users.noreply.github.com>
update nni manager eslint rules. 1. add rule to ignore unused args, and treat other unused as error. 2. add run to treat no explicit function return type as error. 3. fix all errors.
As requirement of #2390 , removed multiphase from WebUI, document, and put all trials flatten on WebUI. 1. The major change is to split trial-jobs to trials in webui, and use parameter id as part of trial id. 2. If multiphase is enabled, the limitation of trial controls job count only, not trials actually. 3. When multiphase enabled, the trial status may not be right. Previous trials in a job will be marked as success, only last trial presents the job's status. 4. multiphase related documents and UX are removed. minor changes, 1. Update dev document for webui development.
Co-authored-by: Lijiao <15910218274@163.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.