-
Notifications
You must be signed in to change notification settings - Fork 182
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(#996) (ENGTASKS-3631) Switch to Astro #997
Conversation
This is draft due to a few things:
|
A reason why this might be stuck in "Expected - Waiting for status to be reported" on the checks: https://github.com/orgs/community/discussions/26698#discussioncomment-3252954 |
8ddb27a
to
14b6df1
Compare
16d094a
to
7ce7265
Compare
5877aab
to
a904a29
Compare
9293de7
to
2b37ec2
Compare
1194969
to
31e6043
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have just taken this for a spin, and it looks really good!
I haven't done a side-by-side comparison of each page of the docs, but I have done a couple, and the expected changes to use new way of doing xrefs, callouts, etc. all seem to be in place. I have no reason to think that the other pages won't have the same changes, so I wasn't planning on comparing each page that we have, as there are quite a few 😄
I did notice a small issue where the iframes for videos are not showing up for me, for example on this page:
/en-us/chocolatey-gui/setup/configuration/features/show-console-output
This could be a me problem, so would be good to chat about this when you are online today.
0e9e1d8
to
5913984
Compare
In order to install Astro, we need to remove everything from the folder and basically "start from scratch". This allowed Astro to create a new project with the recommended file structure.
This is the baseline Astro project that was created by running the recommended commands by Astro. A few files may have been altered here, like the .gitignore.
@gep13 I've made the changes suggested and rebased on master, I think this is ready for another look! |
098f0f3
to
d2fc132
Compare
This converts all of the previous files that were being generated by Statiq into Astro framework. Now, all documentation is written in .mdx files which are located in the `src/content` folders. The README.md has been updated to reflect all of these changes and new processes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
The Terms page has been updated to use the correct Astro Components to render all the content needed. This was missed on the initial switchover to Astro.
The changes to the production build configuration ensure that all urls only contain a slash if they have other pages nested inside of them.
(#997) Update Terms Page to Use Astro
The change here ensures the left side navigation always highlights the active page. This also makes sure that an expanded navigation item does not collapse on reload. The trailing slash, or lack of, has been accounted for now.
The change here ensures the left side navigation always highlights the active page. This also makes sure that an expanded navigation item does not collapse on reload. The trailing slash, or lack of, has been accounted for now.
The change here ensures the left side navigation always highlights the active page. This also makes sure that an expanded navigation item does not collapse on reload. The trailing slash, or lack of, has been accounted for now.
(#997) Astro CSS Fixups to Components
Description Of Changes
This converts all of the previous files that were
being generated by Statiq into Astro framework.
Now, all documentation is written in .mdx files
which are located in the
src/content
folders.The README.md has been updated to reflect all of
these changes and new processes.
Motivation and Context
A move to the Astro framework will:
Testing
There are multiple options to build the site:
Build the Site On Your Computer
Ensure that you have Node v20+ installed by running
node -v
. There is a.\setup.ps1
file in the root of this repository that uses Chocolatey to install or upgrade Node to the correct version.After confirming the required Node version, run the following command:
This will compile the site, and bring up a preview on
http:localhost:5086
. Any changes you make will automatically be hot reloaded.Build the Site Using a Docker Container
There are two ways to build the site using Docker:
Using the Visual Studio Code Dev Containers Extension
Connect to the Docker Container in Visual Studio Code. This will launch Visual Studio Code and open a terminal that is running inside the Docker Container whose configuration is defined in
/.devcontainer/devcontainer.json
and/.devcontainer/Dockerfile
.After the Docker Container has finished setup, move to a terminal and run the following:
This will compile the site, and bring up a preview on
http:localhost:5086
. Any changes you make will automatically be hot reloaded.Running the Docker Container From the Command Line
From the terminal, run the following:
Once this is complete, run the following from the same terminal:
This will compile the site, and bring up a preview on
http:localhost:5086
. Any changes you make will automatically be hot reloaded.Change Types Made
Change Checklist
Related Issue