Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: move sidetray to typescript #244

Conversation

NicolasBiehler
Copy link
Contributor

Fixes #197

src/components/SideTray/SideTray.tsx Outdated Show resolved Hide resolved
src/components/SideTray/SideTray.tsx Outdated Show resolved Hide resolved
src/components/SideTray/SideTray.tsx Outdated Show resolved Hide resolved
src/components/SideTray/SideTray.tsx Outdated Show resolved Hide resolved
@NicolasBiehler NicolasBiehler force-pushed the refactor/move-sidetray-to-typescript branch 2 times, most recently from 22f07b9 to 63614b5 Compare July 28, 2020 08:59
src/components/SideTray/SideTray.tsx Outdated Show resolved Hide resolved
src/components/SideTray/SideTray.tsx Outdated Show resolved Hide resolved
Copy link
Contributor

@mdespuits mdespuits left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only one small suggestion for improvement around the direction property type, but other than that...

🌹 🍔

@NicolasBiehler NicolasBiehler force-pushed the refactor/move-sidetray-to-typescript branch from fc82b9f to cc34676 Compare August 12, 2020 13:14
@NicolasBiehler NicolasBiehler merged commit fa0eb75 into cision:master Aug 12, 2020
This was referenced Aug 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Convert SideTray to TypeScript
5 participants