fix(nextjs): Support req.clerkUrl to fix issue with NextJS hostname on proxied apps #1394
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: f22c533 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
dimkl
force-pushed
the
js-483-nextjs-hostname
branch
from
b0c275a
to
e416d36
Compare
![jit-ci[bot]](https://avatars.githubusercontent.com/in/142441?s=60&v=4){kind=small}
dimkl
force-pushed
the
js-483-nextjs-hostname
branch
from
e416d36
to
4e42478
Compare
|
!snapshot |
|
Hey @dimkl - the snapshot version command generated the following package versions:
Tip: use the snippet copy button below to quickly install the required packages. # @clerk/backend
npm i @clerk/backend@0.23.5-snapshot.4e42478# @clerk/chrome-extension
npm i @clerk/chrome-extension@0.3.15-snapshot.4e42478# @clerk/clerk-js
npm i @clerk/clerk-js@4.50.0-snapshot.4e42478# eslint-config-custom
npm i eslint-config-custom@0.3.0# @clerk/clerk-expo
npm i @clerk/clerk-expo@0.18.6-snapshot.4e42478# @clerk/fastify
npm i @clerk/fastify@0.5.4-snapshot.4e42478# gatsby-plugin-clerk
npm i gatsby-plugin-clerk@4.3.16-snapshot.4e42478# @clerk/localizations
npm i @clerk/localizations@1.21.0-snapshot.4e42478# @clerk/nextjs
npm i @clerk/nextjs@4.21.8-snapshot.4e42478# @clerk/clerk-react
npm i @clerk/clerk-react@4.20.5-snapshot.4e42478# @clerk/remix
npm i @clerk/remix@2.6.13-snapshot.4e42478# @clerk/clerk-sdk-node
npm i @clerk/clerk-sdk-node@4.10.12-snapshot.4e42478# @clerk/shared
npm i @clerk/shared@0.19.1# @clerk/themes
npm i @clerk/themes@1.7.5# @clerk/types
npm i @clerk/types@3.46.0-snapshot.4e42478 |
dimkl
force-pushed
the
js-483-nextjs-hostname
branch
3 times, most recently
from
b8dfa08
to
047a629
Compare
|
!snapshot |
|
Hey @nikosdouvlis - the snapshot version command generated the following package versions:
Tip: use the snippet copy button below to quickly install the required packages. # @clerk/backend
npm i @clerk/backend@0.23.5# @clerk/chrome-extension
npm i @clerk/chrome-extension@0.3.15# @clerk/clerk-js
npm i @clerk/clerk-js@4.50.0# eslint-config-custom
npm i eslint-config-custom@0.3.0# @clerk/clerk-expo
npm i @clerk/clerk-expo@0.18.6# @clerk/fastify
npm i @clerk/fastify@0.5.4# gatsby-plugin-clerk
npm i gatsby-plugin-clerk@4.3.16# @clerk/localizations
npm i @clerk/localizations@1.21.0# @clerk/nextjs
npm i @clerk/nextjs@4.21.9-snapshot.56dc3e3# @clerk/clerk-react
npm i @clerk/clerk-react@4.20.5# @clerk/remix
npm i @clerk/remix@2.6.13# @clerk/clerk-sdk-node
npm i @clerk/clerk-sdk-node@4.10.12# @clerk/shared
npm i @clerk/shared@0.19.1# @clerk/themes
npm i @clerk/themes@1.7.5# @clerk/types
npm i @clerk/types@3.46.0 |
5 tasks
dimkl
changed the title
dimkl
force-pushed
the
js-483-nextjs-hostname
branch
from
56dc3e3
to
35a39c1
Compare
anagstef
approved these changes
Jun 21, 2023
Introduced environment variable: CLERK_USE_X_FWD_HEADERS Provide `"true"` value to enable this. related NextJS issue: vercel/next.js#37536
nikosdouvlis
force-pushed
the
js-483-nextjs-hostname
branch
from
72eb0f1
to
182f30d
Compare
Merged
dimkl
commented
Jun 23, 2023
| @@ -17,6 +17,7 @@ export const PROXY_URL = process.env.NEXT_PUBLIC_CLERK_PROXY_URL || ''; | |||
| export const IS_SATELLITE = process.env.NEXT_PUBLIC_CLERK_IS_SATELLITE === 'true' || false; | |||
| export const SIGN_IN_URL = process.env.NEXT_PUBLIC_CLERK_SIGN_IN_URL || ''; | |||
| export const SIGN_UP_URL = process.env.NEXT_PUBLIC_CLERK_SIGN_UP_URL || ''; | |||
| export const TRUST_HOST = (process.env.CLERK_TRUST_HOST || process.env.CLERK_USE_X_FWD_HEADERS) === 'true'; | |||
There was a problem hiding this comment.
I believe we should try to inform the customers that have used it and drop the CLERK_USE_X_FWD_HEADERS. Or somehow mark it as deprecated!
KevinEdry
reviewed
Jun 25, 2023
Merged
22 tasks
mikestopcontinues
pushed a commit
to mikestopcontinues/clerk-javascript
that referenced
this pull request
Jun 28, 2023
Issue: clerk#1413 PR introducing issue: clerk#1394
|
This PR has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Packages affected
@clerk/clerk-js@clerk/clerk-react@clerk/nextjs@clerk/remix@clerk/types@clerk/themes@clerk/localizations@clerk/clerk-expo@clerk/backend@clerk/clerk-sdk-node@clerk/shared@clerk/fastify@clerk/chrome-extensiongatsby-plugin-clerkbuild/tooling/choreDescription
npm testruns as expected.npm run buildruns as expected.Add the
req.clerkUrland populate it using the forwarded headers if theCLERK_TRUST_HOSTenvironment variable is set to"true".This fix should resolve the incorrect hostname in the NextJS applications deployed outside the Vercel platform.