fix(backend): Support NextJS 14 #1948
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: daaf845 The changes in this PR will be included in the next version bump. This PR includes changesets to release 6 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
nikosdouvlis
changed the title
|
!snapshot |
|
@desiprisg I have updated the description and changed the fix as per our offline discussion |
nikosdouvlis
approved these changes
Oct 26, 2023
tmilewski
approved these changes
Oct 26, 2023
|
!snapshot |
|
Hey @nikosdouvlis - the snapshot version command generated the following package versions:
Tip: Use the snippet copy button below to quickly install the required packages. npm i @clerk/backend@0.32.0-snapshot.v6f294e5 --save-exact
npm i @clerk/chrome-extension@0.4.11-snapshot.v6f294e5 --save-exact
npm i @clerk/clerk-js@4.64.0-snapshot.v6f294e5 --save-exact
npm i @clerk/clerk-expo@0.19.13-snapshot.v6f294e5 --save-exact
npm i @clerk/fastify@0.6.18-snapshot.v6f294e5 --save-exact
npm i gatsby-plugin-clerk@4.4.19-snapshot.v6f294e5 --save-exact
npm i @clerk/nextjs@4.25.8-snapshot.v6f294e5 --save-exact
npm i @clerk/remix@3.1.1-snapshot.v6f294e5 --save-exact
npm i @clerk/clerk-sdk-node@4.12.17-snapshot.v6f294e5 --save-exact |
Next14 seems to have changed the way it handles default exports when using the webpack bundler for some of their build variants when using `npm run dev`. This commit ensures that we no longer use the default export in an effort to improve compat between the different nextjs versions. More information can be found here: https://esbuild.github.io/content-types/#default-interop and here: #612
Merged
LekoArts
pushed a commit
that referenced
this pull request
Oct 26, 2023
* fix(backend): Fix for next 14 fetch bind issue * fix(nextjs): Use named imports for fetch runtime polyfill Next14 seems to have changed the way it handles default exports when using the webpack bundler for some of their build variants when using `npm run dev`. This commit ensures that we no longer use the default export in an effort to improve compat between the different nextjs versions. More information can be found here: https://esbuild.github.io/content-types/#default-interop and here: #612 * Create late-dolphins-peel.md --------- Co-authored-by: Nikos Douvlis <nikosdouvlis@gmail.com>
dimkl
pushed a commit
that referenced
this pull request
Oct 30, 2023
* fix(backend): Fix for next 14 fetch bind issue * fix(nextjs): Use named imports for fetch runtime polyfill Next14 seems to have changed the way it handles default exports when using the webpack bundler for some of their build variants when using `npm run dev`. This commit ensures that we no longer use the default export in an effort to improve compat between the different nextjs versions. More information can be found here: https://esbuild.github.io/content-types/#default-interop and here: #612 * Create late-dolphins-peel.md --------- Co-authored-by: Nikos Douvlis <nikosdouvlis@gmail.com>
24 tasks
dimkl
pushed a commit
that referenced
this pull request
Oct 30, 2023
* fix(backend): Fix for next 14 fetch bind issue * fix(nextjs): Use named imports for fetch runtime polyfill Next14 seems to have changed the way it handles default exports when using the webpack bundler for some of their build variants when using `npm run dev`. This commit ensures that we no longer use the default export in an effort to improve compat between the different nextjs versions. More information can be found here: https://esbuild.github.io/content-types/#default-interop and here: #612 * Create late-dolphins-peel.md --------- Co-authored-by: Nikos Douvlis <nikosdouvlis@gmail.com>
octoper
pushed a commit
that referenced
this pull request
Oct 31, 2023
* fix(backend): Fix for next 14 fetch bind issue * fix(nextjs): Use named imports for fetch runtime polyfill Next14 seems to have changed the way it handles default exports when using the webpack bundler for some of their build variants when using `npm run dev`. This commit ensures that we no longer use the default export in an effort to improve compat between the different nextjs versions. More information can be found here: https://esbuild.github.io/content-types/#default-interop and here: #612 * Create late-dolphins-peel.md --------- Co-authored-by: Nikos Douvlis <nikosdouvlis@gmail.com>
dimkl
pushed a commit
that referenced
this pull request
Oct 31, 2023
* fix(backend): Fix for next 14 fetch bind issue * fix(nextjs): Use named imports for fetch runtime polyfill Next14 seems to have changed the way it handles default exports when using the webpack bundler for some of their build variants when using `npm run dev`. This commit ensures that we no longer use the default export in an effort to improve compat between the different nextjs versions. More information can be found here: https://esbuild.github.io/content-types/#default-interop and here: #612 * Create late-dolphins-peel.md --------- Co-authored-by: Nikos Douvlis <nikosdouvlis@gmail.com>
dimkl
pushed a commit
that referenced
this pull request
Oct 31, 2023
* fix(backend): Fix for next 14 fetch bind issue * fix(nextjs): Use named imports for fetch runtime polyfill Next14 seems to have changed the way it handles default exports when using the webpack bundler for some of their build variants when using `npm run dev`. This commit ensures that we no longer use the default export in an effort to improve compat between the different nextjs versions. More information can be found here: https://esbuild.github.io/content-types/#default-interop and here: #612 * Create late-dolphins-peel.md --------- Co-authored-by: Nikos Douvlis <nikosdouvlis@gmail.com>
github-merge-queue bot
pushed a commit
that referenced
this pull request
Oct 31, 2023
* fix(clerk-sdk-node): Fix types of ClerkExpressWithAuth/ClerkExpressRequireAuth args (#1939) #1938 * fix(backend): Support NextJS 14 (#1948) * fix(backend): Fix for next 14 fetch bind issue * fix(nextjs): Use named imports for fetch runtime polyfill Next14 seems to have changed the way it handles default exports when using the webpack bundler for some of their build variants when using `npm run dev`. This commit ensures that we no longer use the default export in an effort to improve compat between the different nextjs versions. More information can be found here: https://esbuild.github.io/content-types/#default-interop and here: #612 * Create late-dolphins-peel.md --------- Co-authored-by: Nikos Douvlis <nikosdouvlis@gmail.com> --------- Co-authored-by: George Desipris <73396808+desiprisg@users.noreply.github.com> Co-authored-by: Nikos Douvlis <nikosdouvlis@gmail.com>
|
This PR has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Next14 seems to have changed the way it handles default exports when using the webpack bundler for some of their build variants when using
npm run dev. This commit ensures that we no longer use the default export in an effort to improve compat between the different nextjs versions.More information can be found here: https://esbuild.github.io/content-types/#default-interop
and here: #612
Checklist
npm testruns as expected.npm run buildruns as expected.Type of change
Packages affected
@clerk/clerk-js@clerk/clerk-react@clerk/nextjs@clerk/remix@clerk/types@clerk/themes@clerk/localizations@clerk/clerk-expo@clerk/backend@clerk/clerk-sdk-node@clerk/shared@clerk/fastify@clerk/chrome-extensiongatsby-plugin-clerkbuild/tooling/chore