Merge #56964

56964: cli: remove cockroach dump from CRDB r=knz a=adityamaru

Previously we maintained both BACKUP and dump as BACKUP was
enterprise-only but in 20.2+ basic backup that can do at least as much
as dump can is free so this is no longer a reason to keep dump.

More detailed explanation at #54040.

Fixes: #56405
Fixes: #28948

Co-authored-by: Aditya Maru <adityamaru@gmail.com>

pkg/cli/BUILD.bazel

@@ -18,7 +18,6 @@ go_library(
         "demo_cluster.go",
         "demo_telemetry.go",
         "doctor.go",
-        "dump.go",
         "error.go",
         "examples.go",
         "flags.go",
@@ -115,7 +114,6 @@ go_library(
         "//pkg/sql/catalog/catconstants",
         "//pkg/sql/catalog/descpb",
         "//pkg/sql/catalog/tabledesc",
-        "//pkg/sql/catalog/typedesc",
         "//pkg/sql/doctor",
         "//pkg/sql/execinfrapb",
         "//pkg/sql/lex",
@@ -127,9 +125,7 @@ go_library(
         "//pkg/sql/row",
         "//pkg/sql/sem/builtins",
         "//pkg/sql/sem/tree",
-        "//pkg/sql/sessiondata",
         "//pkg/sql/sessiondatapb",
-        "//pkg/sql/types",
         "//pkg/sqlmigrations",
         "//pkg/storage",
         "//pkg/storage/cloud",
@@ -138,7 +134,6 @@ go_library(
         "//pkg/ts/tspb",
         "//pkg/util",
         "//pkg/util/contextutil",
-        "//pkg/util/ctxgroup",
         "//pkg/util/encoding",
         "//pkg/util/encoding/csv",
         "//pkg/util/envutil",
@@ -161,8 +156,6 @@ go_library(
         "//pkg/util/stop",
         "//pkg/util/syncutil",
         "//pkg/util/sysutil",
-        "//pkg/util/timeofday",
-        "//pkg/util/timetz",
         "//pkg/util/timeutil",
         "//pkg/util/tracing",
         "//pkg/util/uuid",
@@ -194,7 +187,6 @@ go_library(
         "//vendor/github.com/kr/pretty",
         "//vendor/github.com/lib/pq",
         "//vendor/github.com/lib/pq/auth/kerberos",
-        "//vendor/github.com/lib/pq/oid",
         "//vendor/github.com/mattn/go-isatty",
         "//vendor/github.com/olekukonko/tablewriter",
         "//vendor/github.com/spf13/cobra",
@@ -265,7 +257,6 @@ go_test(
         "demo_locality_test.go",
         "demo_test.go",
         "doctor_test.go",
-        "dump_test.go",
         "error_test.go",
         "flags_test.go",
         "haproxy_test.go",
@@ -318,22 +309,14 @@ go_test(
         "//pkg/testutils/sqlutils",
         "//pkg/testutils/testcluster",
         "//pkg/util",
-        "//pkg/util/bitarray",
-        "//pkg/util/duration",
-        "//pkg/util/ipaddr",
-        "//pkg/util/json",
         "//pkg/util/leaktest",
         "//pkg/util/log",
         "//pkg/util/log/logflags",
         "//pkg/util/log/severity",
         "//pkg/util/protoutil",
-        "//pkg/util/randutil",
         "//pkg/util/stop",
         "//pkg/util/timeutil",
-        "//pkg/util/timeutil/pgdate",
-        "//pkg/util/uuid",
         "//pkg/workload/examples",
-        "//vendor/github.com/cockroachdb/apd/v2:apd",
         "//vendor/github.com/cockroachdb/datadriven",
         "//vendor/github.com/cockroachdb/errors",
         "//vendor/github.com/cockroachdb/pebble",

pkg/cli/cli.go

@@ -198,7 +198,6 @@ func init() {
 		stmtDiagCmd,
 		authCmd,
 		nodeCmd,
-		dumpCmd,
 		nodeLocalCmd,
 		userFileCmd,
 		importCmd,

pkg/cli/cli_test.go

@@ -2042,21 +2042,6 @@ func Example_sqlfmt() {
 	// SELECT (1 + 2) + 3
 }
 
-func Example_dump_no_visible_columns() {
-	c := newCLITest(cliTestParams{})
-	defer c.cleanup()
-
-	c.RunWithArgs([]string{"sql", "-e", "create table t(x int); set sql_safe_updates=false; alter table t drop x"})
-	c.RunWithArgs([]string{"dump", "defaultdb"})
-
-	// Output:
-	// sql -e create table t(x int); set sql_safe_updates=false; alter table t drop x
-	// ALTER TABLE
-	// dump defaultdb
-	// CREATE TABLE public.t (FAMILY "primary" (rowid)
-	// );
-}
-
 // Example_read_from_file tests the -f parameter.
 // The input file contains a mix of client-side and
 // server-side commands to ensure that both are supported with -f.