Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

roachtest: dump-backwards-compatibility failed #56405

Closed
cockroach-teamcity opened this issue Nov 7, 2020 · 13 comments · Fixed by #56964
Closed

roachtest: dump-backwards-compatibility failed #56405

cockroach-teamcity opened this issue Nov 7, 2020 · 13 comments · Fixed by #56964
Assignees
@adityamaru
Labels
branch-master Failures and bugs on the master branch. C-test-failure Broken test (automatically or manually discovered). O-roachtest O-robot Originated from a bot.

Comments

@cockroach-teamcity
Copy link
Member

(roachtest).dump-backwards-compatibility failed on master@61c96aaca632dfba5154d55d82c5af0732053b72:

The test failed on branch=master, cloud=gce:
test artifacts and logs in: /home/agent/work/.go/src/github.com/cockroachdb/cockroach/artifacts/dump-backwards-compatibility/run_1
	test.go:281,dump.go:71,versionupgrade.go:189,dump.go:45,dump.go:87,test_runner.go:755: expected CREATE TABLE t (
			x INT8 NULL,
			y INT8 NULL,
			FAMILY "primary" (x, y, rowid)
		);
		
		INSERT INTO public.t (x, y) VALUES
			(1, 1),
			(2, 2);, but found CREATE TABLE public.t (
			x INT8 NULL,
			y INT8 NULL,
			FAMILY "primary" (x, y, rowid)
		);
		
		INSERT INTO public.t (x, y) VALUES
			(1, 1),
			(2, 2);
More

Artifacts: /dump-backwards-compatibility

See this test on roachdash
powered by pkg/cmd/internal/issues
@cockroach-teamcity cockroach-teamcity added branch-master Failures and bugs on the master branch. C-test-failure Broken test (automatically or manually discovered). O-roachtest O-robot Originated from a bot. release-blocker Indicates a release-blocker. Use with branch-release-2x.x label to denote which branch is blocked. labels Nov 7, 2020
@thoszhang
Copy link
Contributor

This is failing because the "old" version is now 20.2. It's not clear to me what to do about this test.

@cockroach-teamcity
Copy link
Member Author

(roachtest).dump-backwards-compatibility failed on master@be84ae4a59e6a5e50694c1756e05b0ba7c3a54d8:

The test failed on branch=master, cloud=gce:
test artifacts and logs in: /home/agent/work/.go/src/github.com/cockroachdb/cockroach/artifacts/dump-backwards-compatibility/run_1
	test.go:281,dump.go:71,versionupgrade.go:189,dump.go:45,dump.go:87,test_runner.go:755: expected CREATE TABLE t (
			x INT8 NULL,
			y INT8 NULL,
			FAMILY "primary" (x, y, rowid)
		);
		
		INSERT INTO public.t (x, y) VALUES
			(1, 1),
			(2, 2);, but found CREATE TABLE public.t (
			x INT8 NULL,
			y INT8 NULL,
			FAMILY "primary" (x, y, rowid)
		);
		
		INSERT INTO public.t (x, y) VALUES
			(1, 1),
			(2, 2);
More

Artifacts: /dump-backwards-compatibility

See this test on roachdash
powered by pkg/cmd/internal/issues

@cockroach-teamcity
Copy link
Member Author

(roachtest).dump-backwards-compatibility failed on master@f2b53d1080f1ccc503263dd178ee31b4878d2360:

The test failed on branch=master, cloud=gce:
test artifacts and logs in: /home/agent/work/.go/src/github.com/cockroachdb/cockroach/artifacts/dump-backwards-compatibility/run_1
	test.go:281,dump.go:71,versionupgrade.go:189,dump.go:45,dump.go:87,test_runner.go:755: expected CREATE TABLE t (
			x INT8 NULL,
			y INT8 NULL,
			FAMILY "primary" (x, y, rowid)
		);
		
		INSERT INTO public.t (x, y) VALUES
			(1, 1),
			(2, 2);, but found CREATE TABLE public.t (
			x INT8 NULL,
			y INT8 NULL,
			FAMILY "primary" (x, y, rowid)
		);
		
		INSERT INTO public.t (x, y) VALUES
			(1, 1),
			(2, 2);
More

Artifacts: /dump-backwards-compatibility

See this test on roachdash
powered by pkg/cmd/internal/issues

@cockroach-teamcity
Copy link
Member Author

(roachtest).dump-backwards-compatibility failed on master@f2b53d1080f1ccc503263dd178ee31b4878d2360:

The test failed on branch=master, cloud=gce:
test artifacts and logs in: /home/agent/work/.go/src/github.com/cockroachdb/cockroach/artifacts/dump-backwards-compatibility/run_1
	test.go:281,dump.go:71,versionupgrade.go:189,dump.go:45,dump.go:87,test_runner.go:755: expected CREATE TABLE t (
			x INT8 NULL,
			y INT8 NULL,
			FAMILY "primary" (x, y, rowid)
		);
		
		INSERT INTO public.t (x, y) VALUES
			(1, 1),
			(2, 2);, but found CREATE TABLE public.t (
			x INT8 NULL,
			y INT8 NULL,
			FAMILY "primary" (x, y, rowid)
		);
		
		INSERT INTO public.t (x, y) VALUES
			(1, 1),
			(2, 2);
More

Artifacts: /dump-backwards-compatibility

See this test on roachdash
powered by pkg/cmd/internal/issues

@cockroach-teamcity
Copy link
Member Author

(roachtest).dump-backwards-compatibility failed on master@df21e5065a79d1dd5b0fd76018724dd26660beb2:

The test failed on branch=master, cloud=gce:
test artifacts and logs in: /home/agent/work/.go/src/github.com/cockroachdb/cockroach/artifacts/dump-backwards-compatibility/run_1
	test.go:281,dump.go:71,versionupgrade.go:189,dump.go:45,dump.go:87,test_runner.go:755: expected CREATE TABLE t (
			x INT8 NULL,
			y INT8 NULL,
			FAMILY "primary" (x, y, rowid)
		);
		
		INSERT INTO public.t (x, y) VALUES
			(1, 1),
			(2, 2);, but found CREATE TABLE public.t (
			x INT8 NULL,
			y INT8 NULL,
			FAMILY "primary" (x, y, rowid)
		);
		
		INSERT INTO public.t (x, y) VALUES
			(1, 1),
			(2, 2);
More

Artifacts: /dump-backwards-compatibility

See this test on roachdash
powered by pkg/cmd/internal/issues

@cockroach-teamcity
Copy link
Member Author

(roachtest).dump-backwards-compatibility failed on master@2d34be73030a0d114b84fc2785672eda072c5a50:

The test failed on branch=master, cloud=gce:
test artifacts and logs in: /home/agent/work/.go/src/github.com/cockroachdb/cockroach/artifacts/dump-backwards-compatibility/run_1
	test.go:281,dump.go:71,versionupgrade.go:189,dump.go:45,dump.go:87,test_runner.go:755: expected CREATE TABLE t (
			x INT8 NULL,
			y INT8 NULL,
			FAMILY "primary" (x, y, rowid)
		);
		
		INSERT INTO public.t (x, y) VALUES
			(1, 1),
			(2, 2);, but found CREATE TABLE public.t (
			x INT8 NULL,
			y INT8 NULL,
			FAMILY "primary" (x, y, rowid)
		);
		
		INSERT INTO public.t (x, y) VALUES
			(1, 1),
			(2, 2);
More

Artifacts: /dump-backwards-compatibility

See this test on roachdash
powered by pkg/cmd/internal/issues

@cockroach-teamcity
Copy link
Member Author

(roachtest).dump-backwards-compatibility failed on master@6b254f2d4a8e1470c1a7d5bd7c3f746d69de0797:

The test failed on branch=master, cloud=gce:
test artifacts and logs in: /home/agent/work/.go/src/github.com/cockroachdb/cockroach/artifacts/dump-backwards-compatibility/run_1
	test.go:281,dump.go:71,versionupgrade.go:189,dump.go:45,dump.go:87,test_runner.go:755: expected CREATE TABLE t (
			x INT8 NULL,
			y INT8 NULL,
			FAMILY "primary" (x, y, rowid)
		);
		
		INSERT INTO public.t (x, y) VALUES
			(1, 1),
			(2, 2);, but found CREATE TABLE public.t (
			x INT8 NULL,
			y INT8 NULL,
			FAMILY "primary" (x, y, rowid)
		);
		
		INSERT INTO public.t (x, y) VALUES
			(1, 1),
			(2, 2);
More

Artifacts: /dump-backwards-compatibility

See this test on roachdash
powered by pkg/cmd/internal/issues

@cockroach-teamcity
Copy link
Member Author

(roachtest).dump-backwards-compatibility failed on master@5d8f1d3dbc356573a1fb2d1d6bf564bf0370daff:

The test failed on branch=master, cloud=gce:
test artifacts and logs in: /home/agent/work/.go/src/github.com/cockroachdb/cockroach/artifacts/dump-backwards-compatibility/run_1
	test.go:281,dump.go:71,versionupgrade.go:189,dump.go:45,dump.go:87,test_runner.go:755: expected CREATE TABLE t (
			x INT8 NULL,
			y INT8 NULL,
			FAMILY "primary" (x, y, rowid)
		);
		
		INSERT INTO public.t (x, y) VALUES
			(1, 1),
			(2, 2);, but found CREATE TABLE public.t (
			x INT8 NULL,
			y INT8 NULL,
			FAMILY "primary" (x, y, rowid)
		);
		
		INSERT INTO public.t (x, y) VALUES
			(1, 1),
			(2, 2);
More

Artifacts: /dump-backwards-compatibility

See this test on roachdash
powered by pkg/cmd/internal/issues

@cockroach-teamcity
Copy link
Member Author

(roachtest).dump-backwards-compatibility failed on master@b4bf42c4fe10155717ac48f2e68ad8b501ca0b1a:

The test failed on branch=master, cloud=gce:
test artifacts and logs in: /home/agent/work/.go/src/github.com/cockroachdb/cockroach/artifacts/dump-backwards-compatibility/run_1
	test.go:281,dump.go:71,versionupgrade.go:189,dump.go:45,dump.go:87,test_runner.go:755: expected CREATE TABLE t (
			x INT8 NULL,
			y INT8 NULL,
			FAMILY "primary" (x, y, rowid)
		);
		
		INSERT INTO public.t (x, y) VALUES
			(1, 1),
			(2, 2);, but found CREATE TABLE public.t (
			x INT8 NULL,
			y INT8 NULL,
			FAMILY "primary" (x, y, rowid)
		);
		
		INSERT INTO public.t (x, y) VALUES
			(1, 1),
			(2, 2);
More

Artifacts: /dump-backwards-compatibility

See this test on roachdash
powered by pkg/cmd/internal/issues

@cockroach-teamcity
Copy link
Member Author

(roachtest).dump-backwards-compatibility failed on master@06944cb1996ed9ccfa036118b810e46673fe0ff4:

The test failed on branch=master, cloud=gce:
test artifacts and logs in: /home/agent/work/.go/src/github.com/cockroachdb/cockroach/artifacts/dump-backwards-compatibility/run_1
	test.go:281,dump.go:71,versionupgrade.go:189,dump.go:45,dump.go:87,test_runner.go:755: expected CREATE TABLE t (
			x INT8 NULL,
			y INT8 NULL,
			FAMILY "primary" (x, y, rowid)
		);
		
		INSERT INTO public.t (x, y) VALUES
			(1, 1),
			(2, 2);, but found CREATE TABLE public.t (
			x INT8 NULL,
			y INT8 NULL,
			FAMILY "primary" (x, y, rowid)
		);
		
		INSERT INTO public.t (x, y) VALUES
			(1, 1),
			(2, 2);
More

Artifacts: /dump-backwards-compatibility

See this test on roachdash
powered by pkg/cmd/internal/issues

@cockroach-teamcity
Copy link
Member Author

(roachtest).dump-backwards-compatibility failed on master@8ff64f5d897a9c7b39ca437193a11a7300cecbc1:

The test failed on branch=master, cloud=gce:
test artifacts and logs in: /home/agent/work/.go/src/github.com/cockroachdb/cockroach/artifacts/dump-backwards-compatibility/run_1
	test.go:281,dump.go:71,versionupgrade.go:189,dump.go:45,dump.go:87,test_runner.go:755: expected CREATE TABLE t (
			x INT8 NULL,
			y INT8 NULL,
			FAMILY "primary" (x, y, rowid)
		);
		
		INSERT INTO public.t (x, y) VALUES
			(1, 1),
			(2, 2);, but found CREATE TABLE public.t (
			x INT8 NULL,
			y INT8 NULL,
			FAMILY "primary" (x, y, rowid)
		);
		
		INSERT INTO public.t (x, y) VALUES
			(1, 1),
			(2, 2);
More

Artifacts: /dump-backwards-compatibility

See this test on roachdash
powered by pkg/cmd/internal/issues

@cockroach-teamcity
Copy link
Member Author

(roachtest).dump-backwards-compatibility failed on master@609cad52785f49338f7ceff289486b87db4cecb6:

The test failed on branch=master, cloud=gce:
test artifacts and logs in: /home/agent/work/.go/src/github.com/cockroachdb/cockroach/artifacts/dump-backwards-compatibility/run_1
	test.go:283,dump.go:71,versionupgrade.go:189,dump.go:45,dump.go:87,test_runner.go:755: expected CREATE TABLE t (
			x INT8 NULL,
			y INT8 NULL,
			FAMILY "primary" (x, y, rowid)
		);
		
		INSERT INTO public.t (x, y) VALUES
			(1, 1),
			(2, 2);, but found CREATE TABLE public.t (
			x INT8 NULL,
			y INT8 NULL,
			FAMILY "primary" (x, y, rowid)
		);
		
		INSERT INTO public.t (x, y) VALUES
			(1, 1),
			(2, 2);
More

Artifacts: /dump-backwards-compatibility

See this test on roachdash
powered by pkg/cmd/internal/issues

adityamaru added a commit to adityamaru/cockroach that referenced this issue Nov 20, 2020
@adityamaru
cli: remove cockroach dump from CRDB
ad01666 
Previously we maintained both BACKUP and dump as BACKUP was
enterprise-only but in 20.2+ basic backup that can do at least as much
as dump can is free so this is no longer a reason to keep dump.

More detailed explanation at cockroachdb#54040.

Fixes: cockroachdb#56405
@adityamaru adityamaru mentioned this issue Nov 20, 2020
Merged
@pbardea
Copy link
Contributor

pbardea commented Nov 23, 2020

Going to remove the release-blocker tag until #56964 closes this out.

@pbardea pbardea removed the release-blocker Indicates a release-blocker. Use with branch-release-2x.x label to denote which branch is blocked. label Nov 23, 2020
craig bot pushed a commit that referenced this issue Nov 23, 2020
@adityamaru
Merge #56964
22da098 
56964: cli: remove cockroach dump from CRDB r=knz a=adityamaru

Previously we maintained both BACKUP and dump as BACKUP was
enterprise-only but in 20.2+ basic backup that can do at least as much
as dump can is free so this is no longer a reason to keep dump.

More detailed explanation at #54040.

Fixes: #56405
Fixes: #28948

Co-authored-by: Aditya Maru <adityamaru@gmail.com>
@craig craig bot closed this as completed in 6d2d444 Nov 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@adityamaru adityamaru

Labels
branch-master Failures and bugs on the master branch. C-test-failure Broken test (automatically or manually discovered). O-roachtest O-robot Originated from a bot.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

cli: remove cockroach dump from CRDB adityamaru/cockroach
4 participants
@pbardea @thoszhang @adityamaru @cockroach-teamcity