cli: remove cockroach dump from CRDB #56964
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
knz
approved these changes
Nov 20, 2020
There was a problem hiding this comment.
Reviewed 5 of 5 files at r1.
Reviewable status:complete! 0 of 0 LGTMs obtained (waiting on @dt)
adityamaru
force-pushed
the
dump-is-dead
branch
4 times, most recently
from
31a1bf7
to
c878e3f
Compare
adityamaru
force-pushed
the
dump-is-dead
branch
from
c878e3f
to
dadf31d
Compare
Previously we maintained both BACKUP and dump as BACKUP was enterprise-only but in 20.2+ basic backup that can do at least as much as dump can is free so this is no longer a reason to keep dump. More detailed explanation at cockroachdb#54040. Fixes: cockroachdb#56405
adityamaru
force-pushed
the
dump-is-dead
branch
from
dadf31d
to
6d2d444
Compare
|
TFTRs! bors r=knz |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously we maintained both BACKUP and dump as BACKUP was
enterprise-only but in 20.2+ basic backup that can do at least as much
as dump can is free so this is no longer a reason to keep dump.
More detailed explanation at #54040.
Fixes: #56405
Fixes: #28948