Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

system: add default set of configured system.locations #39937

Closed
jordanlewis opened this issue Aug 23, 2019 · 0 comments · Fixed by #40229
Closed

system: add default set of configured system.locations #39937

jordanlewis opened this issue Aug 23, 2019 · 0 comments · Fixed by #40229
Assignees
@rohany
Labels
A-demo A-webui-nodemap C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception)

Comments

@jordanlewis
Copy link
Member

The system.locations table is a map from locality key/value pair to latlong coordinate. This is used to display nodes on the node map in the admin UI.

It's irritating for users to have to populate this stuff on their own. We should add a default set of latlongs that specify reasonable defaults for common localities, like the ones from AWS and GCP.

For example, looking at the geopartitioning docs, we see that we recommend using the region=us-east1 syntax. This page on the GCP website shows the locations for all regions: https://cloud.google.com/compute/docs/regions-zones/

Let's add latlongs for all of these zones by default.
@jordanlewis jordanlewis added C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) A-webui-nodemap labels Aug 23, 2019
@jordanlewis jordanlewis mentioned this issue Aug 23, 2019
Closed
@awoods187 awoods187 mentioned this issue Aug 23, 2019
Closed
12 tasks
@jordanlewis jordanlewis mentioned this issue Aug 26, 2019
Closed
@rohany rohany self-assigned this Aug 26, 2019
@rohany rohany mentioned this issue Aug 26, 2019
Merged
craig bot pushed a commit that referenced this issue Aug 29, 2019
@rohany @maddyblue
Merge #40229 #40271 #40320
06c7fba 
40229: demo: Add location information to default demo localities. r=knz a=rohany

Fixes #39937.

Adds default latitude and longitude information for the default
localities in cockroach demo so that the web UI is pre-populated.

Release note (cli change): Add location information to default
localities to populate web UI for cockroach demo.

40271: demo: Add a Movr workload to run in cockroach demo r=danhhz,nstewart a=rohany

Fixes #39944.

When the `--with-load` flag is passed to demo, a sample movr
workload is run against the database.

I tried my best to replicate the Movr load in Nate's example script.

Based on talks with Dan, it was better to copy out a simpler
version of the logic to run the workload than try to hook
into workload.

Release note (cli change): Add a workload to run with cockroach demo.

40320: randutil: allow COCKROACH_RANDOM_SEED to seed NewPseudoRand r=mjibson a=mjibson

Multiple people have been confused about the lack of interaction
between NewPseudoRand (which used to always generate a random seed)
and COCKROACH_RANDOM_SEED (which only influenced using the global rand
methods).

Release note: None

Co-authored-by: Rohan Yadav <rohany@alumni.cmu.edu>
Co-authored-by: Matt Jibson <matt.jibson@gmail.com>
@craig craig bot closed this as completed in 422a838 Aug 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rohany rohany

Labels
A-demo A-webui-nodemap C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

demo: Add location information to default demo localities. rohany/cockroach
3 participants
@jordanlewis @rohany @awoods187