demo: Add location information to default demo localities.

[rohany]

Fixes #39937.

Adds default latitude and longitude information for the default
localities in cockroach demo so that the web UI is pre-populated.

Release note (cli change): Add location information to default
localities to populate web UI for cockroach demo.

[cockroach-teamcity]

This change is 

[rohany]

Web UI with just running cockroach demo --nodes 9

[jordanlewis]

Sweet! I think we could take this one step further and have system.locations get populated by a migration or startup sequence so that every cluster has these default locations. It's pretty silly that we have to ask people to fill it out (and somehow I doubt people currently do). cc @piyush-singh - thoughts?

[knz]

👍 on pre-populating system.locations upfront for everyone.

however I could also see wisdom in providing a SQL data file as a separate DLC, with two tiers: one free tier with just 3 locations that's included in the binary (and used for demo) and one downloadable DLC which registers the feature use to marketing or something?

@piyush-singh maybe food for thought

[jordanlewis]

In the name of reducing friction for developers, and inspiring developer love, I would like to push back against that idea - the data is all free and easily accessible. Let's add it by default and be done with it - I don't want our users to see a semi-working node map and have to figure out how to make it fully-working.

[knz]

ok

an unrelated question - are you OK with these region names? ISTM these are identifiers that are specific to GCP, is the mapping between identifier and geographical location the same for EC2 and Azure?

[jordanlewis]

The mappings are different. Conveniently, all 3 clouds provide different region names :)

[awoods187]

I understand the idea of wanting to help marketing out here but I agree with @jordanlewis that the above proposal creates unnecessary developer friction.

[knz]

The mappings are different. Conveniently, all 3 clouds provide different region names :)

oh that's handy 🎉

sure then, it will make tutorials even more spiffy

[rohany]

Sweet! I think we could take this one step further and have system.locations get populated by a migration or startup sequence so that every cluster has these default locations. It's pretty silly that we have to ask people to fill it out (and somehow I doubt people currently do). cc @piyush-singh - thoughts?

oh, you want these to be published when starting any cluster, not just the demo? If we are doing that, might as well just prepopulate the system locations table with information about every region for all the cloud providers -- its on our docs anyway (https://www.cockroachlabs.com/docs/v19.1/enable-node-map.html)

[jordanlewis]

oh, you want these to be published when starting any cluster, not just the demo? If we are doing that, might as well just prepopulate the system locations table with information about every region for all the cloud providers -- its on our docs anyway

Yeah, that's what I was talking about too. I think we should just go ahead and do that - would help a lot of people.

[awoods187]

Yeah i agree--would be great

[rohany]

I set up populating the system.locations table as a migration right now, but I'm still looking into how to bake in that information during cluster startup.

As of now I have the migration be a noop if the system.locations table is not empty (to avoid overwriting users data), but we could change that.

PTAL

[knz]

nice.

[rohany]

bors r=knz

I can put up a PR later with all the GCE localities and locations set up, rather than just the ones used in the demo cluster.

[craig]

Build succeeded

• GitHub CI (Cockroach)