randutil: allow COCKROACH_RANDOM_SEED to seed NewPseudoRand #40320
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
tbg
approved these changes
Aug 29, 2019
There was a problem hiding this comment.
Reviewable status:
complete! 1 of 0 LGTMs obtained (waiting on @mjibson, @solongordon, and @tbg)
pkg/util/randutil/rand.go, line 43 at r1 (raw file):
} // NewSeededRand returns an instance of math/rand.Rand seeded with .
Comment is off
Multiple people have been confused about the lack of interaction between NewPseudoRand (which used to always generate a random seed) and COCKROACH_RANDOM_SEED (which only influenced using the global rand methods). Release note: None
|
Removed the unused function. |
|
bors r+ |
craig bot
pushed a commit
that referenced
this pull request
Aug 29, 2019
40229: demo: Add location information to default demo localities. r=knz a=rohany Fixes #39937. Adds default latitude and longitude information for the default localities in cockroach demo so that the web UI is pre-populated. Release note (cli change): Add location information to default localities to populate web UI for cockroach demo. 40271: demo: Add a Movr workload to run in cockroach demo r=danhhz,nstewart a=rohany Fixes #39944. When the `--with-load` flag is passed to demo, a sample movr workload is run against the database. I tried my best to replicate the Movr load in Nate's example script. Based on talks with Dan, it was better to copy out a simpler version of the logic to run the workload than try to hook into workload. Release note (cli change): Add a workload to run with cockroach demo. 40320: randutil: allow COCKROACH_RANDOM_SEED to seed NewPseudoRand r=mjibson a=mjibson Multiple people have been confused about the lack of interaction between NewPseudoRand (which used to always generate a random seed) and COCKROACH_RANDOM_SEED (which only influenced using the global rand methods). Release note: None Co-authored-by: Rohan Yadav <rohany@alumni.cmu.edu> Co-authored-by: Matt Jibson <matt.jibson@gmail.com>
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Multiple people have been confused about the lack of interaction
between NewPseudoRand (which used to always generate a random seed)
and COCKROACH_RANDOM_SEED (which only influenced using the global rand
methods).
Release note: None