Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

* 10 / 10000 can be simpler and save some gas #261

Closed
code423n4 opened this issue Dec 7, 2021 · 1 comment
Closed

* 10 / 10000 can be simpler and save some gas #261

code423n4 opened this issue Dec 7, 2021 · 1 comment
Labels
bug Something isn't working duplicate This issue or pull request already exists G (Gas Optimization)

Comments

@code423n4
Copy link
Contributor

Handle

WatchPug

Vulnerability details

https://github.com/code-423n4/2021-11-streaming/blob/56d81204a00fc949d29ddd277169690318b36821/Streaming/src/Locke.sol#L711-L711

uint112 feeAmt = amount * 10 / 10000; // 10bps fee

Recommendation

Change to:

uint112 feeAmt = amount / 1000; // 10bps fee
@code423n4 code423n4 added bug Something isn't working G (Gas Optimization) labels Dec 7, 2021
code423n4 added a commit that referenced this issue Dec 7, 2021
@code423n4
WatchPug issue #261
08ec75d
@0xean
Copy link
Collaborator

0xean commented Jan 17, 2022

dupe of #188

@0xean 0xean closed this as completed Jan 17, 2022
@0xean 0xean added the duplicate This issue or pull request already exists label Jan 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working duplicate This issue or pull request already exists G (Gas Optimization)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@0xean @code423n4