Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Directly calculate fee in flash loan #188

Open
code423n4 opened this issue Dec 6, 2021 · 0 comments
Open

Directly calculate fee in flash loan #188

code423n4 opened this issue Dec 6, 2021 · 0 comments
Labels
bug Something isn't working G (Gas Optimization)

Comments

@code423n4
Copy link
Contributor

Handle

0x0x0x

Vulnerability details

https://github.com/code-423n4/2021-11-streaming/blob/56d81204a00fc949d29ddd277169690318b36821/Streaming/src/Locke.sol#L711

uint112 feeAmt = amount * 10 / 10000; // 10bps fee

One can simply replace it with

uint112 feeAmt = amount / 1000; // 10bps fee

and save gas without sacrificing any precision.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working G (Gas Optimization)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@code423n4