Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove constant maths #64

Closed
code423n4 opened this issue Dec 2, 2021 · 1 comment
Closed

Remove constant maths #64

code423n4 opened this issue Dec 2, 2021 · 1 comment
Labels
bug Something isn't working duplicate This issue or pull request already exists G (Gas Optimization)

Comments

@code423n4
Copy link
Contributor

Handle

0x1f8b

Vulnerability details

Impact

Gas optimization.

Proof of Concept

In the line https://github.com/code-423n4/2021-11-streaming/blob/56d81204a00fc949d29ddd277169690318b36821/Streaming/src/Locke.sol#L711 it was multiply by 10 and then divided by 10.000, it's better to do only a div by 1.000, because the result will be the same.

Tools Used

Manual review

Recommended Mitigation Steps

Change the line to: uint112 feeAmt = amount / 1000; // 10bps fee
@code423n4 code423n4 added bug Something isn't working G (Gas Optimization) labels Dec 2, 2021
code423n4 added a commit that referenced this issue Dec 2, 2021
@code423n4
0x1f8b issue #64
a5b5deb
@0xean
Copy link
Collaborator

0xean commented Jan 16, 2022

dupe of #188

@0xean 0xean closed this as completed Jan 16, 2022
@0xean 0xean added the duplicate This issue or pull request already exists label Jan 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working duplicate This issue or pull request already exists G (Gas Optimization)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@0xean @code423n4