Cryptic car parameter names make car support painfully annoying #124
Comments
|
Will merge a PR that renames them 👍 |
|
@vntarasov - Is this the merge you've been waiting for? |
|
Yes, fixed in 1ad9cc8 👍 |
geohot
pushed a commit
that referenced
this issue
Aug 2, 2018
5570dac Merge pull request #124 from AllWashedOut/patch-1 341e6d3 bumped panda version 98b71f3 Toyota safety: added support for camry and chr (#127) ba8762d Toyota safety: vars and consts need 'toyota_' prefix d8fc9ff Update tesla_tester.py 2a8c2c2 Strengthen VIN detection git-subtree-dir: panda git-subtree-split: 5570dac
rbiasini
pushed a commit
that referenced
this issue
Aug 4, 2018
* Update README.md (#295) Changed GM minimum speed for steer control * Added 2014 pre-AP tesla (prior to Oct 28, 2014) (#303) * Revert "Added 2014 pre-AP tesla (prior to Oct 28, 2014) (#303)" (#307) This reverts commit e07853b. * Squashed 'panda/' changes from 5c905b7..5570dac 5570dac Merge pull request #124 from AllWashedOut/patch-1 341e6d3 bumped panda version 98b71f3 Toyota safety: added support for camry and chr (#127) ba8762d Toyota safety: vars and consts need 'toyota_' prefix d8fc9ff Update tesla_tester.py 2a8c2c2 Strengthen VIN detection git-subtree-dir: panda git-subtree-split: 5570dac * Squashed 'opendbc/' changes from 3741637..d62ebdd d62ebdd Toyota: added chr hybrid. Honda: regenerated fit. 29e3247 This adds support for 8 Speed Auto Tranismission (#104) ebfe5238 🚐 more chrysler pacifica signals (#84) 5023510 Honda Nidec: added wrong config radar value 563e3b5 Add 2018 Honda Fit EX F-CAN dbc (#100) git-subtree-dir: opendbc git-subtree-split: d62ebdd * openpilot v0.5.1 release * Spelling Correction (#316)
adhintz
added a commit
to adhintz/openpilot
that referenced
this issue
Dec 14, 2018
* Squashed 'opendbc/' changes from 3f6cd74..e108b6b e108b6b Add more Sign recognitions (commaai#126) 6e8a363 Add GM FCW Alert (Take 2) (commaai#125) 368701a Revert "Add GM FCW dashboard alert (commaai#123)" (commaai#124) 98b5f66 Add GM FCW dashboard alert (commaai#123) 71b7588 Adds dbc for 2019 Honda Insight (commaai#122) git-subtree-dir: opendbc git-subtree-split: e108b6b * Squashed 'pyextra/' changes from fb152de..8cc1594 8cc1594 update overpy 2c18997 switch to forked version of overpy git-subtree-dir: pyextra git-subtree-split: 8cc1594238fcae6acb8bcd825ac73bbca586b1be * openpilot v0.5.7 release * 0.5.7 hotfixes * On pedal press, if in steer error state, do not send ACC cancel button message. Sending the ACC cancel button message in this state causes the car to display warnings. * set the new ret.openpilotLongitudinalControl = False
adhintz
added a commit
to adhintz/openpilot
that referenced
this issue
Dec 18, 2018
* GM: remove refactor leftovers (commaai#440) * Move calibration values (commaai#441) * initial commit * moved constants * Keep steering on radar fault (commaai#442) * Add initial support for Holden/Opel Astra BK (commaai#431) * Added Astra support to README and RELEASE notes (commaai#443) * Honda Nidec: avoid giraffe setting alert when car is turned off (commaai#449) * Adding support for 2018 GMC Acadia Denali (commaai#453) * added acadia * adding acadia * adding acadia * Update radar_interface.py * adding acadia * refactored * fixed tuning * Adding acadia * Update interface.py * fixed whitespace * fixed whitespace * ACC cancel button * GM: Cadillac ATS Coupe 2018 support (commaai#445) * GM: Cadillac ATS Coupe 2018 support * Missed adding Cadillac ATS * Fixed Capitalization + Made CT6 Comment Cleaner (commaai#456) * Update README.md * Updated CT6 comment * Add Lexus RX450HL as sub to RX450H (commaai#458) Add Lexus RX450HL as sub to RX450H * on gas pedal press, send cancel ACC button to cancel OpenPilot * try sending +1 counter so our message isn't a duplicate * only do the accel pedal for specific cars * do accel pedal for all models * try always sending 1 for cancel acc frame * clean up comments and remove unused moving_fast * remove unused make can msg parameters * try incrementing wheel button counter by 2 to see if that works better for cancel * Squashed 'opendbc/' changes from 3f6cd74..e108b6b e108b6b Add more Sign recognitions (commaai#126) 6e8a363 Add GM FCW Alert (Take 2) (commaai#125) 368701a Revert "Add GM FCW dashboard alert (commaai#123)" (commaai#124) 98b5f66 Add GM FCW dashboard alert (commaai#123) 71b7588 Adds dbc for 2019 Honda Insight (commaai#122) git-subtree-dir: opendbc git-subtree-split: e108b6b * Squashed 'pyextra/' changes from fb152de..8cc1594 8cc1594 update overpy 2c18997 switch to forked version of overpy git-subtree-dir: pyextra git-subtree-split: 8cc1594238fcae6acb8bcd825ac73bbca586b1be * openpilot v0.5.7 release * try to simplify message logic * clean up code * move Chrylser into main table in readme * 0.5.7 hotfixes * On pedal press, if in steer error state, do not send ACC cancel button message. Sending the ACC cancel button message in this state causes the car to display warnings. * set the new ret.openpilotLongitudinalControl = False * hotfix: wait longer in CDP mode before switching to fast charge, so EON can boot (commaai#469) * generalize jeep fingerprint to also cover 2017 Jeep Grand Cherokee Trailhawk * disable pedal_gas for now to do a devel release. Sending 23b might fault other cars. * add jeep grand cherokee 2017 to readme car list
adhintz
added a commit
to adhintz/openpilot
that referenced
this issue
Dec 20, 2018
) * GM: remove refactor leftovers (commaai#440) * Move calibration values (commaai#441) * initial commit * moved constants * Keep steering on radar fault (commaai#442) * Add initial support for Holden/Opel Astra BK (commaai#431) * Added Astra support to README and RELEASE notes (commaai#443) * Honda Nidec: avoid giraffe setting alert when car is turned off (commaai#449) * Adding support for 2018 GMC Acadia Denali (commaai#453) * added acadia * adding acadia * adding acadia * Update radar_interface.py * adding acadia * refactored * fixed tuning * Adding acadia * Update interface.py * fixed whitespace * fixed whitespace * ACC cancel button * GM: Cadillac ATS Coupe 2018 support (commaai#445) * GM: Cadillac ATS Coupe 2018 support * Missed adding Cadillac ATS * Fixed Capitalization + Made CT6 Comment Cleaner (commaai#456) * Update README.md * Updated CT6 comment * Add Lexus RX450HL as sub to RX450H (commaai#458) Add Lexus RX450HL as sub to RX450H * on gas pedal press, send cancel ACC button to cancel OpenPilot * try sending +1 counter so our message isn't a duplicate * only do the accel pedal for specific cars * do accel pedal for all models * try always sending 1 for cancel acc frame * clean up comments and remove unused moving_fast * remove unused make can msg parameters * try incrementing wheel button counter by 2 to see if that works better for cancel * Squashed 'opendbc/' changes from 3f6cd74..e108b6b e108b6b Add more Sign recognitions (commaai#126) 6e8a363 Add GM FCW Alert (Take 2) (commaai#125) 368701a Revert "Add GM FCW dashboard alert (commaai#123)" (commaai#124) 98b5f66 Add GM FCW dashboard alert (commaai#123) 71b7588 Adds dbc for 2019 Honda Insight (commaai#122) git-subtree-dir: opendbc git-subtree-split: e108b6b * Squashed 'pyextra/' changes from fb152de..8cc1594 8cc1594 update overpy 2c18997 switch to forked version of overpy git-subtree-dir: pyextra git-subtree-split: 8cc1594238fcae6acb8bcd825ac73bbca586b1be * openpilot v0.5.7 release * try to simplify message logic * clean up code * move Chrylser into main table in readme * 0.5.7 hotfixes * On pedal press, if in steer error state, do not send ACC cancel button message. Sending the ACC cancel button message in this state causes the car to display warnings. * set the new ret.openpilotLongitudinalControl = False * hotfix: wait longer in CDP mode before switching to fast charge, so EON can boot (commaai#469) * generalize jeep fingerprint to also cover 2017 Jeep Grand Cherokee Trailhawk * disable pedal_gas for now to do a devel release. Sending 23b might fault other cars. * add jeep grand cherokee 2017 to readme car list * separate fingerprint for trailhawk. separate wheelbase for Cherokee
adhintz
added a commit
to adhintz/openpilot
that referenced
this issue
Dec 29, 2018
* GM: remove refactor leftovers (commaai#440) * Move calibration values (commaai#441) * initial commit * moved constants * Keep steering on radar fault (commaai#442) * Add initial support for Holden/Opel Astra BK (commaai#431) * Added Astra support to README and RELEASE notes (commaai#443) * Honda Nidec: avoid giraffe setting alert when car is turned off (commaai#449) * Adding support for 2018 GMC Acadia Denali (commaai#453) * added acadia * adding acadia * adding acadia * Update radar_interface.py * adding acadia * refactored * fixed tuning * Adding acadia * Update interface.py * fixed whitespace * fixed whitespace * ACC cancel button * GM: Cadillac ATS Coupe 2018 support (commaai#445) * GM: Cadillac ATS Coupe 2018 support * Missed adding Cadillac ATS * Fixed Capitalization + Made CT6 Comment Cleaner (commaai#456) * Update README.md * Updated CT6 comment * Add Lexus RX450HL as sub to RX450H (commaai#458) Add Lexus RX450HL as sub to RX450H * on gas pedal press, send cancel ACC button to cancel OpenPilot * try sending +1 counter so our message isn't a duplicate * only do the accel pedal for specific cars * do accel pedal for all models * try always sending 1 for cancel acc frame * clean up comments and remove unused moving_fast * remove unused make can msg parameters * try incrementing wheel button counter by 2 to see if that works better for cancel * Squashed 'opendbc/' changes from 3f6cd74..e108b6b e108b6b Add more Sign recognitions (commaai#126) 6e8a363 Add GM FCW Alert (Take 2) (commaai#125) 368701a Revert "Add GM FCW dashboard alert (commaai#123)" (commaai#124) 98b5f66 Add GM FCW dashboard alert (commaai#123) 71b7588 Adds dbc for 2019 Honda Insight (commaai#122) git-subtree-dir: opendbc git-subtree-split: e108b6b * Squashed 'pyextra/' changes from fb152de..8cc1594 8cc1594 update overpy 2c18997 switch to forked version of overpy git-subtree-dir: pyextra git-subtree-split: 8cc1594238fcae6acb8bcd825ac73bbca586b1be * openpilot v0.5.7 release * try to simplify message logic * clean up code * move Chrylser into main table in readme * 0.5.7 hotfixes * On pedal press, if in steer error state, do not send ACC cancel button message. Sending the ACC cancel button message in this state causes the car to display warnings. * set the new ret.openpilotLongitudinalControl = False * hotfix: wait longer in CDP mode before switching to fast charge, so EON can boot (commaai#469) * generalize jeep fingerprint to also cover 2017 Jeep Grand Cherokee Trailhawk * disable pedal_gas for now to do a devel release. Sending 23b might fault other cars. * add jeep grand cherokee 2017 to readme car list * separate fingerprint for trailhawk. separate wheelbase for Cherokee * add fingerprint for Pacifica 2019 Hybrid.
adhintz
added a commit
to adhintz/openpilot
that referenced
this issue
Dec 29, 2018
* remove logging from devel * Revert "remove logging from devel" This reverts commit 2145747. * Squashed 'opendbc/' changes from 3f6cd74..e108b6b e108b6b Add more Sign recognitions (commaai#126) 6e8a363 Add GM FCW Alert (Take 2) (commaai#125) 368701a Revert "Add GM FCW dashboard alert (commaai#123)" (commaai#124) 98b5f66 Add GM FCW dashboard alert (commaai#123) 71b7588 Adds dbc for 2019 Honda Insight (commaai#122) git-subtree-dir: opendbc git-subtree-split: e108b6b * Squashed 'pyextra/' changes from fb152de..8cc1594 8cc1594 update overpy 2c18997 switch to forked version of overpy git-subtree-dir: pyextra git-subtree-split: 8cc1594238fcae6acb8bcd825ac73bbca586b1be * openpilot v0.5.7 release * 0.5.7 hotfixes * On pedal press, if in steer error state, do not send ACC cancel button message. Sending the ACC cancel button message in this state causes the car to display warnings. * set the new ret.openpilotLongitudinalControl = False * hotfix: wait longer in CDP mode before switching to fast charge, so EON can boot (commaai#469) * generalize jeep fingerprint to also cover 2017 Jeep Grand Cherokee Trailhawk * disable pedal_gas for now to do a devel release. Sending 23b might fault other cars. * add jeep grand cherokee 2017 to readme car list * 0.5.7 & Jeep Grand Cherokee 2017 support (#7) * GM: remove refactor leftovers (commaai#440) * Move calibration values (commaai#441) * initial commit * moved constants * Keep steering on radar fault (commaai#442) * Add initial support for Holden/Opel Astra BK (commaai#431) * Added Astra support to README and RELEASE notes (commaai#443) * Honda Nidec: avoid giraffe setting alert when car is turned off (commaai#449) * Adding support for 2018 GMC Acadia Denali (commaai#453) * added acadia * adding acadia * adding acadia * Update radar_interface.py * adding acadia * refactored * fixed tuning * Adding acadia * Update interface.py * fixed whitespace * fixed whitespace * ACC cancel button * GM: Cadillac ATS Coupe 2018 support (commaai#445) * GM: Cadillac ATS Coupe 2018 support * Missed adding Cadillac ATS * Fixed Capitalization + Made CT6 Comment Cleaner (commaai#456) * Update README.md * Updated CT6 comment * Add Lexus RX450HL as sub to RX450H (commaai#458) Add Lexus RX450HL as sub to RX450H * on gas pedal press, send cancel ACC button to cancel OpenPilot * try sending +1 counter so our message isn't a duplicate * only do the accel pedal for specific cars * do accel pedal for all models * try always sending 1 for cancel acc frame * clean up comments and remove unused moving_fast * remove unused make can msg parameters * try incrementing wheel button counter by 2 to see if that works better for cancel * Squashed 'opendbc/' changes from 3f6cd74..e108b6b e108b6b Add more Sign recognitions (commaai#126) 6e8a363 Add GM FCW Alert (Take 2) (commaai#125) 368701a Revert "Add GM FCW dashboard alert (commaai#123)" (commaai#124) 98b5f66 Add GM FCW dashboard alert (commaai#123) 71b7588 Adds dbc for 2019 Honda Insight (commaai#122) git-subtree-dir: opendbc git-subtree-split: e108b6b * Squashed 'pyextra/' changes from fb152de..8cc1594 8cc1594 update overpy 2c18997 switch to forked version of overpy git-subtree-dir: pyextra git-subtree-split: 8cc1594238fcae6acb8bcd825ac73bbca586b1be * openpilot v0.5.7 release * try to simplify message logic * clean up code * move Chrylser into main table in readme * 0.5.7 hotfixes * On pedal press, if in steer error state, do not send ACC cancel button message. Sending the ACC cancel button message in this state causes the car to display warnings. * set the new ret.openpilotLongitudinalControl = False * hotfix: wait longer in CDP mode before switching to fast charge, so EON can boot (commaai#469) * generalize jeep fingerprint to also cover 2017 Jeep Grand Cherokee Trailhawk * disable pedal_gas for now to do a devel release. Sending 23b might fault other cars. * add jeep grand cherokee 2017 to readme car list * separate fingerprint for trailhawk. separate wheelbase for Cherokee * separate fingerprint for trailhawk. separate wheelbase for Cherokee (#8) * GM: remove refactor leftovers (commaai#440) * Move calibration values (commaai#441) * initial commit * moved constants * Keep steering on radar fault (commaai#442) * Add initial support for Holden/Opel Astra BK (commaai#431) * Added Astra support to README and RELEASE notes (commaai#443) * Honda Nidec: avoid giraffe setting alert when car is turned off (commaai#449) * Adding support for 2018 GMC Acadia Denali (commaai#453) * added acadia * adding acadia * adding acadia * Update radar_interface.py * adding acadia * refactored * fixed tuning * Adding acadia * Update interface.py * fixed whitespace * fixed whitespace * ACC cancel button * GM: Cadillac ATS Coupe 2018 support (commaai#445) * GM: Cadillac ATS Coupe 2018 support * Missed adding Cadillac ATS * Fixed Capitalization + Made CT6 Comment Cleaner (commaai#456) * Update README.md * Updated CT6 comment * Add Lexus RX450HL as sub to RX450H (commaai#458) Add Lexus RX450HL as sub to RX450H * on gas pedal press, send cancel ACC button to cancel OpenPilot * try sending +1 counter so our message isn't a duplicate * only do the accel pedal for specific cars * do accel pedal for all models * try always sending 1 for cancel acc frame * clean up comments and remove unused moving_fast * remove unused make can msg parameters * try incrementing wheel button counter by 2 to see if that works better for cancel * Squashed 'opendbc/' changes from 3f6cd74..e108b6b e108b6b Add more Sign recognitions (commaai#126) 6e8a363 Add GM FCW Alert (Take 2) (commaai#125) 368701a Revert "Add GM FCW dashboard alert (commaai#123)" (commaai#124) 98b5f66 Add GM FCW dashboard alert (commaai#123) 71b7588 Adds dbc for 2019 Honda Insight (commaai#122) git-subtree-dir: opendbc git-subtree-split: e108b6b * Squashed 'pyextra/' changes from fb152de..8cc1594 8cc1594 update overpy 2c18997 switch to forked version of overpy git-subtree-dir: pyextra git-subtree-split: 8cc1594238fcae6acb8bcd825ac73bbca586b1be * openpilot v0.5.7 release * try to simplify message logic * clean up code * move Chrylser into main table in readme * 0.5.7 hotfixes * On pedal press, if in steer error state, do not send ACC cancel button message. Sending the ACC cancel button message in this state causes the car to display warnings. * set the new ret.openpilotLongitudinalControl = False * hotfix: wait longer in CDP mode before switching to fast charge, so EON can boot (commaai#469) * generalize jeep fingerprint to also cover 2017 Jeep Grand Cherokee Trailhawk * disable pedal_gas for now to do a devel release. Sending 23b might fault other cars. * add jeep grand cherokee 2017 to readme car list * separate fingerprint for trailhawk. separate wheelbase for Cherokee * add fingerprint for Pacifica 2019 Hybrid.
Gernby
pushed a commit
to Gernby/openpilot
that referenced
this issue
Mar 11, 2019
Improve Acceleration
Gernby
pushed a commit
to Gernby/openpilot
that referenced
this issue
Mar 11, 2019
* Pull Gernby tuning params into kegman.json & add cell phone Python tuner (commaai#126) * Add Gernby params to /data/kegman.json config file * Add Gernby params to JSON part 2 * Add Gernby "live" tuning thru /data/kegman.json * Fix missing " * == * float() * Add Gernby tuning Params into /data/kegman.json * Add Gernby live json tuning params to interface.py * Add tune.py and tune.sh primitive tuning script * Update planner.py (commaai#124) Improve Acceleration * Turn on tuneGernby to "1" when running tune.py * Fix kegman.conf for tuneGernby assignment * Write tuneGernby to JSON * Remove tuning code - cannot enable live from here * Extract live tuning params kegman_conf in latcontrol.py * Put live tune params into Latcontrol * self.live_tune call * remove e2front for now * Fix PL * don't pull from kegman.json every frame * mod 300 * mpc_frame init * Add KpV and KiV to live_tune * Update latcontrol.py * change tune vals to -1 to self-populate in latcontrol.py * add KpV and KiV * Update kegman_conf.py * Update kegman_conf.py * fix steerKf * write defaults to JSON * Update latcontrol.py * Update latcontrol.py * Update latcontrol.py * Change to Ki and Kp to avoid var conflict * Update kegman_conf.py * Fix retrieval of kegman json object in __init__ latcontrol.py * Fix quotes around "-1" values in JSON * Ki and Kp in tune.py instead of KiV and KpV * Comment out __init__ kegman_conf write troubleshoot * Update latcontrol.py * convert kP and kI into arrays? * Update latcontrol.py * convert array back into string before writing kP and kI * Round kI and kP to 2 decimal places * Press space for next, M for previous element, add 1 and 0 * Remap keys * Fix indent * Update tune.py * Update tune.py * d g j instead of e t u
mespiritu
pushed a commit
to mespiritu/openpilot
that referenced
this issue
Apr 1, 2019
avolmensky
pushed a commit
to avolmensky/openpilot
that referenced
this issue
Jun 10, 2019
This reverts commit 98b5f66.
avolmensky
pushed a commit
to avolmensky/openpilot
that referenced
this issue
Jun 30, 2019
Strengthen Tesla VIN detection
SippieCup
pushed a commit
to SippieCup/openpilot
that referenced
this issue
Nov 9, 2019
SippieCup
pushed a commit
to SippieCup/openpilot
that referenced
this issue
Nov 14, 2019
* fix ALCA module * Update ALCA_module.py * Promote panda fixes from alpha to devel (commaai#98) * Fix for mock car crash * fix ALCA module * do not use * radar_interface logic improvements * remove radar logging * radar_interface refactoring * Log radar_interface CAN error, Process Comm Errors (commaai#95) * Log radar_interface CAN error * Add support for process comm error logging * Improve Process Comm error logging * Can and CommError throttling * Update radar_interface.py * fixing push per Raf's comments * ALCA and radar_interface work (commaai#96) (commaai#97) * do not use * radar_interface logic improvements * remove radar logging * radar_interface refactoring * Update radar_interface.py * fixing push per Raf's comments * fix process comm issue * switch radard from lane_parser to model * radar/ALCA changes * fix lane width * switched back to not deleting CarParams to avoid radar failure when rebooting EON while driving * cleanup some debug info to be able to restart ALCA research * tweaks on safety_tesla.h for can bus isolation * few more cleanups to safety_tesla.h * fix start signal logic * Increase LEXUS_IS safetyParam to 77 (commaai#841) * use list comprehension (commaai#839) * use list comprehension * oops index range fix * simplify encode/decode in dbc (commaai#840) * simplify encode/decode * 2019 Highlander Hybrid Limited Platinum (commaai#843) fingerprint from ogdragonzypher on Discord * Allow to lock safety mode to keep gm/tesla cars supported (commaai#844) * Force subaru to assume the stock camera is connected (commaai#849) * Revert to using the sum of the lane line probabilities instead of the the product * Add core OP support for CRC validation, with extra support for Volkswagen MQB (commaai#836) * Generalized core OP CRC support plus extra bits for Volkswagen MQB. * Update ref to process_replay regression test * Remove unneded use of replace, causing json to fail loading the alert * Add supported car for 2019 Toyota Altis Hybrid (commaai#859) * add supported car for 2019 Toyota Altis Hybird / Corolla hybrid 2020 (US market) * remove unnecessary comprehensions (commaai#863) * Added fingerprint from Sienna XLE AWD (commaai#848) * Added fingerprint from Sienna XLE AWD * Update driver_monitor.py * Update driver_monitor.py * Update driver_monitor.py * fix stupid merge issue * Adds 2019 Lexus ES (non hybrid) (commaai#866) * Adds 2019 Lexus ES (non hybrid) * Updated test route * merge issues * Update README with now supported Subaru Harness * Disable LDW for 4 seconds after blinker transition from on to off (commaai#112) If we want to change lanes with a blinker tap (3 blink mode), then we need to disable LDW for enough time to allow a smooth manual lane change. 4 seconds as it seems the freq is actually around 50Hz, not 100Hz. * Disable HSO for 3 seconds after blinker has been active (commaai#111) Avoid HSO will deactivate and try to take the car back into the lane during a manual lane change with blinker tapped (3 blinks mode) * params learner to only learn @ cons speed Acceleration/deceleration in turns affect yaw as measured by phone and will create potential issues with learner. This code changes the learner to only adjust parameters when speed is constant * Update to match new version of python in eons * python 3 fixes for test client / server * async/await server * Don't log for action message as it's too often, and we throttle it internally. * fix merge issue in thermald * fixes and tweaks; code simplification * Saving P,I,F parameters from pid controller (commaai#116) Added separate save/load functions, try catch - and saving the right constants to the params file. * Feature/tinklad throttling + linting (commaai#118) * Throttle tinlkad's attemptToSendPendingMessages * Remove get_git_remote from registration. It's defined in version already. * tinklad linting * tesla linting * Prevent multiple readings of the pid params file (commaai#119) ..only load the pid values when we initiate the LoC * missing V_PID_FILE constant (commaai#121) * show cars in IC for non-radar users (commaai#120) * bug fixes * Fix issue where user info was being dropped on no connectivity (commaai#122) * move pisParams, fix GPS logging * Bugfix tinklad throttling (commaai#124) * ALCA4 (still in dev) * ALCA4 tuning * ALCA4 alpha release * ALCA4 tweak for turns * ACC fix; LDW mite during ALCA * ALCA polishing * fix enter_canloader.py for python 3 * should_ldw changes moved the should_ldw code closer together and added status messages for when LDW is active and inactive * thermald and ALCA * ALCA sinplified logic
mattbsea
pushed a commit
to mattbsea/openpilot
that referenced
this issue
Jul 24, 2020
* add debugging statements * fix * run all * run it manually * lower priority and affinity * let's see what cpu usage this gets us * change to 1 * no realtime * ls_state * print len * so more tracks get grouped * debug * debug * debug * debug * debug * debug * debug * debug * see if this is faster * better * so this is slower? * woah, np.mean can be as low as 400 Hz while sum()/len() is anywhere from 2000 to 5000 hz! wth numpy * debugging * better * better * don't be random everytime * remove * debug * debug * debug * is this any better? * that was bad * see which is quicker * okay, so this is the quickest * debug which poly val function is faster * debug which poly val function is faster * debug which poly val function is faster * debug which poly val function is faster * debug which poly val function is faster * test out faster function * remove * print average * cleaner * test original function * test 1st new function * test 2nd new function * only measure polyval * run for 60 sec then quit * don't run updated * 2nd function test * 3rd function test * now only time grouping loop * now only time grouping loop * why not 60 * calc only once instead of up to 2*3 times * move here * slightly faster here * get a baseline of the whole function now * don't use a np array for lane bounds, no need. might be faster * add hz * woah, removing numpy from bounds and offsetting manually make the rate go from 766.2768 to 1299.8735 hz * use if checks instead of a loop test * comment old loop * reverse the if check so that we do speed check first * move static track object logic to Lane class to remove lines of code in group_tracks. let's see if it's faster * test loop now * okay, loop is still slower at 1200 Hz vs 1500 hz with this method (if checks and logic in Lane class for static tracks) * previous commit was 1562 Hz * previous commit was 1599 Hz, this commit *should* be faster * yup, this commit was 1635 Hz. it's not pretty, but it's faster * debug * one should be oncoming * one more * one more * one more * one more * one more * one more * this is good * get a baseline * offset y_rel instead of bounds * offset y_rel instead of bounds * fix * calculate on demand instead of all at once test * old faster method again * move eval_poly to the same list comp, last commit was 1923 hz * dang, last commit was 2072 Hz! * now see if moving it into the main loop will be any faster * nah, that was 2032.8366 Hz vs 2072 * okay now it's slower again?? what is this then? last was 2048 down from 2079 * let's just use this, it's faster marginally for some reason * so this should be even faster, right? previous was around 2033 hz * nope, much slower at 1819 hz. this is good * get baseline without as many print statements * last commit was 1958 hz, just want to test this code one more time * last commit was 1931 hz, so; slower. test loop one last time with new offset_y_rel code * loop was still slower at 1849 hz, so this looks to be the fastest! * clean up and print lanes to verify the logic hasn't changed * remove * clean up * clean up * clean up and use numpy_fast for interpolating * use numpy fast in DynamicCameraOffset and DynamicFollow * add comment * higher corolla gas up to 40 mph * comment * revert manager changes * use LQR for corolla
weimou
pushed a commit
to SFtoLA/openpilot
that referenced
this issue
May 6, 2021
* improve comments on CarParams from manual * Update car.capnp Co-authored-by: qadmus <42746943+qadmus@users.noreply.github.com> Co-authored-by: Willem Melching <willem.melching@gmail.com>
mlocoteta
added a commit
to mlocoteta/openpilot
that referenced
this issue
Jul 17, 2023
* Add 2016/2017 Accord 2.4L (Serial Steering V3) * No longer used * bump opendbc * bump opendbc * bump opendbc * IDE * unused * small cleanup * platform rename * some more * add to docs * shorter name * add to FCR * update footnote * Update CARS.md * Update CARS.md * bump opendbc * Update footnote * Update CARS.md * Update CHANGELOGS.md --------- Co-authored-by: Jason Wen <haibin.wen3@gmail.com>
nworb-cire
pushed a commit
to opgm/openpilot
that referenced
this issue
Aug 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I'm looking at changes in 0.3.6, and my eyes hurt:
I need CarParams interface to have legible and descriptive names.
The text was updated successfully, but these errors were encountered: