adjustable car steering or steering not read straight #111
Comments
|
I'm seeing the same thing. I wish there was some sort of 'trim' function to tweak things slightly. |
|
Same problem here 16 civic, alignment is a bit out though, it likes to wobble back and forth laterally looking like drunk driving at speeds over 60. |
|
Same here, 2015 CRV. So far OpenPilot is a no-go until it can stay on the road. |
geohot
pushed a commit
that referenced
this issue
Jun 17, 2018
0dcd84d Toyota safety: integer division bug 9a268f3 Toyota Safety: cleaner var types 8638650 bump panda version 9ab6a56 gmlan recv test a1a2d97 gmlan test 8efa389 detect ack f5fab4b nicer err ad4d423 add gmlan fail count bb41ff7 test 998f7c0 oops, set recessive 80051be autoretry on chime 813218d GM: allowing higher brakes in Volt, so decel can reach between 3 and 3.5 m/s2 74ad3d6 GM: max param definitions 38a9ea9 added gm safety for steering (#123) bf5db45 Safety: made the driver steer check common so it can be shared across multiple safety files ef079e6 Safety: made rate limit check also common dc3cc24 Safety: made common the max torque check as well dbc3568 removing extra spaces 1966bdf Safety: made real time rate limit check a shared function e214477 use timer for can bitbanging cb92733 minor bitbang refactor ed2920c support extended addressing in canbitbang 36df0996 move speed be46c7a Merge pull request #122 from commaai/gmbitbang 7edc88e put that back fa66e4b Revert "handle rollover" 2ce3a26a handle rollover 223a1fb cleanin it up 1ba7907 that space tho d917386 bitbanging works 74af441 can crc 932d727 bit stuffing support be22522 bros ok match bros 55da0b6 rigol yea, dj pauly d yea a577583 working on gmbitbang 875c2bd3 Cadillac: block OP messages if OP is on 7caba24 Addition to Bosch safety to support Hatchback (#111) 63ca46b modify before we forward bf70f51 Safety: increase buffer for sampled signals. TBD a violation feedback from board to prevent car faults b0541a8 Cadillac: monitoring the 4 torque messages independently cd1dba9 Cadillac: fixed bug in regression safety ca0b6be Cadillac: fixed typo. Need better regression tests to catch this d9f1e61 Cadillac: simplified the ignition code by removing the timeout logic and resetting controls_allowed = 0 at each init 293fd1a GM: using real ignition logic. Creedit to Jamezz 8fa507b GM: simplified max steer check logic, Cadillac: fixed can parsing bug c7e2c2d Cadillac (#119) 83bcaa3 small logic cleanup (#118) 9d92bf2 Cadillac: need to specify car name in const 79ab5af Toyota: moved common functions into safety header file 40c8dda Cadillac ignition: simplified logic 69be556 Cadillac: better ignition logic d176220 Ignition: made a default hook for GPIO bea5187 Cadillac: added max steer safety dbc11a1 Cadillac: always controls allowed for now ace232a Cadillac: ignition bug e2c89d6 Cadillac: changed ignition logic to be based on can presence 528f901 Cadillac: simpler ignition logic 4e79ecf Cadillac: added safety file placeholder git-subtree-dir: panda git-subtree-split: 0dcd84d
DavidWAbrahams
pushed a commit
to jeankalud/openpilot
that referenced
this issue
Sep 26, 2018
Squashed commit of the following: commit 1391e0c Merge: 5b53cd4 a422246 Author: David Abrahams <you@example.com> Date: Wed Sep 26 04:52:42 2018 +0000 Merge remote-tracking branch 'op/devel' 0.5.4 into cruise_devel commit a422246 Author: Vehicle Researcher <user@comma.ai> Date: Tue Sep 25 00:13:41 2018 -0700 openpilot v0.5.4 release commit e5b2ec4 Merge: 97f1ee4 906b55a Author: Vehicle Researcher <user@comma.ai> Date: Tue Sep 25 00:04:00 2018 -0700 Merge opendbc subtree commit 906b55a Author: Vehicle Researcher <user@comma.ai> Date: Tue Sep 25 00:04:00 2018 -0700 Squashed 'opendbc/' changes from af7fff8..42f8c12 42f8c12 Adds Chinese Odyssey DBC (commaai#110) 7b87882 Syntax and encoding fixes (commaai#111) f85e646 Update mercedes e350 dbc (commaai#112) git-subtree-dir: opendbc git-subtree-split: 42f8c12 commit 97f1ee4 Merge: 2d450bc 5c0935d Author: Vehicle Researcher <user@comma.ai> Date: Tue Sep 25 00:03:58 2018 -0700 Merge panda subtree commit 5c0935d Author: Vehicle Researcher <user@comma.ai> Date: Tue Sep 25 00:03:58 2018 -0700 Squashed 'panda/' changes from f2292e4..5253ab0 5253ab0 bump panda 6277139 GM Volt: allowing 300 max steer 63b7926 Hyundai safety: temporarily disabled button spam check to avoid camera faults 53aef76 GM: passive on LKA-only cars (commaai#135) 01b5235 bumped panda version 1c0ffd1 Hyundai safety: simplifications 56794d6 Hyundai Safety Auto-Detect which CAN bus Camera is on (commaai#134) git-subtree-dir: panda git-subtree-split: 5253ab0 commit 2d450bc Author: Vasily Tarasov <vtarasov@zoneos.com> Date: Fri Sep 21 19:41:44 2018 -0700 Increase Volt's steering limit (commaai#351) * Increase Volt's steering limit * Merge panda subtree commit 96c9238 Author: Vasily Tarasov <vtarasov@zoneos.com> Date: Fri Sep 21 19:40:52 2018 -0700 GM refactor (commaai#374) commit 5b53cd4 Author: David Abrahams <you@example.com> Date: Fri Sep 21 03:17:44 2018 +0000 ACC: syntax fix commit d1d642e Author: David Abrahams <you@example.com> Date: Fri Sep 21 03:15:49 2018 +0000 ACC: Syntax fix commit f5d3e51 Author: David Abrahams <you@example.com> Date: Fri Sep 21 00:15:57 2018 +0000 ACC: If disabled, disengage traditional cruise control commit 5ad11b2 Author: David Abrahams <you@example.com> Date: Thu Sep 20 23:30:29 2018 +0000 ACC: disable on brakes or slowing below min speed commit 14b7ead Author: wocsor <37704329+wocsor@users.noreply.github.com> Date: Thu Sep 20 19:06:15 2018 -0400 Add XSE trim to fingerprints (commaai#372) commit 402faab Author: Ted Slesinski <ted@slesinski.org> Date: Wed Sep 19 20:59:18 2018 -0400 Docker environment breaking (commaai#369) * Fixes matplotlib dependency * Use version 2.1.2 commit d56e44b Author: David Abrahams <you@example.com> Date: Wed Sep 19 18:06:44 2018 +0000 ACC: Don't auto-engage if vRel < 0 commit d359f70 Author: David Abrahams <you@example.com> Date: Wed Sep 19 17:08:03 2018 +0000 ACC: Don't autoresume if there is a slow car in front commit de79a07 Author: Ted Slesinski <ted@slesinski.org> Date: Tue Sep 18 00:39:58 2018 -0400 Add support for accord hybrid (commaai#361) commit 4b2c137 Author: wocsor <37704329+wocsor@users.noreply.github.com> Date: Mon Sep 17 16:24:52 2018 -0400 update CHR fingerprint (commaai#364) CHR 2016 fingerprint has more messages
avolmensky
pushed a commit
to avolmensky/openpilot
that referenced
this issue
Jun 10, 2019
* Fix syntax error in Honda Civic Touring comment Add escaping to nested quotes in comment. * Convert caddilac_ct6_powertrain.dbc to UTF-8 Fixes decoding issue of the degrees rune. * Convert gm_global_a_powertrain.dbc to UTF-8 Fixes decoding issue of the degrees rune.
avolmensky
pushed a commit
to avolmensky/openpilot
that referenced
this issue
Jun 30, 2019
* Addition to Bosch safety to support Hatchback The computer brake is shown on 0x17c sensor on Accord and CR-V. We assumed all Bosch Hondas had the new 0x1be message which reports manual brake, but Civic Hatchback is not like this- It doesn't have this message and 0x17c works like the other Hondas so we are are passing a parameter from Openpilot for this. * Renamed variable * Make comment more descriptive * Added safety check for cancel-only spamming * Add regression test for brake on accord and crv Init with bosch safety variables Some more testing changes (still broken) Make second test work * Adds one more ttest * Cannot implicitly convert type 'int' to 'bool ' * ok to spam resume if controls_allowed==true * need to use current_controls_allowed. Still need to fix the message blocking * checking for bus 0 on button spam * better to use the car name in front of global vars * even better name and fixed safety tests
rafcabezas
pushed a commit
to rafcabezas/openpilot
that referenced
this issue
Oct 31, 2019
Avoid HSO will deactivate and try to take the car back into the lane during a manual lane change with blinker tapped (3 blinks mode)
SippieCup
pushed a commit
to SippieCup/openpilot
that referenced
this issue
Nov 14, 2019
* fix ALCA module * Update ALCA_module.py * Promote panda fixes from alpha to devel (commaai#98) * Fix for mock car crash * fix ALCA module * do not use * radar_interface logic improvements * remove radar logging * radar_interface refactoring * Log radar_interface CAN error, Process Comm Errors (commaai#95) * Log radar_interface CAN error * Add support for process comm error logging * Improve Process Comm error logging * Can and CommError throttling * Update radar_interface.py * fixing push per Raf's comments * ALCA and radar_interface work (commaai#96) (commaai#97) * do not use * radar_interface logic improvements * remove radar logging * radar_interface refactoring * Update radar_interface.py * fixing push per Raf's comments * fix process comm issue * switch radard from lane_parser to model * radar/ALCA changes * fix lane width * switched back to not deleting CarParams to avoid radar failure when rebooting EON while driving * cleanup some debug info to be able to restart ALCA research * tweaks on safety_tesla.h for can bus isolation * few more cleanups to safety_tesla.h * fix start signal logic * Increase LEXUS_IS safetyParam to 77 (commaai#841) * use list comprehension (commaai#839) * use list comprehension * oops index range fix * simplify encode/decode in dbc (commaai#840) * simplify encode/decode * 2019 Highlander Hybrid Limited Platinum (commaai#843) fingerprint from ogdragonzypher on Discord * Allow to lock safety mode to keep gm/tesla cars supported (commaai#844) * Force subaru to assume the stock camera is connected (commaai#849) * Revert to using the sum of the lane line probabilities instead of the the product * Add core OP support for CRC validation, with extra support for Volkswagen MQB (commaai#836) * Generalized core OP CRC support plus extra bits for Volkswagen MQB. * Update ref to process_replay regression test * Remove unneded use of replace, causing json to fail loading the alert * Add supported car for 2019 Toyota Altis Hybrid (commaai#859) * add supported car for 2019 Toyota Altis Hybird / Corolla hybrid 2020 (US market) * remove unnecessary comprehensions (commaai#863) * Added fingerprint from Sienna XLE AWD (commaai#848) * Added fingerprint from Sienna XLE AWD * Update driver_monitor.py * Update driver_monitor.py * Update driver_monitor.py * fix stupid merge issue * Adds 2019 Lexus ES (non hybrid) (commaai#866) * Adds 2019 Lexus ES (non hybrid) * Updated test route * merge issues * Update README with now supported Subaru Harness * Disable LDW for 4 seconds after blinker transition from on to off (commaai#112) If we want to change lanes with a blinker tap (3 blink mode), then we need to disable LDW for enough time to allow a smooth manual lane change. 4 seconds as it seems the freq is actually around 50Hz, not 100Hz. * Disable HSO for 3 seconds after blinker has been active (commaai#111) Avoid HSO will deactivate and try to take the car back into the lane during a manual lane change with blinker tapped (3 blinks mode) * params learner to only learn @ cons speed Acceleration/deceleration in turns affect yaw as measured by phone and will create potential issues with learner. This code changes the learner to only adjust parameters when speed is constant * Update to match new version of python in eons * python 3 fixes for test client / server * async/await server * Don't log for action message as it's too often, and we throttle it internally. * fix merge issue in thermald * fixes and tweaks; code simplification * Saving P,I,F parameters from pid controller (commaai#116) Added separate save/load functions, try catch - and saving the right constants to the params file. * Feature/tinklad throttling + linting (commaai#118) * Throttle tinlkad's attemptToSendPendingMessages * Remove get_git_remote from registration. It's defined in version already. * tinklad linting * tesla linting * Prevent multiple readings of the pid params file (commaai#119) ..only load the pid values when we initiate the LoC * missing V_PID_FILE constant (commaai#121) * show cars in IC for non-radar users (commaai#120) * bug fixes * Fix issue where user info was being dropped on no connectivity (commaai#122) * move pisParams, fix GPS logging * Bugfix tinklad throttling (commaai#124) * ALCA4 (still in dev) * ALCA4 tuning * ALCA4 alpha release * ALCA4 tweak for turns * ACC fix; LDW mite during ALCA * ALCA polishing * fix enter_canloader.py for python 3 * should_ldw changes moved the should_ldw code closer together and added status messages for when LDW is active and inactive * thermald and ALCA * ALCA sinplified logic
weimou
pushed a commit
to SFtoLA/openpilot
that referenced
this issue
May 6, 2021
* add managerState * add alert
carleeno
pushed a commit
to carleeno/openpilot
that referenced
this issue
Aug 2, 2024
* exclude third_party/mapd/ from gitignore * all mapd dependencies * exclude more * more dependencies! * add to files_common
carleeno
pushed a commit
to carleeno/openpilot
that referenced
this issue
Aug 2, 2024
This reverts commit 0035126.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
How do adjust actually car steering alignment reading? the blue one is off from straight in the road, it causes the steering to over correct too much and veer off road.
I guess it could be my car alignment maybe off a little ? but I'm still checking. The steering when straight on most road see to read more left on the neos.
What value can adjust the steering reading from car? or does it read straight from dbc? then I just need to add offset?
what value does the machine learning to read and adjust steering to be small smooth instead of side to side adjustment steering when it drive straight, how can I improve it to be smoother?
The text was updated successfully, but these errors were encountered: