Update OpenPilot UI - add skins #119
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merge with v0.3.3
…s via /data/params/d/UISkin setting
Merge from commaai/openpilot:devel
…into update-ui-v3
…into update-ui-v3
|
The 7 million png files scare me. Can you tar them up or something and pull from the tarball in ui when you need access? (speed_assets.tar is much less scary) |
|
Hmm... I'm not sure how to do that (read contents of the tar into memory) in C. I tried "slicing" a single image into pieces (using it like an image map) using nvgImagePattern, but that doesn't work because when you draw the sliced image the position of the slice is still relative to where it's located on the image map so I couldn't position it in the right place. |
|
@geohot Would it be acceptable to untar the files into temp storage (i.e. /data/local/tmp), read the files into memory, then delete them from temp storage? |
Merge with 0.3.4
…into update-ui-v3
openpilot v0.3.5 release
…into update-ui-v3
|
Figured out how to extract from tar.gz file so you don't have the gazillion PNG files anymore. |
…eloads the PNGs because the UIScene is re-initialized so the PNGs are taken out of UIScene struct
openpilot v0.3.6 tweaks
openpilot v0.3.6.1 release
Revert "openpilot v0.3.6.1 release"
|
RTBC? |
|
Not sure what RTBC means. If you're asking why I reverted it's because when I merged the 3.6.1 code from commaai/devel the CI test didn't pass. |
|
ready to be committed? |
|
I've been using this on mine, a major improvement. Did you look into trying to ease the slide-in transition vs the linear animation transition as it is currently? |
|
I played around with easing but it didn't look that great, not sure if it's a framerate limit or what and yes, unless there's reports of other issues, this is ready to merge. |
|
Another bug i found was that KPH seems to stay on screen when in metric |
|
When does it stay on screen? When openpilot is off and it slides the circles out? |
|
Yes, lmk if you see it, I only turned kph on once by accident, I'll check next ride i do to see if it is consistent |
added 2 commits
August 19, 2017 15:38
|
The KPH issue should be fixed now. |
geohot
pushed a commit
that referenced
this pull request
Jun 17, 2018
0dcd84d Toyota safety: integer division bug 9a268f3 Toyota Safety: cleaner var types 8638650 bump panda version 9ab6a56 gmlan recv test a1a2d97 gmlan test 8efa389 detect ack f5fab4b nicer err ad4d423 add gmlan fail count bb41ff7 test 998f7c0 oops, set recessive 80051be autoretry on chime 813218d GM: allowing higher brakes in Volt, so decel can reach between 3 and 3.5 m/s2 74ad3d6 GM: max param definitions 38a9ea9 added gm safety for steering (#123) bf5db45 Safety: made the driver steer check common so it can be shared across multiple safety files ef079e6 Safety: made rate limit check also common dc3cc24 Safety: made common the max torque check as well dbc3568 removing extra spaces 1966bdf Safety: made real time rate limit check a shared function e214477 use timer for can bitbanging cb92733 minor bitbang refactor ed2920c support extended addressing in canbitbang 36df0996 move speed be46c7a Merge pull request #122 from commaai/gmbitbang 7edc88e put that back fa66e4b Revert "handle rollover" 2ce3a26a handle rollover 223a1fb cleanin it up 1ba7907 that space tho d917386 bitbanging works 74af441 can crc 932d727 bit stuffing support be22522 bros ok match bros 55da0b6 rigol yea, dj pauly d yea a577583 working on gmbitbang 875c2bd3 Cadillac: block OP messages if OP is on 7caba24 Addition to Bosch safety to support Hatchback (#111) 63ca46b modify before we forward bf70f51 Safety: increase buffer for sampled signals. TBD a violation feedback from board to prevent car faults b0541a8 Cadillac: monitoring the 4 torque messages independently cd1dba9 Cadillac: fixed bug in regression safety ca0b6be Cadillac: fixed typo. Need better regression tests to catch this d9f1e61 Cadillac: simplified the ignition code by removing the timeout logic and resetting controls_allowed = 0 at each init 293fd1a GM: using real ignition logic. Creedit to Jamezz 8fa507b GM: simplified max steer check logic, Cadillac: fixed can parsing bug c7e2c2d Cadillac (#119) 83bcaa3 small logic cleanup (#118) 9d92bf2 Cadillac: need to specify car name in const 79ab5af Toyota: moved common functions into safety header file 40c8dda Cadillac ignition: simplified logic 69be556 Cadillac: better ignition logic d176220 Ignition: made a default hook for GPIO bea5187 Cadillac: added max steer safety dbc11a1 Cadillac: always controls allowed for now ace232a Cadillac: ignition bug e2c89d6 Cadillac: changed ignition logic to be based on can presence 528f901 Cadillac: simpler ignition logic 4e79ecf Cadillac: added safety file placeholder git-subtree-dir: panda git-subtree-split: 0dcd84d
Gernby
pushed a commit
to Gernby/openpilot
that referenced
this pull request
Mar 6, 2019
…i#119) * Additional JSON parameters + Thermald changes * Add JSON parameters and apply to thermald.py * "carVoltageMinEonShutdown":"11800" * Switch all k.conf to kegman.conf * Moar corrections for kegman.conf stuff * Fix sync problems - uncomment controlsd lag messages * Relax min / max battery charge limits * Revert "Merge remote-tracking branch 'gernby/resonant-mpc-interp-059' into kegman" This reverts commit ccf6ec75089d6cf9d8a32f01677be744dd8fb7b5, reversing changes made to b6c2009a61ffa87b00f91d2ca5847faac1671df2.
mespiritu
pushed a commit
to mespiritu/openpilot
that referenced
this pull request
Apr 1, 2019
Update to latest release2
avolmensky
pushed a commit
to avolmensky/openpilot
that referenced
this pull request
Jun 30, 2019
* added some steer safety to Cadillac * bug fixes * added cadillac full steering safety. To be tested * RT checks and max checks working. Need to test driver torque based limits * cadillac steer safety should be done * unneded lines
rafcabezas
pushed a commit
to rafcabezas/openpilot
that referenced
this pull request
Nov 7, 2019
..only load the pid values when we initiate the LoC
SippieCup
pushed a commit
to SippieCup/openpilot
that referenced
this pull request
Nov 14, 2019
* fix ALCA module * Update ALCA_module.py * Promote panda fixes from alpha to devel (commaai#98) * Fix for mock car crash * fix ALCA module * do not use * radar_interface logic improvements * remove radar logging * radar_interface refactoring * Log radar_interface CAN error, Process Comm Errors (commaai#95) * Log radar_interface CAN error * Add support for process comm error logging * Improve Process Comm error logging * Can and CommError throttling * Update radar_interface.py * fixing push per Raf's comments * ALCA and radar_interface work (commaai#96) (commaai#97) * do not use * radar_interface logic improvements * remove radar logging * radar_interface refactoring * Update radar_interface.py * fixing push per Raf's comments * fix process comm issue * switch radard from lane_parser to model * radar/ALCA changes * fix lane width * switched back to not deleting CarParams to avoid radar failure when rebooting EON while driving * cleanup some debug info to be able to restart ALCA research * tweaks on safety_tesla.h for can bus isolation * few more cleanups to safety_tesla.h * fix start signal logic * Increase LEXUS_IS safetyParam to 77 (commaai#841) * use list comprehension (commaai#839) * use list comprehension * oops index range fix * simplify encode/decode in dbc (commaai#840) * simplify encode/decode * 2019 Highlander Hybrid Limited Platinum (commaai#843) fingerprint from ogdragonzypher on Discord * Allow to lock safety mode to keep gm/tesla cars supported (commaai#844) * Force subaru to assume the stock camera is connected (commaai#849) * Revert to using the sum of the lane line probabilities instead of the the product * Add core OP support for CRC validation, with extra support for Volkswagen MQB (commaai#836) * Generalized core OP CRC support plus extra bits for Volkswagen MQB. * Update ref to process_replay regression test * Remove unneded use of replace, causing json to fail loading the alert * Add supported car for 2019 Toyota Altis Hybrid (commaai#859) * add supported car for 2019 Toyota Altis Hybird / Corolla hybrid 2020 (US market) * remove unnecessary comprehensions (commaai#863) * Added fingerprint from Sienna XLE AWD (commaai#848) * Added fingerprint from Sienna XLE AWD * Update driver_monitor.py * Update driver_monitor.py * Update driver_monitor.py * fix stupid merge issue * Adds 2019 Lexus ES (non hybrid) (commaai#866) * Adds 2019 Lexus ES (non hybrid) * Updated test route * merge issues * Update README with now supported Subaru Harness * Disable LDW for 4 seconds after blinker transition from on to off (commaai#112) If we want to change lanes with a blinker tap (3 blink mode), then we need to disable LDW for enough time to allow a smooth manual lane change. 4 seconds as it seems the freq is actually around 50Hz, not 100Hz. * Disable HSO for 3 seconds after blinker has been active (commaai#111) Avoid HSO will deactivate and try to take the car back into the lane during a manual lane change with blinker tapped (3 blinks mode) * params learner to only learn @ cons speed Acceleration/deceleration in turns affect yaw as measured by phone and will create potential issues with learner. This code changes the learner to only adjust parameters when speed is constant * Update to match new version of python in eons * python 3 fixes for test client / server * async/await server * Don't log for action message as it's too often, and we throttle it internally. * fix merge issue in thermald * fixes and tweaks; code simplification * Saving P,I,F parameters from pid controller (commaai#116) Added separate save/load functions, try catch - and saving the right constants to the params file. * Feature/tinklad throttling + linting (commaai#118) * Throttle tinlkad's attemptToSendPendingMessages * Remove get_git_remote from registration. It's defined in version already. * tinklad linting * tesla linting * Prevent multiple readings of the pid params file (commaai#119) ..only load the pid values when we initiate the LoC * missing V_PID_FILE constant (commaai#121) * show cars in IC for non-radar users (commaai#120) * bug fixes * Fix issue where user info was being dropped on no connectivity (commaai#122) * move pisParams, fix GPS logging * Bugfix tinklad throttling (commaai#124) * ALCA4 (still in dev) * ALCA4 tuning * ALCA4 alpha release * ALCA4 tweak for turns * ACC fix; LDW mite during ALCA * ALCA polishing * fix enter_canloader.py for python 3 * should_ldw changes moved the should_ldw code closer together and added status messages for when LDW is active and inactive * thermald and ALCA * ALCA sinplified logic
stereosix
pushed a commit
to stereosix/openpilot
that referenced
this pull request
Jul 14, 2020
* find oncoming lanes and send to laneSpeed service * dynamically change camera offset based on oncoming adjacent lanes * change camera offset offset * Test higher offset * Allow slower * fix for adding tracks to oncoming at high speeds * lane line prob needs to be at least 70% in the direction we're going to hug * use lane width certainty to get cur lane width and calculate how much to offset * add readme bullet for LS dynamic camera offset * move dynamic gas down * show alerts when keeping left or right for oncoming traffic * if lane width uncertain, apply less overall offset * test all * revert * Fix missing attribute * Debug dynamic camera offset * Min tolerance * Will this work? * move speed check into function * tidying up * fix alert text * enable at 40 for testing * log data for debug * print * fix alert showing when going below min speed while a lane is fastest * add temp debugging file * clean up * more offset * Update README.md * Update README.md * see if this helps with slow overshoot * allow higher accel for long derivative * enable down to 25 mph * thanks kumar! * test git pull * test git pull * use 200 as max steer rate * down to 20 just for testing * add tuner for steer fault timer * change min_poly_prob based on speed, disable path offsetting * don't change cost as much under 20 mph, fix speeds for dynamic lane speed * cut torque when moving to center * max cost mod 6 * disable dyn cam off, change back lanespeed min speed * revert pid change
weimou
pushed a commit
to SFtoLA/openpilot
that referenced
this pull request
May 6, 2021
* update freqs for tici and cleanup * eon dm is 10hz
SeanCox
pushed a commit
to SeanCox/openpilot
that referenced
this pull request
Mar 9, 2023
Pre-Global Subaru: counter fix and remove dashcam only * Revert legacy es_lkas counter autogeneration
garrettpall
pushed a commit
to garrettpall/openpilot
that referenced
this pull request
Apr 13, 2024
Round SLC for Initial Set
nworb-cire
referenced
this pull request
in opgm/openpilot
Aug 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Preserves current UI (set as default) but can switch between UIs by setting value in /data/params/d/UISkin (set to 1 for default, 2 for new skin - uses default skin if file doesn't exist). This can be added to baseui for users to choose a skin if this functionality is desired.
New UI looks like this: https://www.youtube.com/watch?v=BSBcZIh9U7k