Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add linuxcan to NEOS kernel #20

Closed
4 tasks
ingenieroariel opened this issue Dec 6, 2016 · 3 comments
Closed
4 tasks

Add linuxcan to NEOS kernel #20

ingenieroariel opened this issue Dec 6, 2016 · 3 comments

Comments

@ingenieroariel
Copy link

ingenieroariel commented Dec 6, 2016

Being able to access SocketCAN from the phone would make it possible to connect a KVASER adapter or any other CAN adapter with linux support on the linux kernel over USB.

  • can
  • can_dev
  • can_raw
  • kvsaser_usb

It would also help during reverse engineering as the candump output can be relied back to the computer during debugging.

@paramaggarwal
Copy link

paramaggarwal commented Dec 12, 2016

Very novice comment here - but I think the way it goes via an intermediary right now isolates it from software failures on the phone as well as places reasonable limits on what the phone asks the CAN bus to do. Hence connecting directly to CAN over USB via a transceiver would basically hand over the controls of the car to the phone - exposing it to typical Android vulnerabilities.

@geohot
Copy link
Contributor

geohot commented Dec 12, 2016

Yea, the board adds one layer of safety redundancy, and that's one of the reasons we built our own, although you can achieve very similar things in software. The comma zero used off the shelf CAN transceivers safely by adding the safety checks to the drivers.

@ingenieroariel
Copy link
Author

Even if the support was added, we would need Python 3 on the OP3 to be able to connect to the socket (socket can did not work for me on 2.7).

Also, since the NEOS kernel is not on this repo but a new github repo I'll close this.

tylergets pushed a commit to tylergets/openpilot that referenced this issue Oct 12, 2018
ErichMoraga referenced this issue in ErichMoraga/openpilot Oct 16, 2018
Only show lock button when we're recording
emmertex referenced this issue in emmertex/openpilot Dec 15, 2018
Add angular acceleration and rate to Tesla's lateral control
mespiritu pushed a commit to mespiritu/openpilot that referenced this issue Apr 1, 2019
xx979xx referenced this issue in xx979xx/openpilot Dec 7, 2019
pd0wm pushed a commit that referenced this issue Jan 15, 2020
01942b8 add TODO
b74a456 don't hardcode the lists
ed5a4bf add face stds
396a2bb add can error counter to controlsState
c6b5c73 Switch default to msgq (#21)
a457ffa Fix indentation in readme.md
a1fc8c7 explicitly mention Python for syntax colouring (#20)
19e2393 Fix expected for cameraOdometry and liveCalibration
e7d2f97 Add radar comm issue error
db64cd4 Reserve safety #21 for VAG PQ35/PQ46/NMS (#19)
79d638d separate honda safety models between Bosch Giraffe and Bosch Nidec
2614a65 better name
b6b84cd add longitudinal
78f5934 Add canRxErrs to health
6758899 qlog liveCalibration
df80b87 add more stuff to fw log in CarParams
a87805a fix doxs
4746b20 got doxed
21cf3f5 build on mac
31ac47c Add carUnrecognized event

git-subtree-dir: cereal
git-subtree-split: 01942b8
ntstrub added a commit to ntstrub/openpilot that referenced this issue Jan 25, 2020
* Squashed 'cereal/' changes from b8382bb..01942b8

01942b8 add TODO
b74a456 don't hardcode the lists
ed5a4bf add face stds
396a2bb add can error counter to controlsState
c6b5c73 Switch default to msgq (commaai#21)
a457ffa Fix indentation in readme.md
a1fc8c7 explicitly mention Python for syntax colouring (commaai#20)
19e2393 Fix expected for cameraOdometry and liveCalibration
e7d2f97 Add radar comm issue error
db64cd4 Reserve safety commaai#21 for VAG PQ35/PQ46/NMS (commaai#19)
79d638d separate honda safety models between Bosch Giraffe and Bosch Nidec
2614a65 better name
b6b84cd add longitudinal
78f5934 Add canRxErrs to health
6758899 qlog liveCalibration
df80b87 add more stuff to fw log in CarParams
a87805a fix doxs
4746b20 got doxed
21cf3f5 build on mac
31ac47c Add carUnrecognized event

git-subtree-dir: cereal
git-subtree-split: 01942b8

* Remove old panda subtree

* Squashed 'panda/' content from commit 3b35621

git-subtree-dir: panda
git-subtree-split: 3b35621

* Squashed 'opendbc/' changes from 4f82d01e..5081966f

5081966f One more fix
fa5dc680 Fix honda dbc files after steer torque addition
e4dfb2fa update honda steering signals (commaai#208)
53fc4487 added generator test (commaai#207)
cb27d6e3 Honda Nidec: add new ACC_HUD signals to all other cars other than the CIVIC
6e6779f9 build on mac AND linux, also gotta not use these python files
79dbfc1a build on mac

git-subtree-dir: opendbc
git-subtree-split: 5081966f106e4ed385d756220cfd3dc502e737d9

* openpilot v0.7.1 release

* registration: send up both imeis

* hotfix panda#426

* Panda signature needs to be bytes

* update offroad apk: fix pairing

* apk lib: Grant offroad access to TelephonyManager

* update frame apk

* catch exception in uploader.py

* update common/android.py

* update athenad.py

Co-authored-by: Willem Melching <willem.melching@gmail.com>
Co-authored-by: Andy <andyh2@me.com>
JMPZ11 referenced this issue in JMPZ11/openpilot Sep 29, 2020
bd9a877 pulse desire and e2e
20c7fd6 Add subaru pre-Global safety mode
522ff85 Merge pull request commaai#31 from commaai/good_location_packet
ab07f22 deprecate
b03c2c5 already exists
166418c0 improvements
97373f9 or rigor in american
365abba rigour
25eaf9d add espDisabled to carState (#30)
bb13121 add honda ecus (#29)
eba4349 put liveLocation in qlogs
6c4735f add fixed fingerprintSource
4c50d26 GitHub actions (#25)
988783f Merge pull request #28 from commaai/power_monitoring
b43fd06 Added offroad power usage
ab32956 Merge pull request #27 from commaai/ublox-hw-status
2e7f4b9 Added ublox hw status
23abef4 add networkType to thermal
3f01dcf fix bad naming
4999e62 unconfusing and accessible to all
8f9aa8f add fingerprintSource to carParams
5794030 better put
06f8d15 standalone monitorstate (#23)
6eb1e36 qlog at model rate
c38fb57 LateralParams
0c45f20 add uncertainty event name
01942b8 add TODO
b74a456 don't hardcode the lists
ed5a4bf add face stds
396a2bb add can error counter to controlsState
c6b5c73 Switch default to msgq (#21)
a457ffa Fix indentation in readme.md
a1fc8c7 explicitly mention Python for syntax colouring (#20)
19e2393 Fix expected for cameraOdometry and liveCalibration
e7d2f97 Add radar comm issue error
db64cd4 Reserve safety #21 for VAG PQ35/PQ46/NMS (#19)
79d638d separate honda safety models between Bosch Giraffe and Bosch Nidec
2614a65 better name
b6b84cd add longitudinal
78f5934 Add canRxErrs to health
6758899 qlog liveCalibration
df80b87 add more stuff to fw log in CarParams
a87805a fix doxs
4746b20 got doxed
21cf3f5 build on mac
31ac47c Add carUnrecognized event
b8382bb steerLimitTimer should be car dependent
9a22968 add pa0 temp to ThermalData
f6f0f60 Add stock Fcw to carState
b608683 no l/r distinction for LDW
555f48d Add ldw alert
8e8b4a4 Remove plusFrame socket in favor of UiLayoutState
3410325 log stock AEB events
2219f2b Add warning about not using cython version of sec_since_boot
8f1a512 for legacy-testing reasons, better to define the used percent instead of avail
e86d954 adding low memory event
ad23834 remove TODO
d0962b3 log mem available and cpu perc in thermald
3b753be Implement error handling and exceptions (#18)
a7d5bb7 add explicit dependencies on services.h
1ba6467 fix linter
c7d215b Added communityFeatureDisallowed event
492140a Added communityFeature bit detection to CarParams
266a5fe log Panda fault types
347a866 Switch from polling on FIFOs to signal (#12)
e25bba7 no need to double build the objects
fe43a99 20Hz for radar time step is very standard
2aabf1e Added radar time step to car params
e8ae908 Generate capnp for java
57126a2 cereal_shared
da655cd Add uptime to health
f6a8e39 add test with multiple subscribers
84b3af5 comment out the debugging
4b9c942 added power save state to health packet
66be370 run python unittest in ci
52c6db8 Run scons in CI (#14)
9414615 do need it, but only for arm
2856c37 remove gnustl_shared
7f05ee6 fix apks
e3a6bde Revert "no more makefiles"
487fbd0 don't rely on BASEDIR, and add zmq library
223e37a no more makefiles
da2ed11 don't link the wrong one
fe9fe2a scons builds the python lib now
2f81135 err, it can't build services.h
57b03f8 now we shouldn't need that yaml crap everywhere
f8e5327 bridge builds with services.h
2b0cb60 noOutput safety mode is now called silent
83880d5 add msgq tests
bcad184 msgq: dont block when fifo does not exists
b4b26782 Default to zmq
473e291 fix compilation in docker
30aaadd msgq: try again when no timeout on poll but also no message
c4f2ad5 msgq: make sure read_fifos is initalized so we dont close random fds
4e513a85 msgq: dont clean up uninitialized sockerts
c008b63 also remove the fifo from disk
ef64eb2 MSGQ stability improvements when opening and closing lots of queues
e147abc Revert "Revert "deprecate irpwr""
932dc32 Revert "deprecate irpwr"
a684415 disengage
ec27e18 capnpc also generated the header files
ee52ab9 deprecate irpwr
301c74c8 Merge branch 'master' of github.com:commaai/cereal
6da7d55 add front frame
a5944eb add conflate parameter for SubSocket::create
ca8df17 Add fault status to health
ef4ded0 add conflate support in SubSocket constructor
7fd314a update scons build file
93d814e add saturated flags to indi and lqr logs
50302fe add steeringRateLimited to car.capnp
05e3513 add msgq readme
a6759a9 faster make
94b7377 Add struct to log FW version
64ce0b5 add scons build
dc9ad18 add debug print statement on SIGINT
4a61269 Merge pull request #10 from commaai/msgq
4873449 use recv one or none after poll
a054864 default to msgq
fbc4a4c oops bad number
5067cf4 add meta
cbd0286 fix export prefix and make shared library world readable
c273054 add c exports for jni usage
e77f41e zmq already sets the errno correctly
3196cf6 Fix service list path in bridge
d35515a add all msgq files, but dont use as default
a68a38f Don't delete context from python side only
bd46c22 Revert "zmq_ctx_term is blocking"
a1fc26b zmq_ctx_term is blocking
0902182 remote address support
21a3536 only delete subsocket when created by same object
34df735 remove extra underscore from __dealloc__
c8748f8 fix internal refs
79b2fbf fixups
23ad256 import messaging and services

git-subtree-dir: cereal
git-subtree-split: bd9a877
JMPZ11 referenced this issue in JMPZ11/openpilot Oct 11, 2020
bd9a877 pulse desire and e2e
20c7fd6 Add subaru pre-Global safety mode
522ff85 Merge pull request commaai#31 from commaai/good_location_packet
ab07f22 deprecate
b03c2c5 already exists
166418c improvements
97373f9 or rigor in american
365abba rigour
25eaf9d add espDisabled to carState (#30)
bb13121 add honda ecus (#29)
eba4349 put liveLocation in qlogs
6c4735f add fixed fingerprintSource
4c50d26 GitHub actions (#25)
988783f Merge pull request #28 from commaai/power_monitoring
b43fd06 Added offroad power usage
ab32956 Merge pull request #27 from commaai/ublox-hw-status
2e7f4b9 Added ublox hw status
23abef4 add networkType to thermal
3f01dcf fix bad naming
4999e62 unconfusing and accessible to all
8f9aa8f add fingerprintSource to carParams
5794030 better put
06f8d15 standalone monitorstate (#23)
6eb1e36 qlog at model rate
c38fb57 LateralParams
0c45f20 add uncertainty event name
01942b8 add TODO
b74a456 don't hardcode the lists
ed5a4bf add face stds
396a2bb add can error counter to controlsState
c6b5c73 Switch default to msgq (#21)
a457ffa Fix indentation in readme.md
a1fc8c7 explicitly mention Python for syntax colouring (#20)
19e2393 Fix expected for cameraOdometry and liveCalibration
e7d2f97 Add radar comm issue error
db64cd4 Reserve safety #21 for VAG PQ35/PQ46/NMS (#19)
79d638d separate honda safety models between Bosch Giraffe and Bosch Nidec
2614a65 better name
b6b84cd add longitudinal
78f5934 Add canRxErrs to health
6758899 qlog liveCalibration
df80b87 add more stuff to fw log in CarParams
a87805a fix doxs
4746b20 got doxed
21cf3f5 build on mac
31ac47c Add carUnrecognized event
b8382bb steerLimitTimer should be car dependent
9a22968 add pa0 temp to ThermalData
f6f0f60 Add stock Fcw to carState
b608683 no l/r distinction for LDW
555f48d Add ldw alert
8e8b4a4 Remove plusFrame socket in favor of UiLayoutState
3410325 log stock AEB events
2219f2b Add warning about not using cython version of sec_since_boot
8f1a512 for legacy-testing reasons, better to define the used percent instead of avail
e86d954 adding low memory event
ad23834 remove TODO
d0962b3 log mem available and cpu perc in thermald
3b753be Implement error handling and exceptions (#18)
a7d5bb7 add explicit dependencies on services.h
1ba6467 fix linter
c7d215b Added communityFeatureDisallowed event
492140a Added communityFeature bit detection to CarParams
266a5fe log Panda fault types
347a866 Switch from polling on FIFOs to signal (#12)
e25bba7 no need to double build the objects
fe43a99 20Hz for radar time step is very standard
2aabf1e Added radar time step to car params
e8ae908 Generate capnp for java
57126a2 cereal_shared
da655cd Add uptime to health
f6a8e39 add test with multiple subscribers
84b3af5 comment out the debugging
4b9c942 added power save state to health packet
66be370 run python unittest in ci
52c6db8 Run scons in CI (#14)
9414615 do need it, but only for arm
2856c37 remove gnustl_shared
7f05ee6 fix apks
e3a6bde Revert "no more makefiles"
487fbd0 don't rely on BASEDIR, and add zmq library
223e37a no more makefiles
da2ed11 don't link the wrong one
fe9fe2a scons builds the python lib now
2f81135 err, it can't build services.h
57b03f8 now we shouldn't need that yaml crap everywhere
f8e5327 bridge builds with services.h
2b0cb60 noOutput safety mode is now called silent
83880d5 add msgq tests
bcad184 msgq: dont block when fifo does not exists
b4b2678 Default to zmq
473e291 fix compilation in docker
30aaadd msgq: try again when no timeout on poll but also no message
c4f2ad5 msgq: make sure read_fifos is initalized so we dont close random fds
4e513a8 msgq: dont clean up uninitialized sockerts
c008b63 also remove the fifo from disk
ef64eb2 MSGQ stability improvements when opening and closing lots of queues
e147abc Revert "Revert "deprecate irpwr""
932dc32 Revert "deprecate irpwr"
a684415 disengage
ec27e18 capnpc also generated the header files
ee52ab9 deprecate irpwr
301c74c Merge branch 'master' of github.com:commaai/cereal
6da7d55 add front frame
a5944eb add conflate parameter for SubSocket::create
ca8df17 Add fault status to health
ef4ded0 add conflate support in SubSocket constructor
7fd314a update scons build file
93d814e add saturated flags to indi and lqr logs
50302fe add steeringRateLimited to car.capnp
05e3513 add msgq readme
a6759a9 faster make
94b7377 Add struct to log FW version
64ce0b5 add scons build
dc9ad18 add debug print statement on SIGINT
4a61269 Merge pull request #10 from commaai/msgq
4873449 use recv one or none after poll
a054864 default to msgq
fbc4a4c oops bad number
5067cf4 add meta
cbd0286 fix export prefix and make shared library world readable
c273054 add c exports for jni usage
e77f41e zmq already sets the errno correctly
3196cf6 Fix service list path in bridge
d35515a add all msgq files, but dont use as default
a68a38f Don't delete context from python side only
bd46c22 Revert "zmq_ctx_term is blocking"
a1fc26b zmq_ctx_term is blocking
0902182 remote address support
21a3536 only delete subsocket when created by same object
34df735 remove extra underscore from __dealloc__
c8748f8 fix internal refs
79b2fbf fixups
23ad256 import messaging and services

git-subtree-dir: cereal
git-subtree-split: bd9a877
weimou pushed a commit to SFtoLA/openpilot that referenced this issue May 6, 2021
incognitojam pushed a commit to incognitojam/openpilot that referenced this issue Nov 9, 2021
Rebase to 0.8.3 phoenix v1.1

rebase ok.
carleeno pushed a commit to carleeno/openpilot that referenced this issue Aug 2, 2024
* sunnypilot ui init

* ui controls init

* comment out for now

* use ListWidget instead moving forward

* wrap for translation

* quick test

* need this

* good to go, no need for now

* start with some

* some html

* that didn't work

* fill up General first

* add mads options

* add mads options 2

* add mads options 3

* add mads options 4

* add mads options 5

* add mads options 6

* add mads options 7

* add mads options 8

* add mads options 9

* add mads options 10

* add mads options 11

* add mads options 12

* add mads options 13

* add mads options 14

* add mads options 15

* add mads options 16

* add mads options 17

* add mads options 18

* add mads options 19

* add mads options 20

* add mads options 21

* add mads options 22

* add mads options 22

* add dlp

* add dlp

* add dlp

* finish up controls panel

* QWidget has no refresh()

* fix this tr() later

* flipped and redundant deleted

* missing icons

* Bolding

* Revert "Revert "Don't delete params""

This reverts commit 7adfc172d599da0e450669a203f5cdb17a32a9d6.

* Revert "Revert "Revert "Don't delete params"""

This reverts commit 33f28677f1a69fb18c7d1a08c5f02a497005dfbe.

* Revert "Revert "don't forget this""

This reverts commit f4485920ed5318e4662e4955a699febb9ba27159.

* Revert "Revert "fill up sp - vehicles""

This reverts commit dfab593833ca5a9cb26fb89f36bf7ac19f7432bf.

* Revert "Revert "missed this""

This reverts commit bf4ac0289b164ca59cb49c355fa8a5303c66b016.

* Revert "Revert "missed that""

This reverts commit da81b7f9eb4e7bbafced4a7a31cb4b7a078d2277.

* Revert "Revert "missed these""

This reverts commit 742908dcf5220a93da57a54836b2b890bbbd519a.

* Revert "Revert "nicer info?""

This reverts commit e0d6c1c05da394774ad0a7ee0b5c5e5c7f55c08a.

* Revert "Revert "fill up sp visuals""

This reverts commit 35759838e0ba4a36f36a12ff1001846b32ddd0c7.

* Revert "Revert "don't miss these""

This reverts commit 7f093380b470a7c195d1f6795b76393b72d4e2f7.

* Revert "Revert "Revert "ui controls init"""

This reverts commit 67c531487e9501ca5658297a20061b88f91c10cc.

* Revert "Revert "move stuff around""

This reverts commit 03b72af6d01772b18c506f590e92b6dbc95c2bfc.

* change to sunnypilot

* update texts

* fix

* does this work?

* Revert "does this work?"

This reverts commit 7b3caf3677593550065efe553334d0797dc5ea00.

* try this out

* add some back

* arrange around

* maybe less I/O

* missing a space

* Translate these too

* unfinished translations

* try this out

* easier translation

* refresh unfinished translations

* update menu texts with Chinese S and T!

* missed this translation

* more unfinished translations
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants