Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Openpilot "Resume" from Disengaged->Engaged like Stock ACC #229

Closed
Jamezz opened this issue Mar 30, 2018 · 3 comments
Closed

Openpilot "Resume" from Disengaged->Engaged like Stock ACC #229

Jamezz opened this issue Mar 30, 2018 · 3 comments

Comments

@Jamezz
Copy link

Jamezz commented Mar 30, 2018

(Planned on implementing this myself, but wanted to get feedback if there was a specific reason why this wasn't done)

In some of the stock (2017 Volt) ACC systems, pressing the Resume button engages the ACC back to the originally set maximum cruise speed instead of overwriting it with the current vehicle speed.

Would be great to have OP do the same thing so drivers didn't have to readjust the speed every time OP needs to be re-engaged.
@geohot
Copy link
Contributor

geohot commented Mar 30, 2018

That doesn't work? What car?

@Jamezz
Copy link
Author

Jamezz commented Mar 31, 2018

This is an issue with the 2017 Volt port. Code inspection led me to believe that this was intended in OP (accelCruise/decelCruise event resets speed if OP state transitions from Disengaged->Engaged), but your reply seems to imply otherwise. Maybe this might just be a bug downstream in the volt port?

@Jamezz Jamezz changed the title Openpilot "Resume" like Stock ACC Openpilot "Resume" from Disengaged->Engaged like Stock ACC Mar 31, 2018
@Jamezz
Copy link
Author

Jamezz commented Jul 22, 2018

Fixed in 0.5! Resume to previously set speed is so nice...

@Jamezz Jamezz closed this as completed Jul 22, 2018
avolmensky pushed a commit to avolmensky/openpilot that referenced this issue Jun 30, 2019
@rbiasini
Fix all 16_4 violations (commaai#229)
abd841e
pd0wm pushed a commit that referenced this issue Mar 6, 2020
Squashed 'opendbc/' changes from 2ae0327e..d1f76d60
32066d2 
d1f76d60 Add Motor_20 CRC support (#229)
6252718a Add STEER_ANGLE to all STEER_TORUQE_SENSOR messages (#228)
c0b42612 Revert "add angle field in torque sensor message to all cars (#227)"
bd82848c add angle field in torque sensor message to all cars (#227)
56f0259d Lexus CTH fix: brake pressed is on bit 5 like corolla and rav4
9b6ca31b fix: Replicate changes done on _honda_2017.dbc (#225)
1bd26d0a Added messages. Cleaned up endianness (#226)
44b9e74f Revert "Toyota: add checksum to BRAKE_MODULE (#224)"
8b18c92e Toyota: add checksum to BRAKE_MODULE (#224)
2bab4d6d Add Honda-Bosch lane line detection signals. (#223)
a1aa3b78 Cleanup of Nissan DBC (#218)
c1f76482 reverting changes to Chrysler: speed message seems different from car to car
2de8e9e8 Chrysler: Speed msg is 5 bytes
f4ac315e Chrysler: add counter to 514
0fb62cf8 Toyota Blind Spot Monitor (TSS2-only?) (#219)

git-subtree-dir: opendbc
git-subtree-split: d1f76d609f22bb6c14d3a74c41c00adf6855aaec
pd0wm pushed a commit that referenced this issue Mar 6, 2020
Squashed 'opendbc/' changes from 2ae0327e..d1f76d60
3a298e2 
d1f76d60 Add Motor_20 CRC support (#229)
6252718a Add STEER_ANGLE to all STEER_TORUQE_SENSOR messages (#228)
c0b42612 Revert "add angle field in torque sensor message to all cars (#227)"
bd82848c add angle field in torque sensor message to all cars (#227)
56f0259d Lexus CTH fix: brake pressed is on bit 5 like corolla and rav4
9b6ca31b fix: Replicate changes done on _honda_2017.dbc (#225)
1bd26d0a Added messages. Cleaned up endianness (#226)
44b9e74f Revert "Toyota: add checksum to BRAKE_MODULE (#224)"
8b18c92e Toyota: add checksum to BRAKE_MODULE (#224)
2bab4d6d Add Honda-Bosch lane line detection signals. (#223)
a1aa3b78 Cleanup of Nissan DBC (#218)
c1f76482 reverting changes to Chrysler: speed message seems different from car to car
2de8e9e8 Chrysler: Speed msg is 5 bytes
f4ac315e Chrysler: add counter to 514
0fb62cf8 Toyota Blind Spot Monitor (TSS2-only?) (#219)

git-subtree-dir: opendbc
git-subtree-split: d1f76d609f22bb6c14d3a74c41c00adf6855aaec
pd0wm pushed a commit that referenced this issue Mar 7, 2020
Squashed 'opendbc/' changes from 2ae0327e..d1f76d60
888e7a1 
d1f76d60 Add Motor_20 CRC support (#229)
6252718a Add STEER_ANGLE to all STEER_TORUQE_SENSOR messages (#228)
c0b42612 Revert "add angle field in torque sensor message to all cars (#227)"
bd82848c add angle field in torque sensor message to all cars (#227)
56f0259d Lexus CTH fix: brake pressed is on bit 5 like corolla and rav4
9b6ca31b fix: Replicate changes done on _honda_2017.dbc (#225)
1bd26d0a Added messages. Cleaned up endianness (#226)
44b9e74f Revert "Toyota: add checksum to BRAKE_MODULE (#224)"
8b18c92e Toyota: add checksum to BRAKE_MODULE (#224)
2bab4d6d Add Honda-Bosch lane line detection signals. (#223)
a1aa3b78 Cleanup of Nissan DBC (#218)
c1f76482 reverting changes to Chrysler: speed message seems different from car to car
2de8e9e8 Chrysler: Speed msg is 5 bytes
f4ac315e Chrysler: add counter to 514
0fb62cf8 Toyota Blind Spot Monitor (TSS2-only?) (#219)

git-subtree-dir: opendbc
git-subtree-split: d1f76d609f22bb6c14d3a74c41c00adf6855aaec
pd0wm pushed a commit that referenced this issue Mar 7, 2020
Squashed 'opendbc/' changes from 2ae0327ea..d1f76d609
81f1065 
d1f76d609 Add Motor_20 CRC support (#229)
6252718a9 Add STEER_ANGLE to all STEER_TORUQE_SENSOR messages (#228)
c0b426126 Revert "add angle field in torque sensor message to all cars (#227)"
bd82848c7 add angle field in torque sensor message to all cars (#227)
56f0259df Lexus CTH fix: brake pressed is on bit 5 like corolla and rav4
9b6ca31b2 fix: Replicate changes done on _honda_2017.dbc (#225)
1bd26d0a6 Added messages. Cleaned up endianness (#226)
44b9e74fa Revert "Toyota: add checksum to BRAKE_MODULE (#224)"
8b18c92e2 Toyota: add checksum to BRAKE_MODULE (#224)
2bab4d6d7 Add Honda-Bosch lane line detection signals. (#223)
a1aa3b78f Cleanup of Nissan DBC (#218)
c1f764828 reverting changes to Chrysler: speed message seems different from car to car
2de8e9e82 Chrysler: Speed msg is 5 bytes
f4ac315ed Chrysler: add counter to 514
0fb62cf86 Toyota Blind Spot Monitor (TSS2-only?) (#219)

git-subtree-dir: opendbc
git-subtree-split: d1f76d609f22bb6c14d3a74c41c00adf6855aaec
pd0wm pushed a commit that referenced this issue Mar 7, 2020
Squashed 'opendbc/' changes from 2ae0327ea..f308ca62e
89f4c43 
f308ca62e Subaru: added counter and checksum to brake msg
d1f76d609 Add Motor_20 CRC support (#229)
6252718a9 Add STEER_ANGLE to all STEER_TORUQE_SENSOR messages (#228)
c0b426126 Revert "add angle field in torque sensor message to all cars (#227)"
bd82848c7 add angle field in torque sensor message to all cars (#227)
56f0259df Lexus CTH fix: brake pressed is on bit 5 like corolla and rav4
9b6ca31b2 fix: Replicate changes done on _honda_2017.dbc (#225)
1bd26d0a6 Added messages. Cleaned up endianness (#226)
44b9e74fa Revert "Toyota: add checksum to BRAKE_MODULE (#224)"
8b18c92e2 Toyota: add checksum to BRAKE_MODULE (#224)
2bab4d6d7 Add Honda-Bosch lane line detection signals. (#223)
a1aa3b78f Cleanup of Nissan DBC (#218)
c1f764828 reverting changes to Chrysler: speed message seems different from car to car
2de8e9e82 Chrysler: Speed msg is 5 bytes
f4ac315ed Chrysler: add counter to 514
0fb62cf86 Toyota Blind Spot Monitor (TSS2-only?) (#219)

git-subtree-dir: opendbc
git-subtree-split: f308ca62e30ac7ab74f2d40eab343cd7541e5647
pd0wm pushed a commit that referenced this issue Mar 7, 2020
Squashed 'opendbc/' changes from 2ae0327ea..f308ca62e
de9e410 
f308ca62e Subaru: added counter and checksum to brake msg
d1f76d609 Add Motor_20 CRC support (#229)
6252718a9 Add STEER_ANGLE to all STEER_TORUQE_SENSOR messages (#228)
c0b426126 Revert "add angle field in torque sensor message to all cars (#227)"
bd82848c7 add angle field in torque sensor message to all cars (#227)
56f0259df Lexus CTH fix: brake pressed is on bit 5 like corolla and rav4
9b6ca31b2 fix: Replicate changes done on _honda_2017.dbc (#225)
1bd26d0a6 Added messages. Cleaned up endianness (#226)
44b9e74fa Revert "Toyota: add checksum to BRAKE_MODULE (#224)"
8b18c92e2 Toyota: add checksum to BRAKE_MODULE (#224)
2bab4d6d7 Add Honda-Bosch lane line detection signals. (#223)
a1aa3b78f Cleanup of Nissan DBC (#218)
c1f764828 reverting changes to Chrysler: speed message seems different from car to car
2de8e9e82 Chrysler: Speed msg is 5 bytes
f4ac315ed Chrysler: add counter to 514
0fb62cf86 Toyota Blind Spot Monitor (TSS2-only?) (#219)

git-subtree-dir: opendbc
git-subtree-split: f308ca62e30ac7ab74f2d40eab343cd7541e5647
pd0wm pushed a commit that referenced this issue Mar 9, 2020
Squashed 'opendbc/' changes from 2ae0327ea..f308ca62e
04041f0 
f308ca62e Subaru: added counter and checksum to brake msg
d1f76d609 Add Motor_20 CRC support (#229)
6252718a9 Add STEER_ANGLE to all STEER_TORUQE_SENSOR messages (#228)
c0b426126 Revert "add angle field in torque sensor message to all cars (#227)"
bd82848c7 add angle field in torque sensor message to all cars (#227)
56f0259df Lexus CTH fix: brake pressed is on bit 5 like corolla and rav4
9b6ca31b2 fix: Replicate changes done on _honda_2017.dbc (#225)
1bd26d0a6 Added messages. Cleaned up endianness (#226)
44b9e74fa Revert "Toyota: add checksum to BRAKE_MODULE (#224)"
8b18c92e2 Toyota: add checksum to BRAKE_MODULE (#224)
2bab4d6d7 Add Honda-Bosch lane line detection signals. (#223)
a1aa3b78f Cleanup of Nissan DBC (#218)
c1f764828 reverting changes to Chrysler: speed message seems different from car to car
2de8e9e82 Chrysler: Speed msg is 5 bytes
f4ac315ed Chrysler: add counter to 514
0fb62cf86 Toyota Blind Spot Monitor (TSS2-only?) (#219)

git-subtree-dir: opendbc
git-subtree-split: f308ca62e30ac7ab74f2d40eab343cd7541e5647
pd0wm pushed a commit that referenced this issue Mar 12, 2020
Squashed 'opendbc/' changes from 2ae0327ea..ce723756f
c2cbafe 
ce723756f Fixed up sign on Driver Torque, added unit (#233)
bd72c72be Added ProPilot HUD messages (#231)
f308ca62e Subaru: added counter and checksum to brake msg
d1f76d609 Add Motor_20 CRC support (#229)
6252718a9 Add STEER_ANGLE to all STEER_TORUQE_SENSOR messages (#228)
c0b426126 Revert "add angle field in torque sensor message to all cars (#227)"
bd82848c7 add angle field in torque sensor message to all cars (#227)
56f0259df Lexus CTH fix: brake pressed is on bit 5 like corolla and rav4
9b6ca31b2 fix: Replicate changes done on _honda_2017.dbc (#225)
1bd26d0a6 Added messages. Cleaned up endianness (#226)
44b9e74fa Revert "Toyota: add checksum to BRAKE_MODULE (#224)"
8b18c92e2 Toyota: add checksum to BRAKE_MODULE (#224)
2bab4d6d7 Add Honda-Bosch lane line detection signals. (#223)
a1aa3b78f Cleanup of Nissan DBC (#218)
c1f764828 reverting changes to Chrysler: speed message seems different from car to car
2de8e9e82 Chrysler: Speed msg is 5 bytes
f4ac315ed Chrysler: add counter to 514
0fb62cf86 Toyota Blind Spot Monitor (TSS2-only?) (#219)

git-subtree-dir: opendbc
git-subtree-split: ce723756f75d7efb74a9664a1761079641923683
pd0wm pushed a commit that referenced this issue Mar 13, 2020
Squashed 'opendbc/' changes from 2ae0327ea..ce723756f
6367e81 
ce723756f Fixed up sign on Driver Torque, added unit (#233)
bd72c72be Added ProPilot HUD messages (#231)
f308ca62e Subaru: added counter and checksum to brake msg
d1f76d609 Add Motor_20 CRC support (#229)
6252718a9 Add STEER_ANGLE to all STEER_TORUQE_SENSOR messages (#228)
c0b426126 Revert "add angle field in torque sensor message to all cars (#227)"
bd82848c7 add angle field in torque sensor message to all cars (#227)
56f0259df Lexus CTH fix: brake pressed is on bit 5 like corolla and rav4
9b6ca31b2 fix: Replicate changes done on _honda_2017.dbc (#225)
1bd26d0a6 Added messages. Cleaned up endianness (#226)
44b9e74fa Revert "Toyota: add checksum to BRAKE_MODULE (#224)"
8b18c92e2 Toyota: add checksum to BRAKE_MODULE (#224)
2bab4d6d7 Add Honda-Bosch lane line detection signals. (#223)
a1aa3b78f Cleanup of Nissan DBC (#218)
c1f764828 reverting changes to Chrysler: speed message seems different from car to car
2de8e9e82 Chrysler: Speed msg is 5 bytes
f4ac315ed Chrysler: add counter to 514
0fb62cf86 Toyota Blind Spot Monitor (TSS2-only?) (#219)

git-subtree-dir: opendbc
git-subtree-split: ce723756f75d7efb74a9664a1761079641923683
pd0wm pushed a commit that referenced this issue Mar 13, 2020
Squashed 'opendbc/' changes from 2ae0327ea..ce723756f
fc23ba9 
ce723756f Fixed up sign on Driver Torque, added unit (#233)
bd72c72be Added ProPilot HUD messages (#231)
f308ca62e Subaru: added counter and checksum to brake msg
d1f76d609 Add Motor_20 CRC support (#229)
6252718a9 Add STEER_ANGLE to all STEER_TORUQE_SENSOR messages (#228)
c0b426126 Revert "add angle field in torque sensor message to all cars (#227)"
bd82848c7 add angle field in torque sensor message to all cars (#227)
56f0259df Lexus CTH fix: brake pressed is on bit 5 like corolla and rav4
9b6ca31b2 fix: Replicate changes done on _honda_2017.dbc (#225)
1bd26d0a6 Added messages. Cleaned up endianness (#226)
44b9e74fa Revert "Toyota: add checksum to BRAKE_MODULE (#224)"
8b18c92e2 Toyota: add checksum to BRAKE_MODULE (#224)
2bab4d6d7 Add Honda-Bosch lane line detection signals. (#223)
a1aa3b78f Cleanup of Nissan DBC (#218)
c1f764828 reverting changes to Chrysler: speed message seems different from car to car
2de8e9e82 Chrysler: Speed msg is 5 bytes
f4ac315ed Chrysler: add counter to 514
0fb62cf86 Toyota Blind Spot Monitor (TSS2-only?) (#219)

git-subtree-dir: opendbc
git-subtree-split: ce723756f75d7efb74a9664a1761079641923683
pd0wm pushed a commit that referenced this issue Mar 13, 2020
Squashed 'opendbc/' changes from 2ae0327ea..ce723756f
7d53cb1 
ce723756f Fixed up sign on Driver Torque, added unit (#233)
bd72c72be Added ProPilot HUD messages (#231)
f308ca62e Subaru: added counter and checksum to brake msg
d1f76d609 Add Motor_20 CRC support (#229)
6252718a9 Add STEER_ANGLE to all STEER_TORUQE_SENSOR messages (#228)
c0b426126 Revert "add angle field in torque sensor message to all cars (#227)"
bd82848c7 add angle field in torque sensor message to all cars (#227)
56f0259df Lexus CTH fix: brake pressed is on bit 5 like corolla and rav4
9b6ca31b2 fix: Replicate changes done on _honda_2017.dbc (#225)
1bd26d0a6 Added messages. Cleaned up endianness (#226)
44b9e74fa Revert "Toyota: add checksum to BRAKE_MODULE (#224)"
8b18c92e2 Toyota: add checksum to BRAKE_MODULE (#224)
2bab4d6d7 Add Honda-Bosch lane line detection signals. (#223)
a1aa3b78f Cleanup of Nissan DBC (#218)
c1f764828 reverting changes to Chrysler: speed message seems different from car to car
2de8e9e82 Chrysler: Speed msg is 5 bytes
f4ac315ed Chrysler: add counter to 514
0fb62cf86 Toyota Blind Spot Monitor (TSS2-only?) (#219)

git-subtree-dir: opendbc
git-subtree-split: ce723756f75d7efb74a9664a1761079641923683
pd0wm pushed a commit that referenced this issue Mar 14, 2020
Squashed 'opendbc/' changes from 2ae0327ea..ce723756f
3a165b2 
ce723756f Fixed up sign on Driver Torque, added unit (#233)
bd72c72be Added ProPilot HUD messages (#231)
f308ca62e Subaru: added counter and checksum to brake msg
d1f76d609 Add Motor_20 CRC support (#229)
6252718a9 Add STEER_ANGLE to all STEER_TORUQE_SENSOR messages (#228)
c0b426126 Revert "add angle field in torque sensor message to all cars (#227)"
bd82848c7 add angle field in torque sensor message to all cars (#227)
56f0259df Lexus CTH fix: brake pressed is on bit 5 like corolla and rav4
9b6ca31b2 fix: Replicate changes done on _honda_2017.dbc (#225)
1bd26d0a6 Added messages. Cleaned up endianness (#226)
44b9e74fa Revert "Toyota: add checksum to BRAKE_MODULE (#224)"
8b18c92e2 Toyota: add checksum to BRAKE_MODULE (#224)
2bab4d6d7 Add Honda-Bosch lane line detection signals. (#223)
a1aa3b78f Cleanup of Nissan DBC (#218)
c1f764828 reverting changes to Chrysler: speed message seems different from car to car
2de8e9e82 Chrysler: Speed msg is 5 bytes
f4ac315ed Chrysler: add counter to 514
0fb62cf86 Toyota Blind Spot Monitor (TSS2-only?) (#219)

git-subtree-dir: opendbc
git-subtree-split: ce723756f75d7efb74a9664a1761079641923683
pd0wm pushed a commit that referenced this issue Mar 16, 2020
Squashed 'opendbc/' changes from 2ae0327ea..a62d5dd84
b25b0f5 
a62d5dd84 Add TSK_06 CRC validation for VW MQB (#234)
ce723756f Fixed up sign on Driver Torque, added unit (#233)
bd72c72be Added ProPilot HUD messages (#231)
f308ca62e Subaru: added counter and checksum to brake msg
d1f76d609 Add Motor_20 CRC support (#229)
6252718a9 Add STEER_ANGLE to all STEER_TORUQE_SENSOR messages (#228)
c0b426126 Revert "add angle field in torque sensor message to all cars (#227)"
bd82848c7 add angle field in torque sensor message to all cars (#227)
56f0259df Lexus CTH fix: brake pressed is on bit 5 like corolla and rav4
9b6ca31b2 fix: Replicate changes done on _honda_2017.dbc (#225)
1bd26d0a6 Added messages. Cleaned up endianness (#226)
44b9e74fa Revert "Toyota: add checksum to BRAKE_MODULE (#224)"
8b18c92e2 Toyota: add checksum to BRAKE_MODULE (#224)
2bab4d6d7 Add Honda-Bosch lane line detection signals. (#223)
a1aa3b78f Cleanup of Nissan DBC (#218)
c1f764828 reverting changes to Chrysler: speed message seems different from car to car
2de8e9e82 Chrysler: Speed msg is 5 bytes
f4ac315ed Chrysler: add counter to 514
0fb62cf86 Toyota Blind Spot Monitor (TSS2-only?) (#219)

git-subtree-dir: opendbc
git-subtree-split: a62d5dd847c352be2daf28288f093f4c25a8308d
pd0wm pushed a commit that referenced this issue Mar 16, 2020
Squashed 'opendbc/' changes from 2ae0327ea..a62d5dd84
96d66bc 
a62d5dd84 Add TSK_06 CRC validation for VW MQB (#234)
ce723756f Fixed up sign on Driver Torque, added unit (#233)
bd72c72be Added ProPilot HUD messages (#231)
f308ca62e Subaru: added counter and checksum to brake msg
d1f76d609 Add Motor_20 CRC support (#229)
6252718a9 Add STEER_ANGLE to all STEER_TORUQE_SENSOR messages (#228)
c0b426126 Revert "add angle field in torque sensor message to all cars (#227)"
bd82848c7 add angle field in torque sensor message to all cars (#227)
56f0259df Lexus CTH fix: brake pressed is on bit 5 like corolla and rav4
9b6ca31b2 fix: Replicate changes done on _honda_2017.dbc (#225)
1bd26d0a6 Added messages. Cleaned up endianness (#226)
44b9e74fa Revert "Toyota: add checksum to BRAKE_MODULE (#224)"
8b18c92e2 Toyota: add checksum to BRAKE_MODULE (#224)
2bab4d6d7 Add Honda-Bosch lane line detection signals. (#223)
a1aa3b78f Cleanup of Nissan DBC (#218)
c1f764828 reverting changes to Chrysler: speed message seems different from car to car
2de8e9e82 Chrysler: Speed msg is 5 bytes
f4ac315ed Chrysler: add counter to 514
0fb62cf86 Toyota Blind Spot Monitor (TSS2-only?) (#219)

git-subtree-dir: opendbc
git-subtree-split: a62d5dd847c352be2daf28288f093f4c25a8308d
pd0wm pushed a commit that referenced this issue Mar 16, 2020
Squashed 'opendbc/' changes from 2ae0327ea..a62d5dd84
72427d8 
a62d5dd84 Add TSK_06 CRC validation for VW MQB (#234)
ce723756f Fixed up sign on Driver Torque, added unit (#233)
bd72c72be Added ProPilot HUD messages (#231)
f308ca62e Subaru: added counter and checksum to brake msg
d1f76d609 Add Motor_20 CRC support (#229)
6252718a9 Add STEER_ANGLE to all STEER_TORUQE_SENSOR messages (#228)
c0b426126 Revert "add angle field in torque sensor message to all cars (#227)"
bd82848c7 add angle field in torque sensor message to all cars (#227)
56f0259df Lexus CTH fix: brake pressed is on bit 5 like corolla and rav4
9b6ca31b2 fix: Replicate changes done on _honda_2017.dbc (#225)
1bd26d0a6 Added messages. Cleaned up endianness (#226)
44b9e74fa Revert "Toyota: add checksum to BRAKE_MODULE (#224)"
8b18c92e2 Toyota: add checksum to BRAKE_MODULE (#224)
2bab4d6d7 Add Honda-Bosch lane line detection signals. (#223)
a1aa3b78f Cleanup of Nissan DBC (#218)
c1f764828 reverting changes to Chrysler: speed message seems different from car to car
2de8e9e82 Chrysler: Speed msg is 5 bytes
f4ac315ed Chrysler: add counter to 514
0fb62cf86 Toyota Blind Spot Monitor (TSS2-only?) (#219)

git-subtree-dir: opendbc
git-subtree-split: a62d5dd847c352be2daf28288f093f4c25a8308d
jyoung8607 pushed a commit to jyoung8607/openpilot that referenced this issue Apr 18, 2020
@jyoung8607
Squashed 'opendbc/' changes from 2ae0327ea..ce723756f
fe875e9 
ce723756f Fixed up sign on Driver Torque, added unit (commaai#233)
bd72c72be Added ProPilot HUD messages (commaai#231)
f308ca62e Subaru: added counter and checksum to brake msg
d1f76d609 Add Motor_20 CRC support (commaai#229)
6252718a9 Add STEER_ANGLE to all STEER_TORUQE_SENSOR messages (commaai#228)
c0b426126 Revert "add angle field in torque sensor message to all cars (commaai#227)"
bd82848c7 add angle field in torque sensor message to all cars (commaai#227)
56f0259df Lexus CTH fix: brake pressed is on bit 5 like corolla and rav4
9b6ca31b2 fix: Replicate changes done on _honda_2017.dbc (commaai#225)
1bd26d0a6 Added messages. Cleaned up endianness (commaai#226)
44b9e74fa Revert "Toyota: add checksum to BRAKE_MODULE (commaai#224)"
8b18c92e2 Toyota: add checksum to BRAKE_MODULE (commaai#224)
2bab4d6d7 Add Honda-Bosch lane line detection signals. (commaai#223)
a1aa3b78f Cleanup of Nissan DBC (commaai#218)
c1f764828 reverting changes to Chrysler: speed message seems different from car to car
2de8e9e82 Chrysler: Speed msg is 5 bytes
f4ac315ed Chrysler: add counter to 514
0fb62cf86 Toyota Blind Spot Monitor (TSS2-only?) (commaai#219)

git-subtree-dir: opendbc
git-subtree-split: ce723756f75d7efb74a9664a1761079641923683
TDIPWR pushed a commit to TDIPWR/openpilot that referenced this issue Nov 26, 2020
@ErichMoraga
Merge pull request commaai#229 from commaai/devel
c1c1733 
0.7.10
dzid26 added a commit to dzid26/openpilot-for-BMW-E8x-E9x that referenced this issue Jan 2, 2022
@dzid26
Squashed 'opendbc/' changes from 2ae0327e..d217f701
91e3d1a 
d217f701 Initial version of actuator dbc. Scalings represent my system gear ratios. See derivation in signal decriptions.
59a48a6f Endianness consistency.
ca74555 Counters are not cheksums. Checksums and counters revised. SteeringWheelAngle_DSC name reverted!
82da8d23 Tentatively added MDM status signal
87556a8 Added DSC statuses
4f810c29 Added torque factors
5272f021 Added few target nodes
7726134a Added messages from other BMW models
62d72c41 Added sender nodes and improved message names
e9113e6d Added traction control off button message
925aa0b1 Speed message cleanup
d15eaccd More precise steering factor
cdcca447 Another acceleration and gyro
3ee916a7 Added accelerators and checksum signals in Speed message
dd6829bd Added Ignition ON, modified steering ratio factor
33495aa6 Update README.md
0bf00e48 correction
904c0115 Added BMW CANbus overview.
47b386c4 OpenDBC updates
b83847eb Added some counter signals
c46ce064 Updated ShiftLeverPosition to bit-wise for readability. Added enumeration.
7f4515e2 Added PRND states. Confirmed with https://bmw.spoolstreet.com/threads/gs7-program-code-disassembly-project.6045/post-94403
dac7982f Added GearSelector postion signals inspired by https://www.spoolstreet.com/threads/gs7-program-code-disassembly-project.6045/post-93145
019e5fb3 OpenDBC updates
5b051948 Merge branch 'master' of https://github.com/dzid26/opendbc-BMW-E8x-E9x
e8a293fc Added ignition terminal states
1959ac7a Merge remote-tracking branch 'remotes/comma/master'
f308ca62 Subaru: added counter and checksum to brake msg
35233ad4 Added dynamic cruise control torque request signal
d1f76d60 Add Motor_20 CRC support (commaai#229)
6252718a Add STEER_ANGLE to all STEER_TORUQE_SENSOR messages (commaai#228)
c0b42612 Revert "add angle field in torque sensor message to all cars (commaai#227)"
bd82848c add angle field in torque sensor message to all cars (commaai#227)
56f0259d Lexus CTH fix: brake pressed is on bit 5 like corolla and rav4
9b6ca31b fix: Replicate changes done on _honda_2017.dbc (commaai#225)
1bd26d0a Added messages. Cleaned up endianness (commaai#226)
44b9e74f Revert "Toyota: add checksum to BRAKE_MODULE (commaai#224)"
8b18c92e Toyota: add checksum to BRAKE_MODULE (commaai#224)
2bab4d6d Add Honda-Bosch lane line detection signals. (commaai#223)
cbe4528b Added engine torque
7fe0df53 Added lateral and longitudal accelerometers and battery voltage
a1aa3b78 Cleanup of Nissan DBC (commaai#218)
c1f76482 reverting changes to Chrysler: speed message seems different from car to car
2de8e9e8 Chrysler: Speed msg is 5 bytes
f4ac315e Chrysler: add counter to 514
d23d0b80 Merge remote-tracking branch 'remotes/comma/master'
0fb62cf8 Toyota Blind Spot Monitor (TSS2-only?) (commaai#219)
a3ba5d0 Added blinkers
748e94e9 wiper button
ec3f4a39 Removed openSteering messages. Added gear enums and cruise +5/-5 Renames...
555d99a1 Improved OpenActuator packing
b0412d4e Added (invented) OpenPilot request message
abc339dd Added kph factor to WheelSpeeds from DSC
2a385a49 Added motor controller CAN message
12e4a137 message size
c53c4221 OpenDBC updates
5cc88e9a OpenDBC updates
c358ed3f Added units; fixed steering speed signal in 0xc4
91fdf6da OpenDBC updates
b9ba537e OpenDBC updates
4009e81e another wheel position - active all the time
85d2fc72 OpenDBC updates
d9870aa6 Added unknown messages
71af0e4d Added F-CAN missing signals - unknown
5d7b1ee0 unit
db436dd Speed scaling
e7bc05fc OpenDBC updates
a11eff80 Corrected cruise control pedal pressed vs driver pedal pressed
db531561 OpenDBC updates
6c442ac7 OpenDBC updates
58e577ca Delete BMW E-series CAN dev.dbc
86d5f8e6 OpenDBC updates
9f582ac8 Merge branch 'master' of https://github.com/dzid26/opendbc-BMW-E8x-E9x
4903aa5e OpenDBC updates
0d03e177 OpenDBC updates
ebc3047f OpenDBC updates
c5927819 OpenDBC updates
6fb2ce67 OpenDBC updates
94ef8924 OpenDBC updates
8649b0e3  size set to 7
c80c750f Merge branch 'master' of https://github.com/dzid26/opendbc-BMW-E8x-E9x
8add7117 acc pedal
dfeb7a3e Steering Wheel angle and wheels speed
5e619d76 BMW dbc copied from OpenDBC repository https://github.com/dzid26/opendbc-BMW-E8x-E9x/
5fe0915d Steering wheel sensor DSC
0c944a8e OpenDBC updates
0deef5ce OpenDBC updates
fa64ef48 OpenDBC updates
ee6523fe Other can messages
88156113 Removed spaces
783586d2 Added can messages from SZL
98b7cace Dynamic cruise control vehicle option has different can messages
13ff1a1a Cruise control
731d1978 Updated pedal statuses
9afe6b0f Corrected to throttle
90801021 Added some cruise statuses
52154764 cruise speed scaling
44dc4833 cruiseControlStatus
9a59d3e5 Added bunch of unknown messages
a88851e3 Cruise counters set to Big endian
2c0e0a24 Rename BMW E-series K+CAN.dbc to BMW E-series CAN.dbc
d53a55a1 SteeringButtons
91d4a861 Fixed many DBC syntax issues
6a147162 Removed module names due to bug/conflict?
7eb3daf7 Fixed names.
5660526f Fixes after cabana broke it
7e70bcae brake depress flag
88647719 Update BMW E-series K+CAN.dbc
fc62bb41 Delete BMW E-series K+CAN
f231bede Cruise control commands
e3cd3441 Added brake pedal pressed
39359a4d OpenDBC updates
129384ca Rename BMW E-series to BMW E-series K+CAN
ec83a615 Update BMW E-series
dee5aa61 Initial test commit

git-subtree-dir: opendbc
git-subtree-split: d217f701793db79a1574fd5829f91d648c3b7af6
dzid26 added a commit to dzid26/openpilot-for-BMW-E8x-E9x that referenced this issue Feb 22, 2022
@dzid26
Squashed 'opendbc/' changes from 2ae0327e..d217f701
3d18c31 
d217f701 Initial version of actuator dbc. Scalings represent my system gear ratios. See derivation in signal decriptions.
59a48a6f Endianness consistency.
ca74555 Counters are not cheksums. Checksums and counters revised. SteeringWheelAngle_DSC name reverted!
82da8d23 Tentatively added MDM status signal
87556a8 Added DSC statuses
4f810c29 Added torque factors
5272f021 Added few target nodes
7726134a Added messages from other BMW models
62d72c41 Added sender nodes and improved message names
e9113e6d Added traction control off button message
925aa0b1 Speed message cleanup
d15eaccd More precise steering factor
cdcca447 Another acceleration and gyro
3ee916a7 Added accelerators and checksum signals in Speed message
dd6829bd Added Ignition ON, modified steering ratio factor
33495aa6 Update README.md
0bf00e48 correction
904c0115 Added BMW CANbus overview.
47b386c4 OpenDBC updates
b83847eb Added some counter signals
c46ce064 Updated ShiftLeverPosition to bit-wise for readability. Added enumeration.
7f4515e2 Added PRND states. Confirmed with https://bmw.spoolstreet.com/threads/gs7-program-code-disassembly-project.6045/post-94403
dac7982f Added GearSelector postion signals inspired by https://www.spoolstreet.com/threads/gs7-program-code-disassembly-project.6045/post-93145
019e5fb3 OpenDBC updates
5b051948 Merge branch 'master' of https://github.com/dzid26/opendbc-BMW-E8x-E9x
e8a293fc Added ignition terminal states
1959ac7a Merge remote-tracking branch 'remotes/comma/master'
f308ca62 Subaru: added counter and checksum to brake msg
35233ad4 Added dynamic cruise control torque request signal
d1f76d60 Add Motor_20 CRC support (commaai#229)
6252718a Add STEER_ANGLE to all STEER_TORUQE_SENSOR messages (commaai#228)
c0b42612 Revert "add angle field in torque sensor message to all cars (commaai#227)"
bd82848c add angle field in torque sensor message to all cars (commaai#227)
56f0259d Lexus CTH fix: brake pressed is on bit 5 like corolla and rav4
9b6ca31b fix: Replicate changes done on _honda_2017.dbc (commaai#225)
1bd26d0a Added messages. Cleaned up endianness (commaai#226)
44b9e74f Revert "Toyota: add checksum to BRAKE_MODULE (commaai#224)"
8b18c92e Toyota: add checksum to BRAKE_MODULE (commaai#224)
2bab4d6d Add Honda-Bosch lane line detection signals. (commaai#223)
cbe4528b Added engine torque
7fe0df53 Added lateral and longitudal accelerometers and battery voltage
a1aa3b78 Cleanup of Nissan DBC (commaai#218)
c1f76482 reverting changes to Chrysler: speed message seems different from car to car
2de8e9e8 Chrysler: Speed msg is 5 bytes
f4ac315e Chrysler: add counter to 514
d23d0b80 Merge remote-tracking branch 'remotes/comma/master'
0fb62cf8 Toyota Blind Spot Monitor (TSS2-only?) (commaai#219)
a3ba5d0 Added blinkers
748e94e9 wiper button
ec3f4a39 Removed openSteering messages. Added gear enums and cruise +5/-5 Renames...
555d99a1 Improved OpenActuator packing
b0412d4e Added (invented) OpenPilot request message
abc339dd Added kph factor to WheelSpeeds from DSC
2a385a49 Added motor controller CAN message
12e4a137 message size
c53c4221 OpenDBC updates
5cc88e9a OpenDBC updates
c358ed3f Added units; fixed steering speed signal in 0xc4
91fdf6da OpenDBC updates
b9ba537e OpenDBC updates
4009e81e another wheel position - active all the time
85d2fc72 OpenDBC updates
d9870aa6 Added unknown messages
71af0e4d Added F-CAN missing signals - unknown
5d7b1ee0 unit
db436dd Speed scaling
e7bc05fc OpenDBC updates
a11eff80 Corrected cruise control pedal pressed vs driver pedal pressed
db531561 OpenDBC updates
6c442ac7 OpenDBC updates
58e577ca Delete BMW E-series CAN dev.dbc
86d5f8e6 OpenDBC updates
9f582ac8 Merge branch 'master' of https://github.com/dzid26/opendbc-BMW-E8x-E9x
4903aa5e OpenDBC updates
0d03e177 OpenDBC updates
ebc3047f OpenDBC updates
c5927819 OpenDBC updates
6fb2ce67 OpenDBC updates
94ef8924 OpenDBC updates
8649b0e3  size set to 7
c80c750f Merge branch 'master' of https://github.com/dzid26/opendbc-BMW-E8x-E9x
8add7117 acc pedal
dfeb7a3e Steering Wheel angle and wheels speed
5e619d76 BMW dbc copied from OpenDBC repository https://github.com/dzid26/opendbc-BMW-E8x-E9x/
5fe0915d Steering wheel sensor DSC
0c944a8e OpenDBC updates
0deef5ce OpenDBC updates
fa64ef48 OpenDBC updates
ee6523fe Other can messages
88156113 Removed spaces
783586d2 Added can messages from SZL
98b7cace Dynamic cruise control vehicle option has different can messages
13ff1a1a Cruise control
731d1978 Updated pedal statuses
9afe6b0f Corrected to throttle
90801021 Added some cruise statuses
52154764 cruise speed scaling
44dc4833 cruiseControlStatus
9a59d3e5 Added bunch of unknown messages
a88851e3 Cruise counters set to Big endian
2c0e0a24 Rename BMW E-series K+CAN.dbc to BMW E-series CAN.dbc
d53a55a1 SteeringButtons
91d4a861 Fixed many DBC syntax issues
6a147162 Removed module names due to bug/conflict?
7eb3daf7 Fixed names.
5660526f Fixes after cabana broke it
7e70bcae brake depress flag
88647719 Update BMW E-series K+CAN.dbc
fc62bb41 Delete BMW E-series K+CAN
f231bede Cruise control commands
e3cd3441 Added brake pedal pressed
39359a4d OpenDBC updates
129384ca Rename BMW E-series to BMW E-series K+CAN
ec83a615 Update BMW E-series
dee5aa61 Initial test commit

git-subtree-dir: opendbc
git-subtree-split: d217f701793db79a1574fd5829f91d648c3b7af6
nworb-cire pushed a commit to opgm/openpilot that referenced this issue Aug 2, 2024
@sunnyhaibin
MADS: Ford: LCA button signal fix (commaai#229)
d7a2214
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@geohot @Jamezz