Porting openpilot to other HW than Neo #63
Comments
kozuch
changed the title
kozuch
changed the title
kozuch
changed the title
|
I have experimented with using openpilot in other platforms (osx, linux) and believe that apart from Your main obstacle is going to be running |
|
I am sorry I know about the visiond binary blob but I completely forgot to mention it. I am not a low level coding geek but I think there the visiond binary may actually be portable to similar ARM processors. OP3 has a Qualcomm MSM8996 Snapdragon 820 CPU which is ARMv8-A architecture. From what I read binary compatibility works within same ARM architecture and even forward compatibility should work (code compiled on ARMv7 should actually run on ARMv8 etc.). If this is true that would open a whole bunch od devices to port to (see Wikipedia), This is why I was thinking about porting. If there would be problems within whole ARMv8 the I think porting to other Snapdragon 820 device (there is at least a dozen of other smartphones using this chip) may be much simpler. Also, there is the upcoming Dragonboard 820c. |
|
While I can understand the benefits of running this on an arm smartphone, it might be very interesting to use a (linux) laptop for testing. Has anyone comma currently running on an x86 device with external camera? Documentation for that seems kinda limited. |
|
Most of the opendrive code is written in Python. How does Neo specifically run this code? Does it include a Python interpreter, or is the OpenDrive pre-compiled into C and machine code (maybe using Cython??) to run as a normal Android binary? |
|
@jyl087 it uses https://termux.com/ That gives them apt to install python and a lot of the requirements needed to bootstrap the system. The rest of the dependencies can be compiled. They stripped android to basically just run that app, their NEOS looks for one file to start after boot and openpilot writes on that file instructions to run |
|
@ingenieroariel if that's the case, couldn't OpenPilot theoretically run on ANY late-model Android phone as long as Termux is installed? Does the HAL abstract the camera enough to allow visiond to run, or is the OnePlus phone hardcoded into visiond? |
|
You are asking too much about the closed sourced parts and I have not seen them :)
Try running it on another phone and let us know the results. I think you will be able to run everything except visiond as that one will require the dynamically linked libraries and probably has a basic camera driver statically linked. To be able to run the neural nets you will need a chip like that qualcomm snapdragon that comes with the oneplus.
I think visiond could be easily ported to other platforms if you are compiling it from source but I would not bet on taking that binary and trying to run it elsewhere.
…-a
On May 10, 2017, at 10:36 AM, jyl087 ***@***.***> wrote:
@ingenieroariel if that's the case, couldn't OpenPilot theoretically run on ANY late-model Android phone as long as Termux is installed? Does the HAL abstract the camera enough to allow visiond to run, or is the OnePlus phone hardcoded into visiond?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.
|
|
Sorry if I've hijacked this thread... I can open a new one if that is deemed appropriate. I guess the thought of porting openpilot to "Android" counts as not Neo, right? Anyway, I'm working through the list of packages listed on "requirements_openpilot.txt". I've managed to install everything except for "fastcluster". I'm seeing this error: I also could not install "scipy". Maybe this is related. I take it that scipy and Android are not really best buddies at this stage: http://www.leouieda.com/blog/scipy-on-android.html So, one question I have is, what comes loaded with Neo to make everything work? Is SciPy and fastcluster part of that ROM? Again, sorry if this is too far off topic for this thread. |
|
scipy and fastcluster are part of that rom, if you just want to keep hacking until you see something try removing the parts that use scipy and the other lib in the code, you can cross compile them at a later stage by creating an apt repo to complement what termux provides.
My humble suggestion is for you to keep going at it until you can load the ui.
…-a
On May 11, 2017, at 10:37 PM, jyl087 ***@***.***> wrote:
Sorry if I've hijacked this thread... I can open a new one if that is deemed appropriate. I guess the thought of porting openpilot to "Android" counts as not Neo, right?
Anyway, I'm working through the list of packages listed on "requirements_openpilot.txt". I've managed to install everything except for "fastcluster". I'm seeing this error:
ImportError: dlopen failed: cannot locate symbol "__mulodi4" referenced by "/data/data/com.termux/files/usr/lib/python2.7/site-packages/numpy/core/umath.so"...
I also could not install "scipy". Maybe this is related. I take it that scipy and Android are not really best buddies at this stage: http://www.leouieda.com/blog/scipy-on-android.html
So, one question I have is, what comes loaded with Neo to make everything work? Is SciPy and fastcluster part of that ROM? Again, sorry if this is too far off topic for this thread.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.
|
|
@kozuch , I admire your call for the "," team to open source more of visiond! In the meantime, I'm just trying to understand what has already been put out. @ingenieroariel says that scipy and fastcluster are part of the Neo ROM, so Neo also seems to be a bit of a black box. I would love more information on how Neo is built (i.e. how all the required libraries are loaded) and how it boots up. |
|
I would not call NEO a black box, after you install it on a oneplus 3 you
get sudo access and can poke around all you want, copy that compiled
library, etc.
Maybe you can figure out a way to run the NEO rom on an emulator?
…On Fri, May 12, 2017 at 11:50 AM, jyl087 ***@***.***> wrote:
@kozuch <https://github.com/kozuch> , I admire your call for the "," team
to open source more of visiond! In the meantime, I'm just trying to
understand what has already been put out. @ingenieroariel
<https://github.com/ingenieroariel> says that scipy and fastcluster are
part of the Neo ROM, so Neo also seems to be a bit of a black box. I would
love more information on how Neo is built (i.e. how all the required
libraries are loaded) and how it boots up.
Finally, I agree that the custom H/W should be replaceable with other
interface boards such as IOIO.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#63 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AADW1wnZ6dViVfweirsKaaXPrzWKrII6ks5r5I3ZgaJpZM4MNIUW>
.
|
|
@ingenieroariel oohh I'm getting close. Have installed scipy (via "its-pointless" repo) and everything else, EXCEPT for fastcluster. Still getting: Collecting fastcluster==1.1.21 Command "python setup.py egg_info" failed with error code 1 in /data/data/com.termux/files/usr/tmp/pip-build-9f3zep/fastcluster/ Any ideas? |
|
Just wanted to update folks in case they run into this issue. I thought I had tried this previously, but trying again with the command: LDFLAGS=" -lm -lcompiler_rt" pip2 install numpy==1.11.2 worked to make the missing mulodi4 error when installing fastcluster. |
|
I have been following this thread with interest. |
|
@johnnwvs Sorry but no news from myself. Comma.ai does not seem to be interested to make to project more accessible in terms of cheaper hw options etc. |
|
Doubt there exists hardware that is too much cheaper to run openpilot. Also the vision model expects that specific camera, and will likely not get good performance with a different one. Closed for now. |
geohot
pushed a commit
that referenced
this issue
Jan 19, 2018
|
What is the base HW for the current EON Dashcam DevKit (EON DDK-1)? Both OnePlus 3 and 3T have already been discontinued... |
|
Thats what im saying. If the comma ai crew has them which seems logical. It would be nice to secure the newer one plus model |
|
can we have a cheaper variants of EON dashboard kit or custom ROM to port it to other android phones |
icmma
added a commit
to priuscom/openpilot
that referenced
this issue
Jan 28, 2019
|
Bump here. The visiond was open sourced lately. I created #562 for new discussion. |
dylanl321
pushed a commit
to dylanl321/openpilot
that referenced
this issue
Apr 28, 2019
update to latest
cfranyota
referenced
this issue
in cfranyota/openpilot-retired
Jun 7, 2019
* Honda Pilot PID Tuning * Adjustable Follow Distance w/HUD (#12) * TR * TR * TR * TR * TR * TR * TR * TR * remove readdistancelines - causes boot error * copying cereal * arne's cereal * HUD distance lines display * capnpp add * revert * revert * Set ACC HUD to KPH * Test - set HUD_ACC distance line to 2 * revert cruise_kph LKAS error * TR * TR * TR * TR * TR * TR * TR * TR * remove readdistancelines - causes boot error * copying cereal * HUD distance lines display * capnpp add * revert * revert * Set ACC HUD to KPH * Test - set HUD_ACC distance line to 2 * revert cruise_kph LKAS error * Remove custom btn var line could be crashing the code when button pressed * HUD distance lines * HUD distance lines * passing CS.CP.readdistancelines * Hardcode hud object dist_lines var * Initializes CS.readdistancelines before passing to hud obj * use integer read_distance_lines instead * Add HUD_DISTANCE_3 for horizontal HUD bars on dash * Default to 2 bars follow distance (1.8s) * Code Cleanup for Distance Adjustment Cleanup Cleanup Cleanup Cleanup Cleanup Cleanup Cleanup Cleanup Cleanup * Auto-distance at surface street speeds Override short distance setting when slow Override distance when slow Override distance if slow Override distance when slow Override distance when slow Increase follow distance when below 60 kph Lead car and rel. velocity to distance override Override distance bars revert Override and restore dist based on speed and accel Step up distance when < 40 km/h and restore Revert When using 1 bar distance: Slow the car down earlier and more aggressively (#18) * Change one bar braking profile to 3 bars * Update planner.py * Update planner.py * Update planner.py * Update planner.py * Update planner.py * Update planner.py * Update planner.py * Update planner.py * fake lead car vars * fake lead vars * Auto Distance Bar Working - tuning values * Logging to log.txt * Override hysteresis for one bar follow * Only set override when decelerating * syntax error fix for override flag * Switch to 1.8s for softer braking * Revert "Switch to 1.8s for softer braking" This reverts commit d53623062ef814509db925fe4e624c3ae8aff1f1. * Disable OTA update for safety * Physical LKAS button disables OP steer and shows dashed lines on HUD (#19) * Change one bar braking profile to 3 bars * Update planner.py * Update planner.py * Update planner.py * Update planner.py * Update planner.py * Update planner.py * Update planner.py * Update planner.py * fake lead car vars * fake lead vars * Auto Distance Bar Working - tuning values * Logging to log.txt * Override hysteresis for one bar follow * Only set override when decelerating * syntax error fix for override flag * Switch to 1.8s for softer braking * Disable LKAS * Apply Steer = 0 when user presses LKAS button * Add Lkas button * Add LK mode to HUDD data object * Add Dashed Lanes to HUD * Adjust HDD object * return LKAS var in CarState * Return LK var to CS * Syntax error fix * Update carcontroller.py * testing hud object hardcoded hud_lanes and lkMode * Restore accidentally deleted steer command * Update carcontroller.py * Update carcontroller.py * Don't show solid lanes if OP steering disabled * Dashed lines fix during engagement eliminate steering alert when lkas disabled lkas button logic cleanup Reverse the dashed-lane indicator No steering alert if LKAS disabled revert Alert - LKAS errors during steer disable Disable audible alert when steering disabled Delete CS.aEgo < -0.5 override condition * Remove chime disable when steering overriden One bar profile change to 1.8s if < 65 kph Simplified chime instead of beep disable for LK override * Adjust BRAKE_STOPPING_TARGET to 0.25 Keeps the brake pump from going crazy at a stop * Add relative velocity to auto distance for 1 bar setting (#26) * CAMERA_OFFSET = 0.08 * Revert Cost_long to comma value of 0.1 * Do not override to 1.8s when accel from stop * Update logic for override distance bars * Override distance when < 65kph and v_rel not > 5 * Use rel acceleration to reset to 1 bar * Use vRel * Update planner.py * v_lead - vEgo > 1 * vLead - vEgo = -1 * vLead-vEgo < -1.5 * Cleanup Arne's code for distance * vLead - vEgo < 1.25 * Back to vLead - vEgo < -1 * Disable OP steering and audio alarm when blinkers on (#28) * LKAS disable when blinkers are on * Update carcontroller.py * Update carcontroller.py * fix syntax error * Critical alarm if cruise disengages while braking (#32) * Update pathplanner.py * Loud alert in case cruise disables when braking * re-add if statement on speed for loud alert * Update interface.py * increase stopping distance to car by 1.5m * Increase stopping distance to 2m * Revert CAMERA_OFFSET to 0.06 (comma default) * Lane width reduction to 2.85m * Reduce tailgating for one bar distance at surface street speeds & code cleanup (#43) * Gernby's Lane width filter fix (#41) * Fix lane width filtering * Fixed lane width filtering * CAMERA_OFFSET = 0.08 * Minimum distance for one bar distance setting * Don't tailgate at slow speeds with 1 bar distance * x_lead < 5 only * x_lead < 5 syntax fix * self.v_rel < -1 or (x_lead < 10 and self.v_rel >= -1 and self.v_rel < 1) * Tail gating auto distance change * x_lead < 7.5 and self.v_rel >= -1 and self.v_rel < 0.2 * self.lastTR > 0 re-adding reinitialization * Revert "Gernby's Lane width filter fix (#41)" This reverts commit d081cfd8a05d2eb32e0148d477c806e65662dea7. * Increase min distance to 10m for auto distance * Auto distance code cleanup * Add lead car fast approaching autodistance * Auto distance Code cleanup * Don't re-initialize MPC if already initialized * self.lastTR != instead of > * Initialize TR = 1.8 * include if statements vs just assigning boolean * switch to 1 and 0 for TRUE AND FALSE * Revert "switch to 1 and 0 for TRUE AND FALSE" This reverts commit 58dcf718cdc3fca636229bf29942669670cb4487. * Revert "include if statements vs just assigning boolean" This reverts commit da7b5fa5088d62e78ba57d9e4c01e89160e77b9e. * Revert "Initialize TR = 1.8" This reverts commit f9c2571faeb0acaab818bcff146a2a397c0f07ff. * Initialize TR=1.8 inside override loop * Cleanup TR assignment for override loop * Code Cleanup * Syntax error * Syntax error * if statements for autodistance vars * tr-last assignment indent * CS.readdistancelines assignment to self.tr_last * remove else MPC init * Flatten out elif ladder for autodistance * Removed shrinking_fast stopping for now Braking is too sudden with 3 bar distance when radar detects car. Shrinking gap takes care of this with 2 bar distance. * Code Cleanup * Revert CAMERA_OFFSET to Comma default of 0.06 * Merge Gernby's Resonant Steering (#51) * Learn_angle_steer min max increased to +/-7 degs * Increase min one bar distance to 12m for autodist * Merge Gernby's Feed-Forward-Accel-Rate Branch (#49) * Fixed feed-forward to consider steer_offset * fixed a small oops on types * Testing strategies for zero-crossing * Moved angle stat collection to latcontrol.py * First version that runs * added outbound interface for feed-forward table * First working * Added more metrics * Adjusted parameter timing * performance tweaks * Cleanup * untested tweaks * minor tweaks * many untested changes * going the other way with some things... * Best yet * cleaned up personalized "stuff" * more cleanup for general use * untested: minor adjustment to further reduce noise * Fixed defect in desired angle interpolation * some cleanup * reverted change to Ki * Reverted changes to manager.py * Added steering rate consideration to latcontrol * cleaned up for PR * Fixed merge * Testing approach when desired angle close to actual * trying rate-based feed-forward * added self-tuning parms for rate and angle FF * fixed trim logic, and persisted to flash * working amazingly well * decreased time lapse for angle-based FF adjust * many tweaks, self-tuning is a bitch * simulteneous dual mode feedforward working very well * added angular accelleration limit * added super awesome angular accel limit * non-specific save * switching directions again * oops * ugly code with amazing results * awesome, but untested after some cleanup * more cleanup * cleanup of the cleanup? Need to test * works amazingly well ... big O face * cleanup * I wish git was batter for cleanup * removed Steer Offset because Pilot no likey * Increase tailgating 1 bar resume to 0.5 m/s * Gernby's resonant steering v2 * fixed an oops for non-bosch hondas * CAMERA_OFFSET = 0.08 * More conservative tailgating distance and resume * More conservative auto-distance for 1 bar setting * Revert CAMERA_OFFSET to 0.06 * Revert auto-distance for 1 bar distance setting * Revert "Merge Gernby's Resonant Steering" (#53) * Revert "Revert auto-distance for 1 bar distance setting" This reverts commit b7e5fb5. * Revert "Revert CAMERA_OFFSET to 0.06" This reverts commit 05cf21d. * Revert "Merge Gernby's Resonant Steering (#51)" This reverts commit d35aa19. * better crowned road centering: learn_angle +/-7 * Implement csouers 67-70% charging to preserve batt * slightly harder braking when tailgating * x_lead < 5 or (x_lead < 17.5 and self.v_rel < 0.5) * Proper alerts on Eon and disable flashing HUD alert when blinkers on or LKAS off (#63) * Disable steer alert when LKAS off * Display steering unavailable on Eon when LKAS off * Revert chime disable in favor of new method * x_lead < 6 or (x_lead < 17.5 and self.v_rel < 0.5) * logic correction on HUD alert * blinkers on disables HUD alarm * Add Manual Steering alert for LKAS Off mode * Call manual steering alert when LKAS off * Call blinkers alert when blinkers on * Add blinkers alert * Adjust Blinkers alert logic to include LKAS mode * Fix blinker logic * Add new steering required alerts to capnp * Trace LKAS / LDW error * Disable hud alert when LKAS off or blinkers on * Disable HUD alerts if LKAS off or blinkers on * Disable other ACC alert if LKAS off or blinkers on * Revert testing of steering required alert override * Disable steer saturate alert if blinkers on or LKAS off * Disable steer sat alert if LKAS off or blinkers on * Revert steerSaturated logic * disable steer limit alert when LKAS off or blinkers on * Fix Syntax error * Revert steerLimit alert disable * Disable steerSat alert when blinkers on or LKAS off * Revert stopping distance to default for pedal lurch * Re-intro 2m stopping distance * x_lead = 6 * Revert "Implement csouers 67-70% charging to preserve batt" This reverts commit e3249be. * Merge with latest kegman-devel without Gernby's FF steer (#72) * Honda Pilot PID Tuning * Adjustable Follow Distance w/HUD (#12) * TR * TR * TR * TR * TR * TR * TR * TR * remove readdistancelines - causes boot error * copying cereal * arne's cereal * HUD distance lines display * capnpp add * revert * revert * Set ACC HUD to KPH * Test - set HUD_ACC distance line to 2 * revert cruise_kph LKAS error * TR * TR * TR * TR * TR * TR * TR * TR * remove readdistancelines - causes boot error * copying cereal * HUD distance lines display * capnpp add * revert * revert * Set ACC HUD to KPH * Test - set HUD_ACC distance line to 2 * revert cruise_kph LKAS error * Remove custom btn var line could be crashing the code when button pressed * HUD distance lines * HUD distance lines * passing CS.CP.readdistancelines * Hardcode hud object dist_lines var * Initializes CS.readdistancelines before passing to hud obj * use integer read_distance_lines instead * Add HUD_DISTANCE_3 for horizontal HUD bars on dash * Default to 2 bars follow distance (1.8s) * Code Cleanup for Distance Adjustment Cleanup Cleanup Cleanup Cleanup Cleanup Cleanup Cleanup Cleanup Cleanup * Implement csouers 67-70% charging to preserve batt * Auto-distance at surface street speeds Override short distance setting when slow Override distance when slow Override distance if slow Override distance when slow Override distance when slow Increase follow distance when below 60 kph Lead car and rel. velocity to distance override Override distance bars revert Override and restore dist based on speed and accel Step up distance when < 40 km/h and restore Revert When using 1 bar distance: Slow the car down earlier and more aggressively (#18) * Change one bar braking profile to 3 bars * Update planner.py * Update planner.py * Update planner.py * Update planner.py * Update planner.py * Update planner.py * Update planner.py * Update planner.py * fake lead car vars * fake lead vars * Auto Distance Bar Working - tuning values * Logging to log.txt * Override hysteresis for one bar follow * Only set override when decelerating * syntax error fix for override flag * Switch to 1.8s for softer braking * Revert "Switch to 1.8s for softer braking" This reverts commit d53623062ef814509db925fe4e624c3ae8aff1f1. * Disable OTA update for safety * Physical LKAS button disables OP steer and shows dashed lines on HUD (#19) * Change one bar braking profile to 3 bars * Update planner.py * Update planner.py * Update planner.py * Update planner.py * Update planner.py * Update planner.py * Update planner.py * Update planner.py * fake lead car vars * fake lead vars * Auto Distance Bar Working - tuning values * Logging to log.txt * Override hysteresis for one bar follow * Only set override when decelerating * syntax error fix for override flag * Switch to 1.8s for softer braking * Disable LKAS * Apply Steer = 0 when user presses LKAS button * Add Lkas button * Add LK mode to HUDD data object * Add Dashed Lanes to HUD * Adjust HDD object * return LKAS var in CarState * Return LK var to CS * Syntax error fix * Update carcontroller.py * testing hud object hardcoded hud_lanes and lkMode * Restore accidentally deleted steer command * Update carcontroller.py * Update carcontroller.py * Don't show solid lanes if OP steering disabled * Dashed lines fix during engagement eliminate steering alert when lkas disabled lkas button logic cleanup Reverse the dashed-lane indicator No steering alert if LKAS disabled revert Alert - LKAS errors during steer disable Disable audible alert when steering disabled Delete CS.aEgo < -0.5 override condition * Remove chime disable when steering overriden One bar profile change to 1.8s if < 65 kph Simplified chime instead of beep disable for LK override * Adjust BRAKE_STOPPING_TARGET to 0.25 Keeps the brake pump from going crazy at a stop * Add relative velocity to auto distance for 1 bar setting (#26) * CAMERA_OFFSET = 0.08 * Revert Cost_long to comma value of 0.1 * Do not override to 1.8s when accel from stop * Update logic for override distance bars * Override distance when < 65kph and v_rel not > 5 * Use rel acceleration to reset to 1 bar * Use vRel * Update planner.py * v_lead - vEgo > 1 * vLead - vEgo = -1 * vLead-vEgo < -1.5 * Cleanup Arne's code for distance * vLead - vEgo < 1.25 * Back to vLead - vEgo < -1 * Disable OP steering and audio alarm when blinkers on (#28) * LKAS disable when blinkers are on * Update carcontroller.py * Update carcontroller.py * fix syntax error * Critical alarm if cruise disengages while braking (#32) * Update pathplanner.py * Loud alert in case cruise disables when braking * re-add if statement on speed for loud alert * Update interface.py * increase stopping distance to car by 1.5m * Increase stopping distance to 2m * Revert CAMERA_OFFSET to 0.06 (comma default) * Lane width reduction to 2.85m * Reduce tailgating for one bar distance at surface street speeds & code cleanup (#43) * Gernby's Lane width filter fix (#41) * Fix lane width filtering * Fixed lane width filtering * CAMERA_OFFSET = 0.08 * Minimum distance for one bar distance setting * Don't tailgate at slow speeds with 1 bar distance * x_lead < 5 only * x_lead < 5 syntax fix * self.v_rel < -1 or (x_lead < 10 and self.v_rel >= -1 and self.v_rel < 1) * Tail gating auto distance change * x_lead < 7.5 and self.v_rel >= -1 and self.v_rel < 0.2 * self.lastTR > 0 re-adding reinitialization * Revert "Gernby's Lane width filter fix (#41)" This reverts commit d081cfd8a05d2eb32e0148d477c806e65662dea7. * Increase min distance to 10m for auto distance * Auto distance code cleanup * Add lead car fast approaching autodistance * Auto distance Code cleanup * Don't re-initialize MPC if already initialized * self.lastTR != instead of > * Initialize TR = 1.8 * include if statements vs just assigning boolean * switch to 1 and 0 for TRUE AND FALSE * Revert "switch to 1 and 0 for TRUE AND FALSE" This reverts commit 58dcf718cdc3fca636229bf29942669670cb4487. * Revert "include if statements vs just assigning boolean" This reverts commit da7b5fa5088d62e78ba57d9e4c01e89160e77b9e. * Revert "Initialize TR = 1.8" This reverts commit f9c2571faeb0acaab818bcff146a2a397c0f07ff. * Initialize TR=1.8 inside override loop * Cleanup TR assignment for override loop * Code Cleanup * Syntax error * Syntax error * if statements for autodistance vars * tr-last assignment indent * CS.readdistancelines assignment to self.tr_last * remove else MPC init * Flatten out elif ladder for autodistance * Removed shrinking_fast stopping for now Braking is too sudden with 3 bar distance when radar detects car. Shrinking gap takes care of this with 2 bar distance. * Code Cleanup * Revert CAMERA_OFFSET to Comma default of 0.06 * Merge Gernby's Resonant Steering (#51) * Learn_angle_steer min max increased to +/-7 degs * Increase min one bar distance to 12m for autodist * Merge Gernby's Feed-Forward-Accel-Rate Branch (#49) * Fixed feed-forward to consider steer_offset * fixed a small oops on types * Testing strategies for zero-crossing * Moved angle stat collection to latcontrol.py * First version that runs * added outbound interface for feed-forward table * First working * Added more metrics * Adjusted parameter timing * performance tweaks * Cleanup * untested tweaks * minor tweaks * many untested changes * going the other way with some things... * Best yet * cleaned up personalized "stuff" * more cleanup for general use * untested: minor adjustment to further reduce noise * Fixed defect in desired angle interpolation * some cleanup * reverted change to Ki * Reverted changes to manager.py * Added steering rate consideration to latcontrol * cleaned up for PR * Fixed merge * Testing approach when desired angle close to actual * trying rate-based feed-forward * added self-tuning parms for rate and angle FF * fixed trim logic, and persisted to flash * working amazingly well * decreased time lapse for angle-based FF adjust * many tweaks, self-tuning is a bitch * simulteneous dual mode feedforward working very well * added angular accelleration limit * added super awesome angular accel limit * non-specific save * switching directions again * oops * ugly code with amazing results * awesome, but untested after some cleanup * more cleanup * cleanup of the cleanup? Need to test * works amazingly well ... big O face * cleanup * I wish git was batter for cleanup * removed Steer Offset because Pilot no likey * Increase tailgating 1 bar resume to 0.5 m/s * Gernby's resonant steering v2 * fixed an oops for non-bosch hondas * CAMERA_OFFSET = 0.08 * More conservative tailgating distance and resume * More conservative auto-distance for 1 bar setting * Revert CAMERA_OFFSET to 0.06 * Revert auto-distance for 1 bar distance setting * Revert "Merge Gernby's Resonant Steering" (#53) * Revert "Revert auto-distance for 1 bar distance setting" This reverts commit b7e5fb5. * Revert "Revert CAMERA_OFFSET to 0.06" This reverts commit 05cf21d. * Revert "Merge Gernby's Resonant Steering (#51)" This reverts commit d35aa19. * better crowned road centering: learn_angle +/-7 * slightly harder braking when tailgating * Merge Gernby's Resonant FF steering (#62) * Fixed feed-forward to consider steer_offset * fixed a small oops on types * Testing strategies for zero-crossing * Moved angle stat collection to latcontrol.py * First version that runs * added outbound interface for feed-forward table * First working * Added more metrics * Adjusted parameter timing * performance tweaks * Cleanup * untested tweaks * minor tweaks * many untested changes * going the other way with some things... * Best yet * cleaned up personalized "stuff" * more cleanup for general use * untested: minor adjustment to further reduce noise * Fixed defect in desired angle interpolation * some cleanup * reverted change to Ki * Reverted changes to manager.py * Added steering rate consideration to latcontrol * cleaned up for PR * Fixed merge * Testing approach when desired angle close to actual * trying rate-based feed-forward * added self-tuning parms for rate and angle FF * fixed trim logic, and persisted to flash * working amazingly well * decreased time lapse for angle-based FF adjust * many tweaks, self-tuning is a bitch * simulteneous dual mode feedforward working very well * added angular accelleration limit * added super awesome angular accel limit * non-specific save * switching directions again * oops * ugly code with amazing results * awesome, but untested after some cleanup * more cleanup * cleanup of the cleanup? Need to test * works amazingly well ... big O face * cleanup * I wish git was batter for cleanup * hopefully proper merge of merged fixes of merge * fixed an oops for non-bosch hondas * added steer rate to future state calculation * added actual acceleration to future projected state * fixed projected angle error for PIF * untested ... * added comments * Boost kF for pilot by 30% * x_lead < 7.5 or (x_lead < 17.5 and self.v_rel < 1) * x_lead < 7.5 or (x_lead < 17.5 and self.v_rel < 0.5) * if x_lead < 5 or (x_lead < 17.5 and self.v_rel < 0.5) * Boost KF for all * x_lead < 17.5 and self.v_rel < 0.75 * x_lead < 5 or (x_lead < 17.5 and self.v_rel < 0.5) * more conservative kF for Civics * Civic kF 0.00003 - Pilot kF 0.000078 * Revert Civic kF values to default * x_lead < 6 or (x_lead < 17.5 and self.v_rel < 0.5) * Proper alerts on Eon and disable flashing HUD alert when blinkers on or LKAS off (#63) * Disable steer alert when LKAS off * Display steering unavailable on Eon when LKAS off * Revert chime disable in favor of new method * x_lead < 6 or (x_lead < 17.5 and self.v_rel < 0.5) * logic correction on HUD alert * blinkers on disables HUD alarm * Add Manual Steering alert for LKAS Off mode * Call manual steering alert when LKAS off * Call blinkers alert when blinkers on * Add blinkers alert * Adjust Blinkers alert logic to include LKAS mode * Fix blinker logic * Add new steering required alerts to capnp * Trace LKAS / LDW error * Disable hud alert when LKAS off or blinkers on * Disable HUD alerts if LKAS off or blinkers on * Disable other ACC alert if LKAS off or blinkers on * Revert testing of steering required alert override * Disable steer saturate alert if blinkers on or LKAS off * Disable steer sat alert if LKAS off or blinkers on * Revert steerSaturated logic * disable steer limit alert when LKAS off or blinkers on * Fix Syntax error * Revert steerLimit alert disable * Disable steerSat alert when blinkers on or LKAS off * Revert stopping distance to default for pedal lurch * Re-intro 2m stopping distance * Reduce steerKpV for Civics by 20% for Gernby FF steering * Reduce kPV for civic v2 * Reduce Civic kP further * Merge Gernby's latest Feed forward resonant (#68) * Fixed feed-forward to consider steer_offset * fixed a small oops on types * Testing strategies for zero-crossing * Moved angle stat collection to latcontrol.py * First version that runs * added outbound interface for feed-forward table * First working * Added more metrics * Adjusted parameter timing * performance tweaks * Cleanup * untested tweaks * minor tweaks * many untested changes * going the other way with some things... * Best yet * cleaned up personalized "stuff" * more cleanup for general use * untested: minor adjustment to further reduce noise * Fixed defect in desired angle interpolation * some cleanup * reverted change to Ki * Reverted changes to manager.py * Added steering rate consideration to latcontrol * cleaned up for PR * Fixed merge * Testing approach when desired angle close to actual * trying rate-based feed-forward * added self-tuning parms for rate and angle FF * fixed trim logic, and persisted to flash * working amazingly well * decreased time lapse for angle-based FF adjust * many tweaks, self-tuning is a bitch * simulteneous dual mode feedforward working very well * added angular accelleration limit * added super awesome angular accel limit * non-specific save * switching directions again * oops * ugly code with amazing results * awesome, but untested after some cleanup * more cleanup * cleanup of the cleanup? Need to test * works amazingly well ... big O face * cleanup * I wish git was batter for cleanup * hopefully proper merge of merged fixes of merge * fixed an oops for non-bosch hondas * added steer rate to future state calculation * added actual acceleration to future projected state * fixed projected angle error for PIF * untested ... * added comments * completely UNtested * untested merge * battling shitty git * git is sucking giant monkey balls * Trying to figure out what git did... * still trying to un-git myself * Finally got it fixed, works awesome! * Hopefully not corrupted by git * hopefully fixed white space corruption * working again, hopefully resolved git issue * Revert "Implement csouers 67-70% charging to preserve batt" This reverts commit e3249be. * Revert "Implement csouers 67-70% charging to preserve batt" This reverts commit e3249be. * Prevent lurching from stop with Comma Pedal * Prevent lurching from stop with Comma Pedal 2 * Dev UI from P Lee * delete print() statements * LaC.lateral_error = 1.0 * np.clip..... * Pedal lurch prevention v4 * Increase 1 bar city tailing distance by 1 m * More conservative braking in city for 1 and 2 bar distance * Revert "LaC.lateral_error = 1.0 * np.clip....." This reverts commit 82b9ff9. * Pedal lurch prevention v5 * 1 or 2 bar: more conservative braking * Revert "Reduce Civic kP further" This reverts commit af9bb3f. * Revert "Reduce kPV for civic v2" This reverts commit 84e25f3. * Revert "Reduce steerKpV for Civics by 20% for Gernby FF steering" This reverts commit 083741a. * Revert "Revert Civic kF values to default" This reverts commit 2d5ee5e. * Revert "Civic kF 0.00003 - Pilot kF 0.000078" This reverts commit c9434f3. * Revert "more conservative kF for Civics" This reverts commit 61613c2. * Revert "Boost KF for all" This reverts commit 8858f51. * Revert "Boost kF for pilot by 30%" This reverts commit d7220b2. * Revert "Merge Gernby's Resonant FF steering (#62)" This reverts commit 234e57d. * Merge with kegman-gernbyFFsteer-latest (#69) * Honda Pilot PID Tuning * Adjustable Follow Distance w/HUD (#12) * TR * TR * TR * TR * TR * TR * TR * TR * remove readdistancelines - causes boot error * copying cereal * arne's cereal * HUD distance lines display * capnpp add * revert * revert * Set ACC HUD to KPH * Test - set HUD_ACC distance line to 2 * revert cruise_kph LKAS error * TR * TR * TR * TR * TR * TR * TR * TR * remove readdistancelines - causes boot error * copying cereal * HUD distance lines display * capnpp add * revert * revert * Set ACC HUD to KPH * Test - set HUD_ACC distance line to 2 * revert cruise_kph LKAS error * Remove custom btn var line could be crashing the code when button pressed * HUD distance lines * HUD distance lines * passing CS.CP.readdistancelines * Hardcode hud object dist_lines var * Initializes CS.readdistancelines before passing to hud obj * use integer read_distance_lines instead * Add HUD_DISTANCE_3 for horizontal HUD bars on dash * Default to 2 bars follow distance (1.8s) * Code Cleanup for Distance Adjustment Cleanup Cleanup Cleanup Cleanup Cleanup Cleanup Cleanup Cleanup Cleanup * Auto-distance at surface street speeds Override short distance setting when slow Override distance when slow Override distance if slow Override distance when slow Override distance when slow Increase follow distance when below 60 kph Lead car and rel. velocity to distance override Override distance bars revert Override and restore dist based on speed and accel Step up distance when < 40 km/h and restore Revert When using 1 bar distance: Slow the car down earlier and more aggressively (#18) * Change one bar braking profile to 3 bars * Update planner.py * Update planner.py * Update planner.py * Update planner.py * Update planner.py * Update planner.py * Update planner.py * Update planner.py * fake lead car vars * fake lead vars * Auto Distance Bar Working - tuning values * Logging to log.txt * Override hysteresis for one bar follow * Only set override when decelerating * syntax error fix for override flag * Switch to 1.8s for softer braking * Revert "Switch to 1.8s for softer braking" This reverts commit d53623062ef814509db925fe4e624c3ae8aff1f1. * Disable OTA update for safety * Physical LKAS button disables OP steer and shows dashed lines on HUD (#19) * Change one bar braking profile to 3 bars * Update planner.py * Update planner.py * Update planner.py * Update planner.py * Update planner.py * Update planner.py * Update planner.py * Update planner.py * fake lead car vars * fake lead vars * Auto Distance Bar Working - tuning values * Logging to log.txt * Override hysteresis for one bar follow * Only set override when decelerating * syntax error fix for override flag * Switch to 1.8s for softer braking * Disable LKAS * Apply Steer = 0 when user presses LKAS button * Add Lkas button * Add LK mode to HUDD data object * Add Dashed Lanes to HUD * Adjust HDD object * return LKAS var in CarState * Return LK var to CS * Syntax error fix * Update carcontroller.py * testing hud object hardcoded hud_lanes and lkMode * Restore accidentally deleted steer command * Update carcontroller.py * Update carcontroller.py * Don't show solid lanes if OP steering disabled * Dashed lines fix during engagement eliminate steering alert when lkas disabled lkas button logic cleanup Reverse the dashed-lane indicator No steering alert if LKAS disabled revert Alert - LKAS errors during steer disable Disable audible alert when steering disabled Delete CS.aEgo < -0.5 override condition * Remove chime disable when steering overriden One bar profile change to 1.8s if < 65 kph Simplified chime instead of beep disable for LK override * Adjust BRAKE_STOPPING_TARGET to 0.25 Keeps the brake pump from going crazy at a stop * Add relative velocity to auto distance for 1 bar setting (#26) * CAMERA_OFFSET = 0.08 * Revert Cost_long to comma value of 0.1 * Do not override to 1.8s when accel from stop * Update logic for override distance bars * Override distance when < 65kph and v_rel not > 5 * Use rel acceleration to reset to 1 bar * Use vRel * Update planner.py * v_lead - vEgo > 1 * vLead - vEgo = -1 * vLead-vEgo < -1.5 * Cleanup Arne's code for distance * vLead - vEgo < 1.25 * Back to vLead - vEgo < -1 * Disable OP steering and audio alarm when blinkers on (#28) * LKAS disable when blinkers are on * Update carcontroller.py * Update carcontroller.py * fix syntax error * Critical alarm if cruise disengages while braking (#32) * Update pathplanner.py * Loud alert in case cruise disables when braking * re-add if statement on speed for loud alert * Update interface.py * increase stopping distance to car by 1.5m * Increase stopping distance to 2m * Revert CAMERA_OFFSET to 0.06 (comma default) * Lane width reduction to 2.85m * Reduce tailgating for one bar distance at surface street speeds & code cleanup (#43) * Gernby's Lane width filter fix (#41) * Fix lane width filtering * Fixed lane width filtering * CAMERA_OFFSET = 0.08 * Minimum distance for one bar distance setting * Don't tailgate at slow speeds with 1 bar distance * x_lead < 5 only * x_lead < 5 syntax fix * self.v_rel < -1 or (x_lead < 10 and self.v_rel >= -1 and self.v_rel < 1) * Tail gating auto distance change * x_lead < 7.5 and self.v_rel >= -1 and self.v_rel < 0.2 * self.lastTR > 0 re-adding reinitialization * Revert "Gernby's Lane width filter fix (#41)" This reverts commit d081cfd8a05d2eb32e0148d477c806e65662dea7. * Increase min distance to 10m for auto distance * Auto distance code cleanup * Add lead car fast approaching autodistance * Auto distance Code cleanup * Don't re-initialize MPC if already initialized * self.lastTR != instead of > * Initialize TR = 1.8 * include if statements vs just assigning boolean * switch to 1 and 0 for TRUE AND FALSE * Revert "switch to 1 and 0 for TRUE AND FALSE" This reverts commit 58dcf718cdc3fca636229bf29942669670cb4487. * Revert "include if statements vs just assigning boolean" This reverts commit da7b5fa5088d62e78ba57d9e4c01e89160e77b9e. * Revert "Initialize TR = 1.8" This reverts commit f9c2571faeb0acaab818bcff146a2a397c0f07ff. * Initialize TR=1.8 inside override loop * Cleanup TR assignment for override loop * Code Cleanup * Syntax error * Syntax error * if statements for autodistance vars * tr-last assignment indent * CS.readdistancelines assignment to self.tr_last * remove else MPC init * Flatten out elif ladder for autodistance * Removed shrinking_fast stopping for now Braking is too sudden with 3 bar distance when radar detects car. Shrinking gap takes care of this with 2 bar distance. * Code Cleanup * Revert CAMERA_OFFSET to Comma default of 0.06 * Merge Gernby's Resonant Steering (#51) * Learn_angle_steer min max increased to +/-7 degs * Increase min one bar distance to 12m for autodist * Merge Gernby's Feed-Forward-Accel-Rate Branch (#49) * Fixed feed-forward to consider steer_offset * fixed a small oops on types * Testing strategies for zero-crossing * Moved angle stat collection to latcontrol.py * First version that runs * added outbound interface for feed-forward table * First working * Added more metrics * Adjusted parameter timing * performance tweaks * Cleanup * untested tweaks * minor tweaks * many untested changes * going the other way with some things... * Best yet * cleaned up personalized "stuff" * more cleanup for general use * untested: minor adjustment to further reduce noise * Fixed defect in desired angle interpolation * some cleanup * reverted change to Ki * Reverted changes to manager.py * Added steering rate consideration to latcontrol * cleaned up for PR * Fixed merge * Testing approach when desired angle close to actual * trying rate-based feed-forward * added self-tuning parms for rate and angle FF * fixed trim logic, and persisted to flash * working amazingly well * decreased time lapse for angle-based FF adjust * many tweaks, self-tuning is a bitch * simulteneous dual mode feedforward working very well * added angular accelleration limit * added super awesome angular accel limit * non-specific save * switching directions again * oops * ugly code with amazing results * awesome, but untested after some cleanup * more cleanup * cleanup of the cleanup? Need to test * works amazingly well ... big O face * cleanup * I wish git was batter for cleanup * removed Steer Offset because Pilot no likey * Increase tailgating 1 bar resume to 0.5 m/s * Gernby's resonant steering v2 * fixed an oops for non-bosch hondas * CAMERA_OFFSET = 0.08 * More conservative tailgating distance and resume * More conservative auto-distance for 1 bar setting * Revert CAMERA_OFFSET to 0.06 * Revert auto-distance for 1 bar distance setting * Revert "Merge Gernby's Resonant Steering" (#53) * Revert "Revert auto-distance for 1 bar distance setting" This reverts commit b7e5fb5. * Revert "Revert CAMERA_OFFSET to 0.06" This reverts commit 05cf21d. * Revert "Merge Gernby's Resonant Steering (#51)" This reverts commit d35aa19. * better crowned road centering: learn_angle +/-7 * Implement csouers 67-70% charging to preserve batt * slightly harder braking when tailgating * x_lead < 5 or (x_lead < 17.5 and self.v_rel < 0.5) * Proper alerts on Eon and disable flashing HUD alert when blinkers on or LKAS off (#63) * Disable steer alert when LKAS off * Display steering unavailable on Eon when LKAS off * Revert chime disable in favor of new method * x_lead < 6 or (x_lead < 17.5 and self.v_rel < 0.5) * logic correction on HUD alert * blinkers on disables HUD alarm * Add Manual Steering alert for LKAS Off mode * Call manual steering alert when LKAS off * Call blinkers alert when blinkers on * Add blinkers alert * Adjust Blinkers alert logic to include LKAS mode * Fix blinker logic * Add new steering required alerts to capnp * Trace LKAS / LDW error * Disable hud alert when LKAS off or blinkers on * Disable HUD alerts if LKAS off or blinkers on * Disable other ACC alert if LKAS off or blinkers on * Revert testing of steering required alert override * Disable steer saturate alert if blinkers on or LKAS off * Disable steer sat alert if LKAS off or blinkers on * Revert steerSaturated logic * disable steer limit alert when LKAS off or blinkers on * Fix Syntax error * Revert steerLimit alert disable * Disable steerSat alert when blinkers on or LKAS off * Revert stopping distance to default for pedal lurch * Re-intro 2m stopping distance * x_lead = 6 * Merge Gernby's latest Feed forward resonant (#68) * Fixed feed-forward to consider steer_offset * fixed a small oops on types * Testing strategies for zero-crossing * Moved angle stat collection to latcontrol.py * First version that runs * added outbound interface for feed-forward table * First working * Added more metrics * Adjusted parameter timing * performance tweaks * Cleanup * untested tweaks * minor tweaks * many untested changes * going the other way with some things... * Best yet * cleaned up personalized "stuff" * more cleanup for general use * untested: minor adjustment to further reduce noise * Fixed defect in desired angle interpolation * some cleanup * reverted change to Ki * Reverted changes to manager.py * Added steering rate consideration to latcontrol * cleaned up for PR * Fixed merge * Testing approach when desired angle close to actual * trying rate-based feed-forward * added self-tuning parms for rate and angle FF * fixed trim logic, and persisted to flash * working amazingly well * decreased time lapse for angle-based FF adjust * many tweaks, self-tuning is a bitch * simulteneous dual mode feedforward working very well * added angular accelleration limit * added super awesome angular accel limit * non-specific save * switching directions again * oops * ugly code with amazing results * awesome, but untested after some cleanup * more cleanup * cleanup of the cleanup? Need to test * works amazingly well ... big O face * cleanup * I wish git was batter for cleanup * hopefully proper merge of merged fixes of merge * fixed an oops for non-bosch hondas * added steer rate to future state calculation * added actual acceleration to future projected state * fixed projected angle error for PIF * untested ... * added comments * completely UNtested * untested merge * battling shitty git * git is sucking giant monkey balls * Trying to figure out what git did... * still trying to un-git myself * Finally got it fixed, works awesome! * Hopefully not corrupted by git * hopefully fixed white space corruption * working again, hopefully resolved git issue * Revert "Implement csouers 67-70% charging to preserve batt" This reverts commit e3249be. * Revert "Merge with kegman-gernbyFFsteer-latest (#69)" This reverts commit 99031cf. * Pedal lurch prevention v6 * Pedal lurch prevention v7 * Revert visiond back to 0.5.6 * Revert to 0.5.6 visiond * Brake sooner if approaching a car fast * Pedal lurch prevention v8 - almost there * Even more conservative braking for 2 and 3 bars * Pedal lurch prevention v9 * 1 bar and 2 bar tuning * syntax error 1 bar / 2 bar tuning * Revert "syntax error 1 bar / 2 bar tuning" This reverts commit eb4bbe1. * Revert "1 bar and 2 bar tuning" This reverts commit 663ece1. * Revert "Even more conservative braking for 2 and 3 bars" This reverts commit 4bb4cf9. * Revert "Brake sooner if approaching a car fast" This reverts commit 1ff5347. * Revert "1 or 2 bar: more conservative braking" This reverts commit 0959a0b. * Revert "More conservative braking in city for 1 and 2 bar distance" This reverts commit dbae46d. * Pedal lurch prevention v10 * Lurch prevention v11 * BRAKE_STOPPING_TARGET reduced to 0.1 from 0.25 * visiond-wiggly 0.5.4 * visiond 0.5.6 * Fix comma pedal grinding noise when braking commit 5dd7fb3dbe01c8854eb4784080cf7108fc970cb9 Date: Wed Dec 19 19:34:55 2018 -0500 Revert "BRAKE_STOPPING_TARGET reduced to 0.1 from 0.25" This reverts commit b0d75c5. commit f5cec844471cd4eb650450d88e6118ff818d5edb Date: Wed Dec 19 19:34:16 2018 -0500 Revert "BRAKE_STOPPING_TARGET to 0.0" This reverts commit 7a6b3a67826dd1fd5b942b06eb7c1d15b0f3c23a. commit 1e07b857438aaf983e36f45aa3653ab61aadc17f Date: Wed Dec 19 00:38:09 2018 -0500 Update carstate.py commit f6b3ba0696f5192167780579a9daa05a39bd30e2 Date: Wed Dec 19 00:33:54 2018 -0500 Pedal grind further Code cleanup commit 0afbcd38396ffd863d963194dda8ddb8e9f2bf02 Date: Wed Dec 19 00:16:15 2018 -0500 Pedal Grinding further code cleanup commit 33b4ce0e38441463846d593861183f96a154e11e Date: Tue Dec 18 16:48:03 2018 -0500 Grinding noise code cleanup commit f6edcfacd22fe503330adcd0bef2b9aa9a742838 Date: Tue Dec 18 16:19:25 2018 -0500 Fix Syntax error commit 2a74863cf4e6d93e3b390d41fa427243f28ebdfa Date: Tue Dec 18 16:12:46 2018 -0500 Pedal noise mitigation v1 commit 7a6b3a67826dd1fd5b942b06eb7c1d15b0f3c23a Date: Tue Dec 18 10:53:11 2018 -0500 BRAKE_STOPPING_TARGET to 0.0 * Revert "Fix comma pedal grinding noise when braking" This reverts commit 454b918. * Fix Pedal Grinding noise (#70) * BRAKE_STOPPING_TARGET to 0.0 * Pedal noise mitigation v1 * Fix Syntax error * Grinding noise code cleanup * Pedal Grinding further code cleanup * Pedal grind further Code cleanup * Update carstate.py * Revert "BRAKE_STOPPING_TARGET to 0.0" This reverts commit 7a6b3a67826dd1fd5b942b06eb7c1d15b0f3c23a. * Revert "BRAKE_STOPPING_TARGET reduced to 0.1 from 0.25" This reverts commit b0d75c5. * Add visiond.057 * Revert "Merge branch 'kegman-devel' of https://github.com/kegman/openpilot into kegman-devel" This reverts commit 612695b, reversing changes made to 6531ed2. * Fix Comma Pedal Grinding sound when braking commit 5dd7fb3dbe01c8854eb4784080cf7108fc970cb9 Date: Wed Dec 19 19:34:55 2018 -0500 Revert "BRAKE_STOPPING_TARGET reduced to 0.1 from 0.25" This reverts commit b0d75c5. commit f5cec844471cd4eb650450d88e6118ff818d5edb Date: Wed Dec 19 19:34:16 2018 -0500 Revert "BRAKE_STOPPING_TARGET to 0.0" This reverts commit 7a6b3a67826dd1fd5b942b06eb7c1d15b0f3c23a. commit 1e07b857438aaf983e36f45aa3653ab61aadc17f Date: Wed Dec 19 00:38:09 2018 -0500 Update carstate.py commit f6b3ba0696f5192167780579a9daa05a39bd30e2 Date: Wed Dec 19 00:33:54 2018 -0500 Pedal grind further Code cleanup commit 0afbcd38396ffd863d963194dda8ddb8e9f2bf02 Date: Wed Dec 19 00:16:15 2018 -0500 Pedal Grinding further code cleanup commit 33b4ce0e38441463846d593861183f96a154e11e Date: Tue Dec 18 16:48:03 2018 -0500 Grinding noise code cleanup commit f6edcfacd22fe503330adcd0bef2b9aa9a742838 Date: Tue Dec 18 16:19:25 2018 -0500 Fix Syntax error commit 2a74863cf4e6d93e3b390d41fa427243f28ebdfa Date: Tue Dec 18 16:12:46 2018 -0500 Pedal noise mitigation v1 commit 7a6b3a67826dd1fd5b942b06eb7c1d15b0f3c23a Date: Tue Dec 18 10:53:11 2018 -0500 BRAKE_STOPPING_TARGET to 0.0 * Simplified pedal grinding noise fix code * Grinding noise fix applied only to Honda Pilots * Indent fix * self.CP * Tweak braking for 1 / 2 bar distance and Fix Grinding for Pilot only (#71) * Tweaks to 1 and 2 bar distance braking * Code cleanup * Apply grinding fix for Honda Pilot only * Indent fix * self.CP * Revert "Merge branch 'kegman-gernbyFFsteer-latest' into kegman-devel" This reverts commit 78fa3e4, reversing changes made to 0171235.
avolmensky
pushed a commit
to avolmensky/openpilot
that referenced
this issue
Jun 10, 2019
Kiril-Lange
pushed a commit
to Kiril-Lange/openpilot
that referenced
this issue
Mar 6, 2020
mcomg
pushed a commit
to mcomg/openpilot---jpancotti
that referenced
this issue
Jun 27, 2020
speedTooHigh should not be an immediate disable
|
FYI. I am trying to port op to my google pixel 1. It took a lot of effects to get camerad running on AOSP (android 8.1, google officially provided). p1 is equipped with imx378 and imx179 cameras. There is no ois in imx378, and the actuator is a different one, I am able to set pos/move focus. But the auto focus feature is not working yet. Talking about the camera differences mentioned by geohotz, the lane lines it not 100% match with roads when the phone is in the center of the wind shield. I think this is due to the resolution I chose and the lens of the camera. Do not know if I will get better after calibration. Anyway, if I tilt the phone a little, the lines can be perfectly matched.
|
weimou
pushed a commit
to SFtoLA/openpilot
that referenced
this issue
May 6, 2021
mostafaayesh
pushed a commit
to mostafaayesh/openpilot
that referenced
this issue
May 29, 2022
mostafaayesh
pushed a commit
to mostafaayesh/openpilot
that referenced
this issue
Jul 7, 2022
jnewb1
added a commit
that referenced
this issue
Dec 28, 2023
* update labeler * update labeler * update labeler * Update labeler (#63) * update labeler * update labeler * update labeler * fix that * Update labeler (#65) * update labeler * update labeler * update labeler * fix that * and that * Update labeler (#66) * update labeler * update labeler * update labeler * fix that * and that * fix that
carleeno
pushed a commit
to carleeno/openpilot
that referenced
this issue
Aug 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I think it could be interesting to port openpilot to some other hardware than the current Neo platform (OnePlus 3 or 3T) . Looks like all the essences are open source so this may actually not be of a big problem. However I myself have no experience in creating a custom Android ROM (=customizing NEOS). Anyone here interested in this topic? The general thought is openpilot could be used WITHOUT itself connecting to a car just as a front/lane assist (audible or visual warnings).
Parts:
https://github.com/commaai/neo
https://github.com/commaneos
https://github.com/commaai/openpilot
Such porting may help this project to really take off since now the HW options are very limited and if ported than people may use it (and TEST IT!!!) on a smartphone (or completely other HW platform) they already own and would not need to spend $400 or more for hardware.
I would try to support off-the-shelf and plug&play hardware - to allow install (ok I mean ROM flashing) on stock (smartphone) devices without the necessity to build the CAN hardware themselves. Some branded quality CAN dongles may be supported (OBDLink or OpenXC dongles etc.) just for reading the CAN bus when testing...
I think generally a greater HW abstraction on all levels is what this project needs.
The text was updated successfully, but these errors were encountered: