Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add fingerprint for 2017 civic sport touring hatchback #101

Closed
wants to merge 1 commit into from
Closed

add fingerprint for 2017 civic sport touring hatchback #101

wants to merge 1 commit into from

Conversation

eschmidbauer
Copy link

No description provided.

@geohot
Copy link
Contributor

geohot commented Jun 9, 2017 •
edited
Loading

Does this work? I thought there was a radar issue.

@eschmidbauer
Copy link
Author

There is still an issue with the radar but this at least adds the fingerprint so the mph and rear camera work

@geohot
Copy link
Contributor

geohot commented Jun 9, 2017

My concern here is that it's sending messages out on the CAN bus that the car isn't listening for. Modify it to disable sending unused messages and we can upstream.

@energee
Copy link
Contributor

energee commented Jun 20, 2017

This code is definitely still sending commands. Would it make sense to officially add read-only support to openpilot?

I have read-only code for some other cars without ACC/LKAS.

@geohot
Copy link
Contributor

geohot commented Jun 20, 2017

Yea, read only fingerprinting is good, just disable sends if we can't control the car.

@geohot
Copy link
Contributor

geohot commented Jun 26, 2017

If you disable sends when the fingerprint matches the hatchback, I'll merge this in.

@Raycomma
Copy link

Raycomma commented Jun 26, 2017 via email

@geohot
Copy link
Contributor

geohot commented Jun 26, 2017

Check for fingerprint match in CarController and return early.

@geohot geohot closed this Jun 28, 2017
geohot pushed a commit that referenced this pull request Apr 14, 2018
Squashed 'panda/' changes from 3125232..2253dd3
e6e6ad2 
2253dd3 fix volt ign detect
3b299d7 add ignition and refactor
af9af6d Merge pull request #110 from Jamezz/volt
13e850e more correct
f295063 add new define to tests
fec9758 gate that with debug
5516ebf one more ifdef
cac7b31 only panda has float
938d474 fpu enable
ffbf0c7 cleaner
de30f27 Revert "need f to not be double"
4142acf need f to not be double
3eb15c8 refactor to share code
a4c8b64 change to O2 to fix make recover
711fd11 Enable compiler optimizations, fix things it breaks
2e6f774 block IPAS in main toyota safety mode
e7a2b3a add ipas tests
894572c fix tests
367c9ad add safety toyota ipas
95919b9 Bounty: panda high quality CAN autobaud (#96)
6557cd2 Toyota Safety: allow controls only on rising edge of cruise_engaged
02c1ddf Revert "added steer override check when IPAS is in control (#106)"
9f925ba Fix the merge mess
23d3833 Merge from comma upstream
a0cc51a Undo safety mode override
ea1c1dc make wlan interface name generic
6dbd8c9 Implement WebUSB and upgrade WinUSB to 2.0 (#107)
4fc83a5 Add safety hook for ignition and have GM use gear selector to determine ignition
52b2ac0 switch from travis to circleci
48e2374 build panda esp image
065572a circleci build stm image
7a1f319 add panda python package test and fix safety test
021dde7 move saftey test helper files into safety folder
ce0545f add ci files
6a3307c no LIN over ELM
7d21acb added steer override check when IPAS is in control (#106)
1c88caf Safety code testing (#104)
f4efd1f Merge pull request #101 from adhintz/master
c02618b Merge pull request #102 from quillford/master
1ba5f8a added link to wiki for user scripts
de2b19e add support for multiple buses to can_unique and can_bittransition output data in sorted order.

git-subtree-dir: panda
git-subtree-split: 2253dd3
avolmensky pushed a commit to avolmensky/openpilot that referenced this pull request Jun 30, 2019
@geohot
Merge pull request commaai#101 from adhintz/master
f4efd1f 
add support for multiple buses to can_unique and can_bit_transition
pd0wm pushed a commit that referenced this pull request Nov 5, 2019
Squashed 'opendbc/' changes from f3b573559..c0eba096b
67c4121 
c0eba096b remove obsolete Subaru dbc file
f7bce9ee0 Fixes to vw dbc
adb672657 Added VW comment about ignition bit
c51631617 Fixes and new message for VW MQB, fix for Accord Touring (#193)
a09bf725e fixed to luxgen dbc file
f00f6289a Create luxgen_s5_2014.dbc (#101)
024612b20 Fix steer angle factor for toyota
7311ee70e Lexus is adjustment (#192)
f04ce577e Updates for Volkswagen support (#191)

git-subtree-dir: opendbc
git-subtree-split: c0eba096bc74033ea54abfd56406b5af3108727c
weimou pushed a commit to SFtoLA/openpilot that referenced this pull request May 6, 2021
@pd0wm @adeebshihadeh
Visionipc v2.0 (commaai#101)
95e3280 
* add visionbuf

make static

ignore that

* Needs decleration

* add test binary

* c++

* create some structure

* some impl

* socket stuff

* Accept socket connection

* Alloc some buffers

* Create pub sockets and send buffer id

* make listener private

* Implement receive

* use error check macros in cl_helpers

* constructors to pass in opencl context

* add some convenience values in struct

* refactor creating buffers

* rgb is not so simple

* add fake stride and expose buffers

* add comment

* add extra data struct

* support conflate

* init opencl on all buffers

* make ion compile

* fix qcom2

* correctly setup yuv pointers when importing buffer

* also included from c

* Remove send print statements

* send metadata

* reveive metadata

* also used in c code

* dont start listener automatically

* Was started in 2 places

* set 100ms timeout on socket

* verify server id to detect reconnects

* handle reconnect

* buffer cleanup

* let user handle opencl creation

* add default values

* Add support for aligned rgb buffers

* add align macro

* dont use namespace

* use poller

* apple ifdef in ipc.cc

* VisionBuf is C++ class

* Install opencl headers

* cppcheck c++

* remove c header guard

* fix mac build

* simplify constructors

* Update visionipc/visionipc.h

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>

* Update visionipc/visionbuf_ion.cc

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>

* add brackets

* s/VIPCBufExtra/VisionIpcBufExtra/g

* Add unittesting harness

* remove vipc demo

* very basic tests

* add conflate test

* Install opencl

* suppress msgq warnings

* Make it work using zmq

* cl in qcom replay

* run unittests in zmq mode as well

* non blocking connect

* always larger frame queues

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
MoreTore pushed a commit to MoreTore/openpilot that referenced this pull request Mar 2, 2024
@FrogAi
Merge pull request commaai#101 from mike86437/fleet-fix-non0-index
261a80d 
FM: fix video player when index does not start at 0
carleeno pushed a commit to carleeno/openpilot that referenced this pull request Aug 2, 2024
@sunnyhaibin
Sentry: set environment tag properly (commaai#101)
8c41f9a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@eschmidbauer @geohot @energee @Raycomma