Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix restricting video upload to wifi #192

Merged
merged 1 commit into from
Mar 17, 2018

Conversation

gregjhogan
Copy link
Member

looks like the issue is that it will start uploading video on WIFI and then if it gets disconnected from WIFI it continues to upload (using mobile data) until there is nothing left to upload

@geohot
Copy link
Contributor

geohot commented Mar 17, 2018

Will be fixed in release. I left the two while loops, and moved upload_video into the inner loop

@geohot geohot closed this Mar 17, 2018
@geohot geohot reopened this Mar 17, 2018
@geohot
Copy link
Contributor

geohot commented Mar 17, 2018

Oh, nevermind, this is cleaner :)

@geohot geohot merged commit ad3f0a3 into commaai:devel Mar 17, 2018
@billy2kool
Copy link

billy2kool commented Mar 17, 2018 via email

@billy2kool billy2kool mentioned this pull request Mar 21, 2018
pd0wm pushed a commit that referenced this pull request Jun 6, 2019
7f8babb Much more thorough limit safety tests on Honda, also switching long_controls_allowed
71099ef AddedToyota safety test around long_controls_allowed logic and fixed a bug
07fd31e added long_controls_allowed tests in GM
6ce580a added function to get/set long_controls_allowed
a2f93d4 update VERSION
380b7c7 Long allowed (#202)
09714e3 Toyota gas cancellation (#200)
436b203 Honda safety: fixed bug and properly abstracted gas_interceptor_detected variable
220cc8f Honda safety: this concludes the proper re-naming
a00a50c Honda safety: better naming
95b0109 Toyota: fixed regression safety tests
192fd05 Toyota safety: fixed rounding logic
0c5b220 Merge pull request #194 from commaai/refactor
b35f6ff legacy build is no longer supported
a06af9f always LIVE on EON
dc5979f LIVE on EON
0b26645 no EON by default
1906a4b panda now draws below 100mw in power save mode
e70b44a move that to main.c
dfce5f6 minor fixes, and no more autobaud
7f303e8 bump version to 1.3.0
96a7e31 a soothing blue in power save mode
a74f001 refactor power savings to depend on car started bit
386d5df can wake from sleep is removed, didn't work in the first place
881b1f4 not on pedal chip
0a9f8eb remove many ifdef PANDA
5069005 remove nested includes and include guards
3810452 WTF WHY WAS THIS SHIT PUT EVERYWHERE
3cf8db9 can.h always has CAN3
1f97c21 refactor pedal bootstub to use llcan
58ec63b oops, backward
6255097 new style power savings
6b282f1 tesla doesn't need a special LIN hook
1d24677 refactor #ifdef EON
d9306c5 NEO are no longer supported
4af036e fixup puts
2c1e5f6 the refactor continues
7517f2c remove ifdef PANDA from main
aec40ae remove fan, as it was only for NEO board
605bb27 fix bootstub build
c0f1f6e move things around for simplicity
f32f039 factor out clear_send
8221927 this is probably broken. refactor out llcan and clock
1114cb1 ELM327 safety mode: re use existing functions
cd104e2 Vin query msg is 0x7df
223323a Examples: fixed import bug
533d239 update price
4396fb9 Update jenkinsfile (#193)
1aa00c9 Misra c2012 (#192)
047bd72 fix tests and remove rev b support

git-subtree-dir: panda
git-subtree-split: 7f8babb
avolmensky pushed a commit to avolmensky/openpilot that referenced this pull request Jun 30, 2019
* Started making panda misra compliant: this fixes some of 12.1 warnings

* Also added a regression test for strict compiler warning
Chrispreilly pushed a commit to Chrispreilly/openpilot that referenced this pull request Jul 11, 2019
cfranyota pushed a commit to cfranyota/openpilot-retired that referenced this pull request Aug 19, 2019
pd0wm pushed a commit that referenced this pull request Nov 5, 2019
c0eba096b remove obsolete Subaru dbc file
f7bce9ee0 Fixes to vw dbc
adb672657 Added VW comment about ignition bit
c51631617 Fixes and new message for VW MQB, fix for Accord Touring (#193)
a09bf725e fixed to luxgen dbc file
f00f6289a Create luxgen_s5_2014.dbc (#101)
024612b20 Fix steer angle factor for toyota
7311ee70e Lexus is adjustment (#192)
f04ce577e Updates for Volkswagen support (#191)

git-subtree-dir: opendbc
git-subtree-split: c0eba096bc74033ea54abfd56406b5af3108727c
Chrispreilly pushed a commit to Chrispreilly/openpilot that referenced this pull request Nov 21, 2019
Force subaru to assume the stock camera is connected (commaai#849)
Maelstrom96 pushed a commit to Maelstrom96/openpilot that referenced this pull request Dec 15, 2019
TDIPWR pushed a commit to TDIPWR/openpilot that referenced this pull request Jan 27, 2020
dragonpilot referenced this pull request in dragonpilot-community/dragonpilot Apr 7, 2020
fix restricting video upload to wifi
@gregjhogan gregjhogan deleted the wifi-only-upload-fix branch January 8, 2021 05:46
mlocoteta pushed a commit to mlocoteta/openpilot that referenced this pull request Jul 17, 2023
* car docs: add additional supported cars in sunnypilot

* Update non-SCC models

* Update non-SCC required parts

* sync
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants