-
Notifications
You must be signed in to change notification settings - Fork 9.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
raise gm steer delta to match max torque #426
Closed
Closed
Changes from all commits
Commits
Show all changes
87 commits
Select commit
Hold shift + click to select a range
16d9f55
Update values.py
CryptoKylan 98d37b9
Update values.py
CryptoKylan e5fcf3a
added 2018 gmc acadia fingerprint
CryptoKylan 1abf00b
updated properly with acadia as own class
CryptoKylan e35e98f
FIXED SPACING
CryptoKylan 14dcdde
ONE MORE FIX
CryptoKylan 4ebd3b9
Update carcontroller.py
CryptoKylan 1f82e15
Update carstate.py
CryptoKylan 33a9a0c
Update interface.py
CryptoKylan 8cfb5e3
Update radar_interface.py
CryptoKylan 51a23e2
Update carstate.py
CryptoKylan 233241e
Update carstate.py
CryptoKylan 196b932
Update interface.py
CryptoKylan 4bcb9c7
Update interface.py
CryptoKylan ec4e4e2
Update interface.py
CryptoKylan 33a222a
Update carcontroller.py
CryptoKylan 243a53f
Update carstate.py
CryptoKylan f466648
Update interface.py
CryptoKylan bdaf492
Update radar_interface.py
CryptoKylan e3ddd9d
Update values.py
CryptoKylan dc2bf65
Update values.py
CryptoKylan 520ffbc
Update values.py
CryptoKylan f0ba896
Update values.py
CryptoKylan 105b010
Update carcontroller.py
CryptoKylan 3d4d4ce
Update carcontroller.py
CryptoKylan d1a54bb
Merge pull request #1 from commaai/devel
CryptoKylan f91c8ff
Merge pull request #2 from commaai/devel
CryptoKylan f310f8a
Merge pull request #3 from commaai/devel
CryptoKylan d52db46
Update safety_gm.h
CryptoKylan 31dc6e2
mistake
CryptoKylan dd139b0
Merge pull request #8 from commaai/devel
CryptoKylan 34ccd7f
reverting changes
CryptoKylan 0a4001d
Update values.py
CryptoKylan 76564ef
Merge pull request #9 from CryptoKylan/malibu
CryptoKylan 3fdcb56
added acadia tuning
CryptoKylan 0b7fe50
Update carstate.py
CryptoKylan 8563bf8
Update values.py
CryptoKylan 2301ed6
Update carcontroller.py
CryptoKylan 1956806
Merge pull request #10 from CryptoKylan/Acadia
CryptoKylan 37e3f90
fixed tuning
CryptoKylan 56f6ef8
updating to working settings
CryptoKylan 53a460b
updated with working settings
CryptoKylan 0e91f58
Update carstate.py
CryptoKylan 1e357e3
Update carstate.py
CryptoKylan 0dfd07a
Update interface.py
CryptoKylan 0a9e14e
removed space
CryptoKylan d4c2034
fixed weight
CryptoKylan 4f16479
corrected steer settings to stock lkas
CryptoKylan a0d64c6
fixed min speed comment
CryptoKylan 9d45b53
Merge pull request #16 from commaai/devel
CryptoKylan 29a7989
Update carcontroller.py
CryptoKylan fc5c5c9
Update carcontroller.py
CryptoKylan a3f5a3e
Update carcontroller.py
CryptoKylan 0e38f8f
tuning
CryptoKylan 149ee69
stock msgs
CryptoKylan cda3dea
Merge pull request #22 from commaai/devel
CryptoKylan 69060ee
Create gm_global_acadia_denali_2018.dbc
CryptoKylan 03e38d1
Update values.py
CryptoKylan 70a6880
Rename gm_global_acadia_denali_2018.dbc to gm_global_acadia_denali_20…
CryptoKylan 00b116f
Merge pull request #25 from commaai/devel
CryptoKylan b6f28ac
Merge pull request #28 from commaai/devel
CryptoKylan 545a219
Update pathplanner.py
CryptoKylan a093e4a
Merge pull request #33 from commaai/devel
CryptoKylan 74e52c3
Update interface.py
CryptoKylan e17f68c
Update carcontroller.py
CryptoKylan ce4b0c7
Delete gm_global_acadia_denali_2018_powertrain.dbc
CryptoKylan 9508648
Update carstate.py
CryptoKylan ca309e3
Update radar_interface.py
CryptoKylan c26241f
Update values.py
CryptoKylan 9d2569b
Update radar_interface.py
CryptoKylan b10a2d3
Update carstate.py
CryptoKylan bec141e
Update carstate.py
CryptoKylan 8e51aaf
Update radar_interface.py
CryptoKylan abb4b37
Update radar_interface.py
CryptoKylan dcd3e03
Update carstate.py
CryptoKylan 5e6bb62
Update carstate.py
CryptoKylan e41b90f
Update carstate.py
CryptoKylan b42b8d4
Update carstate.py
CryptoKylan 7744960
Update carstate.py
CryptoKylan c4962eb
Update carstate.py
CryptoKylan e355530
Update carstate.py
CryptoKylan 8d4ed62
Update radar_interface.py
CryptoKylan b356456
Update pathplanner.py
CryptoKylan 980a361
Merge pull request #40 from commaai/devel
CryptoKylan 5e4df67
Merge pull request #45 from commaai/devel
CryptoKylan 5715403
updated delta up and down
CryptoKylan 891aba2
fixed comment
CryptoKylan File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this requires a safety change in panda. Also, I would rather fix the comments instead of changing the rate limits. They were tuned for what was considered safe.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just thought the point was to hit peak torque in or under 0.75 seconds. What I'm seeing now is when we're hitting the max steering cmd of 300 actual delivered torque is still falling behind to around 250 ish and slowly creeps up if max steer remains saturated from what I can tell. By raising the step from 7 to 8 this gets actual torque delivered to better match the steering cmd and stays within commas safety standards.
I did also submit the PR for the panda changes.
So just to be clear you don't want to raise the steer delta to match time to peak torque now that max steer is now 300?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@CryptoKylan , correct: the rate limit should stay the same, as the safety standard is defined in terms of rate of steer torque (~Nm/s) rather than how long it takes to get to peak torque. Makes sense?