add scdoc documentation tool #8598
Conversation
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
recipes/scdoc/all/conanfile.py
Outdated
| return "source_subfolder" | ||
|
|
||
| def build_requirements(self): | ||
| self.build_requires("make/[>=4.3.0]") |
There was a problem hiding this comment.
| self.build_requires("make/[>=4.3.0]") | |
| self.build_requires("make/4.3.0]") |
Ranged version is not allowed for Conan Center
There was a problem hiding this comment.
There is a comment here #8588 (comment) indicating ranges may be considered for build dependencies. Is it confirmed ?
This comment has been minimized.
This comment has been minimized.
|
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
All green in build 9 (
|
|
Why did you rebase and force push? Your PR was ready to be merged 😱 I opened a PR since the docs were not clear #8797 |
|
Please do not force push 🙏 GitHub forces us to restart the review which is not fun! |
|
I am terribly sorry :( I force pushed because I identified an issue with the pkg-config file generated by the recipe (It did not include the same info as the one packaged with the source preventing it to be used by other packages to use it correctly). Shall I use fixup commits instead to apply modifications during a review ? |
|
That's absolutely alright. Thanks for catching the issue! Please make new commits 🙏 it's much easier for us to review that way. |
| self.output.info( | ||
| "Appending PATH environment variable: {}".format(scdoc_root)) | ||
| self.env_info.PATH.append(scdoc_root) | ||
| self._chmod_plus_x(os.path.join(scdoc_root, "scdoc")) |
There was a problem hiding this comment.
We usually do it when packaging, but I think you want to be sure the user will have permission to execute the binary.
…update-from-conan-io * 'master' of github.com:conan-io/conan-center-index: (480 commits) (conan-io#8840) wslay: modernize (conan-io#8830) Deprecate diligentgraphics-spirv-tools (conan-io#8829) Deprecate diligentgraphics-spirv-headers (conan-io#8828) Deprecate diligentgraphics-vulkan-headers (conan-io#8819) nanoflann: add 1.4.2 + modernize (conan-io#8814) coin-lemon: restore .names["pkg_config"] (conan-io#8797) Let contributors know to avoid rebasing (conan-io#8809) libalsa: restore .names["pkg_config"] + add ALSA_CONFIG_DIR to runenv_info (conan-io#8807) pkgconf: restore .names["pkg_config"] (conan-io#8741) spirv-headers: fix pkg_config name + modernize (conan-io#8732) oniguruma: modernize (conan-io#8684) libtiff: modernize (conan-io#8632) cpython: Add PATH variable only if env_vars option is enabled. (conan-io#7331) (conan-io#7329) Support Gandiva in Arrow 2.0.0 (conan-io#8598) add scdoc documentation tool (conan-io#8796) backport-cpp: modernize (conan-io#8793) cpp-ipc: add version 1.2.0 (conan-io#8778) variant-lite: modernize (conan-io#8777) string-view-lite: modernize (conan-io#8775) scope-lite: modernize ...
Specify library name and version: scdoc/1.11.12
I am not the author of the tool but I need it for some of my projects.
conan-center hook activated.