Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cpython: Add PATH variable only if env_vars option is enabled. #8632

Merged
merged 1 commit into from
Jan 12, 2022

Conversation

sh0
Copy link
Contributor

@sh0 sh0 commented Jan 4, 2022

Specify library name and version: cpython/3.10.0

Currently when env_vars option is off the PATH variable still gets expanded with python executable path. This may hijack system Python depending on PATH order in activate_run etc. Moreover since PYTHONHOME/PYTHON_ROOT are not defined that Conan Python is broken as it tries to load wrong system Python standard libraries. This PR proposes to only expand PATH when env_vars is enabled. Thoughts?


  • I've read the guidelines for contributing.
  • I've followed the PEP8 style guides for Python code in the recipes.
  • I've used the latest Conan client version.
  • I've tried at least one configuration locally with the
    conan-center hook activated.

Also add small info string fix to PYTHONHOME.
@conan-center-bot

This comment has been minimized.

@sh0 sh0 closed this Jan 5, 2022
@sh0 sh0 reopened this Jan 5, 2022
@conan-center-bot

This comment has been minimized.

@conan-center-bot
Copy link
Collaborator

All green in build 3 (208f01ebebc8df04b0678548c183adfadb7a506e):

  • cpython/3.10.0@:
    All packages built successfully! (All logs)

  • cpython/3.9.7@:
    All packages built successfully! (All logs)

  • cpython/3.8.12@:
    All packages built successfully! (All logs)

  • cpython/3.7.12@:
    All packages built successfully! (All logs)

  • cpython/2.7.18@:
    All packages built successfully! (All logs)

Copy link
Member

@uilianries uilianries left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's a reasonable option. By default it will enabled, and we know the mess that can be python environment.

@conan-center-bot conan-center-bot merged commit b60e3d7 into conan-io:master Jan 12, 2022
miklelappo pushed a commit to miklelappo/conan-center-index that referenced this pull request Feb 9, 2022
… enabled.

Also add small info string fix to PYTHONHOME.
datalogics-robb pushed a commit to datalogics-robb/conan-center-index that referenced this pull request Mar 6, 2023
…update-from-conan-io

* 'master' of github.com:conan-io/conan-center-index: (480 commits)
  (conan-io#8840) wslay: modernize
  (conan-io#8830) Deprecate diligentgraphics-spirv-tools
  (conan-io#8829) Deprecate diligentgraphics-spirv-headers
  (conan-io#8828) Deprecate diligentgraphics-vulkan-headers
  (conan-io#8819) nanoflann: add 1.4.2 + modernize
  (conan-io#8814) coin-lemon: restore .names["pkg_config"]
  (conan-io#8797) Let contributors know to avoid rebasing
  (conan-io#8809) libalsa: restore .names["pkg_config"] + add ALSA_CONFIG_DIR to runenv_info
  (conan-io#8807) pkgconf: restore .names["pkg_config"]
  (conan-io#8741) spirv-headers: fix pkg_config name + modernize
  (conan-io#8732) oniguruma: modernize
  (conan-io#8684) libtiff: modernize
  (conan-io#8632) cpython: Add PATH variable only if env_vars option is enabled.
  (conan-io#7331) (conan-io#7329) Support Gandiva in Arrow 2.0.0
  (conan-io#8598) add scdoc documentation tool
  (conan-io#8796) backport-cpp: modernize
  (conan-io#8793) cpp-ipc: add version 1.2.0
  (conan-io#8778) variant-lite: modernize
  (conan-io#8777) string-view-lite: modernize
  (conan-io#8775) scope-lite: modernize
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants