Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

variant-lite: modernize #8778

Merged
merged 1 commit into from
Jan 12, 2022

Conversation

SpaceIm
Copy link
Contributor

@SpaceIm SpaceIm commented Jan 10, 2022

Specify library name and version: lib/1.0

This is also a good place to share with all of us why you are submitting this PR (specially if it is a new addition to ConanCenter): is it a dependency of other libraries you want to package? Are you the author of the library? Thanks!


  • I've read the guidelines for contributing.
  • I've followed the PEP8 style guides for Python code in the recipes.
  • I've used the latest Conan client version.
  • I've tried at least one configuration locally with the
    conan-center hook activated.

@conan-center-bot
Copy link
Collaborator

All green in build 1 (38c114e237b3de3d092e0e83b228cb151dc8dd92):

  • variant-lite/2.0.0@:
    All packages built successfully! (All logs)

  • variant-lite/1.2.2@:
    All packages built successfully! (All logs)

Copy link
Member

@uilianries uilianries left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

self.cpp_info.set_property("cmake_file_name", "variant-lite")
self.cpp_info.set_property("cmake_target_name", "nonstd::variant-lite")

# TODO: to remove in conan v2 once cmake_find_package* generators removed
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👋 If I followed the changes correctly...

The 7 lines below will be replaced with just two?! 🤯

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes

@conan-center-bot conan-center-bot merged commit c46d8bb into conan-io:master Jan 12, 2022
@SpaceIm SpaceIm deleted the variant-lite-modernize branch January 12, 2022 08:28
miklelappo pushed a commit to miklelappo/conan-center-index that referenced this pull request Feb 9, 2022
datalogics-robb pushed a commit to datalogics-robb/conan-center-index that referenced this pull request Mar 6, 2023
…update-from-conan-io

* 'master' of github.com:conan-io/conan-center-index: (480 commits)
  (conan-io#8840) wslay: modernize
  (conan-io#8830) Deprecate diligentgraphics-spirv-tools
  (conan-io#8829) Deprecate diligentgraphics-spirv-headers
  (conan-io#8828) Deprecate diligentgraphics-vulkan-headers
  (conan-io#8819) nanoflann: add 1.4.2 + modernize
  (conan-io#8814) coin-lemon: restore .names["pkg_config"]
  (conan-io#8797) Let contributors know to avoid rebasing
  (conan-io#8809) libalsa: restore .names["pkg_config"] + add ALSA_CONFIG_DIR to runenv_info
  (conan-io#8807) pkgconf: restore .names["pkg_config"]
  (conan-io#8741) spirv-headers: fix pkg_config name + modernize
  (conan-io#8732) oniguruma: modernize
  (conan-io#8684) libtiff: modernize
  (conan-io#8632) cpython: Add PATH variable only if env_vars option is enabled.
  (conan-io#7331) (conan-io#7329) Support Gandiva in Arrow 2.0.0
  (conan-io#8598) add scdoc documentation tool
  (conan-io#8796) backport-cpp: modernize
  (conan-io#8793) cpp-ipc: add version 1.2.0
  (conan-io#8778) variant-lite: modernize
  (conan-io#8777) string-view-lite: modernize
  (conan-io#8775) scope-lite: modernize
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants