-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
variant-lite: modernize #8778
variant-lite: modernize #8778
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
self.cpp_info.set_property("cmake_file_name", "variant-lite") | ||
self.cpp_info.set_property("cmake_target_name", "nonstd::variant-lite") | ||
|
||
# TODO: to remove in conan v2 once cmake_find_package* generators removed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👋 If I followed the changes correctly...
The 7 lines below will be replaced with just two?! 🤯
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes
…update-from-conan-io * 'master' of github.com:conan-io/conan-center-index: (480 commits) (conan-io#8840) wslay: modernize (conan-io#8830) Deprecate diligentgraphics-spirv-tools (conan-io#8829) Deprecate diligentgraphics-spirv-headers (conan-io#8828) Deprecate diligentgraphics-vulkan-headers (conan-io#8819) nanoflann: add 1.4.2 + modernize (conan-io#8814) coin-lemon: restore .names["pkg_config"] (conan-io#8797) Let contributors know to avoid rebasing (conan-io#8809) libalsa: restore .names["pkg_config"] + add ALSA_CONFIG_DIR to runenv_info (conan-io#8807) pkgconf: restore .names["pkg_config"] (conan-io#8741) spirv-headers: fix pkg_config name + modernize (conan-io#8732) oniguruma: modernize (conan-io#8684) libtiff: modernize (conan-io#8632) cpython: Add PATH variable only if env_vars option is enabled. (conan-io#7331) (conan-io#7329) Support Gandiva in Arrow 2.0.0 (conan-io#8598) add scdoc documentation tool (conan-io#8796) backport-cpp: modernize (conan-io#8793) cpp-ipc: add version 1.2.0 (conan-io#8778) variant-lite: modernize (conan-io#8777) string-view-lite: modernize (conan-io#8775) scope-lite: modernize ...
Specify library name and version: lib/1.0
This is also a good place to share with all of us why you are submitting this PR (specially if it is a new addition to ConanCenter): is it a dependency of other libraries you want to package? Are you the author of the library? Thanks!
conan-center hook activated.