vars/kola: Add support for skipping a list of kola tags #159
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marmijo
requested review from
jlebon,
ravanelli,
mike-nguyen,
gursewak1997 and
dustymabe
as code owners
marmijo
added a commit
to marmijo/fedora-coreos-pipeline
that referenced
this pull request
Jun 21, 2024
Kola can now support skipping kola tags per stream[1]. Add support for that here by modifying each Jenkins job to pass the list of kola tags to skip to the kola function. [1]: coreos/coreos-ci-lib#159 See: coreos#1002
marmijo
added a commit
to marmijo/fedora-coreos-pipeline
that referenced
this pull request
Jun 21, 2024
Kola can now support skipping kola tags per stream[1]. Add support for that here by modifying each Jenkins job to pass the list of kola tags to skip to the kola function. [1]: coreos/coreos-ci-lib#159 See: coreos#1002
jlebon
reviewed
Jun 21, 2024
vars/kola.groovy
Outdated
| @@ -102,6 +103,13 @@ def call(params = [:]) { | |||
| args += " --exttest=${env.WORKSPACE}/${path}" | |||
| } | |||
|
|
|||
| def skipKolaTags = params.get('skipKolaTags', "") | |||
| def skipKolaTagsArgs = "" | |||
There was a problem hiding this comment.
How about instead of this new variable, we just keep modifying args like we do for other directives?
There was a problem hiding this comment.
I had thought about that, but args isnt passed to all of the kola() runs. Now that we aren't passing this to all of them, I'll simplify it and just append to args 👍
vars/kola.groovy
Outdated
| def skipKolaTagsArgs = "" | ||
|
|
||
| for (tag in skipKolaTags) { | ||
| skipKolaTagsArgs += "--tag=!${tag} " |
There was a problem hiding this comment.
So then, this would be
Suggested change
| skipKolaTagsArgs += "--tag=!${tag} " | |
| args += " --tag=!${tag}" |
vars/kola.groovy
Outdated
| @@ -157,7 +165,7 @@ def call(params = [:]) { | |||
| def id = marker == "" ? "kola-upgrade" : "kola-upgrade-${marker}" | |||
| ids += id | |||
| try { | |||
| runKola(id, 'run-upgrade', "--upgrades") | |||
| runKola(id, 'run-upgrade', "--upgrades ${skipKolaTagsArgs}") | |||
There was a problem hiding this comment.
I think let's keep out upgrade tests from this for now. It currently doesn't run for RHCOS and those tests should instead be converted into regular kola tests (see also discussions in coreos/coreos-assembler#3714).
There was a problem hiding this comment.
Will do, I wasnt sure if this would be required for the upgrade tests. I'll remove it.
marmijo
commented
Jun 21, 2024
marmijo
added a commit
to marmijo/fedora-coreos-pipeline
that referenced
this pull request
Jun 21, 2024
Kola can now support skipping kola tags per stream[1]. Add support for that here by modifying each Jenkins job to pass the list of kola tags to skip to the kola function. [1]: coreos/coreos-ci-lib#159 See: coreos#1002
marmijo
added a commit
to marmijo/fedora-coreos-pipeline
that referenced
this pull request
Jun 21, 2024
Kola can now support skipping kola tags per stream[1]. Add support for that here by modifying each Jenkins job to pass the list of kola tags to skip to the kola function. [1]: coreos/coreos-ci-lib#159 See: coreos#1002
jlebon
reviewed
Jun 21, 2024
Introduce a kola parameter to allow skipping a list of kola tags. This is particularly useful when adding new streams to the pipeline. xref: coreos/fedora-coreos-pipeline#1008 Reference: coreos/fedora-coreos-pipeline#1002
jlebon
pushed a commit
to coreos/fedora-coreos-pipeline
that referenced
this pull request
Jun 21, 2024
Kola can now support skipping kola tags per stream[1]. Add support for that here by modifying each Jenkins job to pass the list of kola tags to skip to the kola function. [1]: coreos/coreos-ci-lib#159 See: #1002
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce a kola parameter to allow skipping a list of kola tags. This is particularly useful when adding new streams to the pipeline.
xref: coreos/fedora-coreos-pipeline#1008
See: coreos/fedora-coreos-pipeline#1002