jobs/build: add support for stream level skip_kola_tags knob
#1008
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marmijo
added a commit
to marmijo/coreos-ci-lib
that referenced
this pull request
Jun 21, 2024
Introduce a kola parameter to allow skipping a list of kola tags. This is particularly useful when adding new streams to the pipeline. xref: coreos/fedora-coreos-pipeline#1008 Reference: coreos/fedora-coreos-pipeline#1002
jlebon
approved these changes
Jun 21, 2024
There was a problem hiding this comment.
Small nit, but LGTM overall!
One thing I'll mention is that another way we could have done this is to extend test metadata to specify the variants against which it can run (similarly to what we have today for distros, or maybe even as an extension to that, e.g. distros: [fcos, rhcos:my-variant]).
OTOH, this is straightforward and it's not clear whether we'll need this functionality again once we've fully moved over to the new variants. At which point, we could also revert this PR and the one in coreos-ci-lib.
jobs/kola-azure.Jenkinsfile
Outdated
| @@ -138,7 +138,8 @@ cosaPod(memory: "${cosa_memory_request_mb}Mi", kvm: false, | |||
| platformArgs: """-p=azure \ | |||
| --azure-credentials \${AZURE_KOLA_TESTS_CONFIG} \ | |||
| --azure-location $region \ | |||
| --azure-disk-uri /subscriptions/${azure_subscription}/resourceGroups/${azure_testing_resource_group}/providers/Microsoft.Compute/images/${azure_image_name}""") | |||
| --azure-disk-uri /subscriptions/${azure_subscription}/resourceGroups/${azure_testing_resource_group}/providers/Microsoft.Compute/images/${azure_image_name}""", | |||
| skipKolaTags: stream_info.skip_kola_tags) | |||
marmijo
added a commit
to marmijo/coreos-ci-lib
that referenced
this pull request
Jun 21, 2024
Introduce a kola parameter to allow skipping a list of kola tags. This is particularly useful when adding new streams to the pipeline. xref: coreos/fedora-coreos-pipeline#1008 Reference: coreos/fedora-coreos-pipeline#1002
Kola can now support skipping kola tags per stream[1]. Add support for that here by modifying each Jenkins job to pass the list of kola tags to skip to the kola function. [1]: coreos/coreos-ci-lib#159 See: coreos#1002
jlebon
approved these changes
Jun 21, 2024
marmijo
added a commit
to marmijo/coreos-ci-lib
that referenced
this pull request
Jun 21, 2024
Introduce a kola parameter to allow skipping a list of kola tags. This is particularly useful when adding new streams to the pipeline. xref: coreos/fedora-coreos-pipeline#1008 Reference: coreos/fedora-coreos-pipeline#1002
jlebon
pushed a commit
to coreos/coreos-ci-lib
that referenced
this pull request
Jun 21, 2024
Introduce a kola parameter to allow skipping a list of kola tags. This is particularly useful when adding new streams to the pipeline. xref: coreos/fedora-coreos-pipeline#1008 Reference: coreos/fedora-coreos-pipeline#1002
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Kola can now support skipping kola tags per stream [1]. Add support for that here by modifying each Jenkins job to pass the list of kola tags to skip to the kola function.
[1]: coreos/coreos-ci-lib#159
See: #1002